From 09c6dea132409f5009319161bdfd9e6e4c8f725c Mon Sep 17 00:00:00 2001 From: Darek Stojaczyk Date: Tue, 17 Mar 2020 10:46:39 +0100 Subject: [PATCH] nvmf/rpc: remove NULL checks for spdk_jsonrpc_begin_result() spdk_jsonrpc_begin_result() was changed to always return non-NULL a while ago. Most of the checks were removed from SPDK, but this one must have been omitted because to its unusual structure. Change-Id: If305d7a27d8e6bd4dae1aa8221efabba50db1982 Signed-off-by: Darek Stojaczyk Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1330 Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto --- lib/nvmf/nvmf_rpc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/nvmf/nvmf_rpc.c b/lib/nvmf/nvmf_rpc.c index 5ee1d5a85..ce597751a 100644 --- a/lib/nvmf/nvmf_rpc.c +++ b/lib/nvmf/nvmf_rpc.c @@ -1958,11 +1958,6 @@ spdk_rpc_nvmf_get_stats(struct spdk_jsonrpc_request *request, } ctx->w = spdk_jsonrpc_begin_result(ctx->request); - if (NULL == ctx->w) { - free_get_stats_ctx(ctx); - return; - } - spdk_json_write_object_begin(ctx->w); spdk_json_write_named_uint64(ctx->w, "tick_rate", spdk_get_ticks_hz()); spdk_json_write_named_array_begin(ctx->w, "poll_groups");