From 07f06329568fd95ea8e01d36b890475737db6b24 Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Wed, 21 Jul 2021 21:56:08 +0800 Subject: [PATCH] nvmf/vfio-user: optimize NVMe command log Previously vfio-user doesn't print IO commands. Change-Id: Id3b10b9b22487b448765cee5a3dbf5fcf680973c Signed-off-by: Changpeng Liu Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8867 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Thanos Makatos Reviewed-by: Jim Harris Reviewed-by: Dong Yi Reviewed-by: Aleksey Marchuk Reviewed-by: Ziye Yang --- lib/nvmf/vfio_user.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/nvmf/vfio_user.c b/lib/nvmf/vfio_user.c index b22b241e3..5cb02a290 100644 --- a/lib/nvmf/vfio_user.c +++ b/lib/nvmf/vfio_user.c @@ -1303,9 +1303,6 @@ consume_admin_cmd(struct nvmf_vfio_user_ctrlr *ctrlr, struct spdk_nvme_cmd *cmd) assert(ctrlr != NULL); assert(cmd != NULL); - SPDK_DEBUGLOG(nvmf_vfio, "%s: handle admin req opc=%#x cid=%d\n", - ctrlr_id(ctrlr), cmd->opc, cmd->cid); - switch (cmd->opc) { case SPDK_NVME_OPC_CREATE_IO_CQ: case SPDK_NVME_OPC_CREATE_IO_SQ: @@ -2689,6 +2686,11 @@ handle_cmd_req(struct nvmf_vfio_user_ctrlr *ctrlr, struct spdk_nvme_cmd *cmd, if (spdk_unlikely(req == NULL)) { return -1; } + + assert(req->qpair != NULL); + SPDK_DEBUGLOG(nvmf_vfio, "%s: handle qid%u, req opc=%#x cid=%d\n", + ctrlr_id(ctrlr), req->qpair->qid, cmd->opc, cmd->cid); + vu_req = SPDK_CONTAINEROF(req, struct nvmf_vfio_user_req, req); vu_req->cb_fn = handle_cmd_rsp; vu_req->cb_arg = SPDK_CONTAINEROF(req->qpair, struct nvmf_vfio_user_qpair, qpair);