From 0473a78165f50e1b763e8869594ffb0336f65766 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Fri, 17 Feb 2023 11:32:56 +0100 Subject: [PATCH] accel: clear out domain/step_cb pointers in encrypt/decrypt They aren't cleared before a task is submitted and might store pointers from a previous operation. This can lead to issues if the previous operation was using memory domains and we submit the task to a module also supporting memory domains. Signed-off-by: Konrad Sztyber Change-Id: Icafb924c2e936ee6a83d921ae48e953b98f00841 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16848 Community-CI: Mellanox Build Bot Reviewed-by: Artur Paszkiewicz Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins Reviewed-by: Aleksey Marchuk --- lib/accel/accel.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/accel/accel.c b/lib/accel/accel.c index ad987524c..f92187d66 100644 --- a/lib/accel/accel.c +++ b/lib/accel/accel.c @@ -657,6 +657,9 @@ spdk_accel_submit_encrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_k accel_task->block_size = block_size; accel_task->flags = flags; accel_task->op_code = ACCEL_OPC_ENCRYPT; + accel_task->src_domain = NULL; + accel_task->dst_domain = NULL; + accel_task->step_cb_fn = NULL; return module->submit_tasks(module_ch, accel_task); } @@ -691,6 +694,9 @@ spdk_accel_submit_decrypt(struct spdk_io_channel *ch, struct spdk_accel_crypto_k accel_task->block_size = block_size; accel_task->flags = flags; accel_task->op_code = ACCEL_OPC_DECRYPT; + accel_task->src_domain = NULL; + accel_task->dst_domain = NULL; + accel_task->step_cb_fn = NULL; return module->submit_tasks(module_ch, accel_task); }