ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme/fabric: Make connect related logs more verbose

Browse Source 
Add logging of transport address and status codes

Fixes issue #1790

Change-Id: I67c23f74dd4a4b39233f50c4c29efe25872e0777
Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6338
Community-CI: Broadcom CI
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Alexey Marchuk 2021-02-09 15:23:22 +03:00 committed by Tomasz Zawadzki
parent 5e37d3b2d8
commit 04474fec32
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/nvme/nvme_fabric.c
View File

@ -448,15 +448,26 @@ nvme_fabric_qpair_connect(struct spdk_nvme_qpair *qpair, uint32_t num_entries)
nvmf_data, sizeof(*nvmf_data),
nvme_completion_poll_cb, status);
if (rc < 0) {
SPDK_ERRLOG("Connect command failed\n");
SPDK_ERRLOG("Failed to allocate/submit FABRIC_CONNECT command, rc %d\n", rc);
spdk_free(nvmf_data);
free(status);
return rc;
}
/* If we time out, the qpair will abort the request upon destruction. */
if (nvme_wait_for_completion_timeout(qpair, status, ctrlr->opts.fabrics_connect_timeout_us)) {
SPDK_ERRLOG("Connect command failed\n");
rc = nvme_wait_for_completion_timeout(qpair, status, ctrlr->opts.fabrics_connect_timeout_us);
if (rc) {
SPDK_ERRLOG("Connect command failed, rc %d, trtype:%s adrfam:%s traddr:%s trsvcid:%s subnqn:%s\n",
rc,
spdk_nvme_transport_id_trtype_str(ctrlr->trid.trtype),
spdk_nvme_transport_id_adrfam_str(ctrlr->trid.adrfam),
ctrlr->trid.traddr,
ctrlr->trid.trsvcid,
ctrlr->trid.subnqn);
if (spdk_nvme_cpl_is_error(&status->cpl)) {
SPDK_ERRLOG("Connect command completed with error: sct %d, sc %d\n", status->cpl.status.sct,
status->cpl.status.sc);
}
spdk_free(nvmf_data);
if (!status->timed_out) {
free(status);