From 040801010a057563ac7de80ad87a45161de52b02 Mon Sep 17 00:00:00 2001 From: JinYu Date: Fri, 10 May 2019 18:46:52 +0800 Subject: [PATCH] unit/nvme: add spdk_nvme_connect unit test case cover the opts_size examination Change-Id: I8058f1db98713b5f19151b1b127180ae5ec58b96 Signed-off-by: JinYu Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/453944 Tested-by: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- test/unit/lib/nvme/nvme.c/nvme_ut.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/unit/lib/nvme/nvme.c/nvme_ut.c b/test/unit/lib/nvme/nvme.c/nvme_ut.c index dee66cdee..021e0e7ed 100644 --- a/test/unit/lib/nvme/nvme.c/nvme_ut.c +++ b/test/unit/lib/nvme/nvme.c/nvme_ut.c @@ -220,6 +220,9 @@ test_spdk_nvme_connect(void) ret_ctrlr = spdk_nvme_connect(&trid, &opts, sizeof(opts)); CU_ASSERT(ret_ctrlr == &ctrlr); CU_ASSERT_EQUAL(ret_ctrlr->opts.num_io_queues, 1); + /* opts_size must be sizeof(*opts) if opts != NULL */ + ret_ctrlr = spdk_nvme_connect(&trid, &opts, sizeof(opts) + 1); + CU_ASSERT(ret_ctrlr == NULL); /* remove the attached ctrlr on the attached_list */ CU_ASSERT(spdk_nvme_detach(&ctrlr) == 0); CU_ASSERT(TAILQ_EMPTY(&g_spdk_nvme_driver->shared_attached_ctrlrs));