ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: make submit request error handle in one place

Browse Source 
rc to -ENXIO and goto error, make all error handle in one place,
so it's easy to add more check in later patch.

Change-Id: I13edeef75bbf6c52e18d6b94b78c2e560012bfee
Signed-off-by: Fengnan Chang <changfengnan@bytedance.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16004
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Fengnan Chang 2022-12-21 10:52:43 +08:00 committed by Jim Harris
parent 6ac1082864
commit 02ecb2dcba
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/nvme/nvme_qpair.c
View File

@ -935,11 +935,9 @@ _nvme_qpair_submit_request(struct spdk_nvme_qpair *qpair, struct nvme_request *r
nvme_request_free_children(child_req); nvme_request_free_children(child_req);
nvme_free_request(child_req); nvme_free_request(child_req);
} }
if (req->parent != NULL) {
nvme_request_remove_child(req->parent, req); rc = -ENXIO;
} goto error;
nvme_free_request(req);
return -ENXIO;
} }
if (req->num_children) { if (req->num_children) {