From 0238b5c42acaf5cfd4f786f737f69184e160f129 Mon Sep 17 00:00:00 2001 From: wuzhouhui Date: Fri, 15 Feb 2019 09:59:55 +0800 Subject: [PATCH] bdev/ftl: unlock g_ftl_bdev_lock before unregister ftl_bdev There is no need to lock g_ftl_bdev_lock when unregister a ftl_bdev. Besides, the destructor of ftl_bdev will lock it again. Change-Id: I99870483183879d9422584dbac6e154f605daea8 Signed-off-by: wuzhouhui Reviewed-on: https://review.gerrithub.io/c/444794 Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Konrad Sztyber Reviewed-by: Ben Walker --- lib/bdev/ftl/bdev_ftl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/bdev/ftl/bdev_ftl.c b/lib/bdev/ftl/bdev_ftl.c index d9e96708e..6833cf673 100644 --- a/lib/bdev/ftl/bdev_ftl.c +++ b/lib/bdev/ftl/bdev_ftl.c @@ -887,9 +887,8 @@ bdev_ftl_delete_bdev(const char *name, spdk_bdev_unregister_cb cb_fn, void *cb_a LIST_FOREACH_SAFE(ftl_bdev, &g_ftl_bdevs, list_entry, tmp) { if (strcmp(ftl_bdev->bdev.name, name) == 0) { - spdk_bdev_unregister(&ftl_bdev->bdev, cb_fn, cb_arg); - pthread_mutex_unlock(&g_ftl_bdev_lock); + spdk_bdev_unregister(&ftl_bdev->bdev, cb_fn, cb_arg); return; } }