From 01088b69061da05ac6e0fc3eb828a23356bb5af0 Mon Sep 17 00:00:00 2001 From: Liu Xiaodong Date: Tue, 14 May 2019 05:17:49 -0400 Subject: [PATCH] test/notify: fix parameters' mismatching Previous test cases got passed, is because all parameters are filtered to be same accidentally, for example: Previous, they are event=bdev_register:66ab4189 ev_type=bdev_register:66ab4189 ev_ctx=bdev_register:66ab4189 ex_ev_type='bdev_register:[[:alnum:]-]+' ex_ev_ctx='bdev_register:[[:alnum:]-]+' But actually they should be: event=bdev_register:66ab4189 ev_type=bdev_register ev_ctx=66ab4189 ex_ev_type='bdev_register' ex_ev_ctx='[[:alnum:]-]+' Signed-off-by: Liu Xiaodong Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/454442 (master) (cherry picked from commit 31736dc25c303d47d514c505e27e3cd3fa3d6bd4) Change-Id: I7a2dc801931f792a39fc2775d883679cf8185fd0 Signed-off-by: Tomasz Zawadzki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/457240 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Paul Luse --- test/json_config/json_config.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/json_config/json_config.sh b/test/json_config/json_config.sh index 8575c8f05..1e4be1cfa 100755 --- a/test/json_config/json_config.sh +++ b/test/json_config/json_config.sh @@ -56,11 +56,11 @@ function tgt_check_notifications() { # remove ID event="${event_line%:*}" - ev_type=${event%*:} - ev_ctx=${event#:*} + ev_type=${event%:*} + ev_ctx=${event#*:} - ex_ev_type=${1%*:} - ex_ev_ctx=${1#:*} + ex_ev_type=${1%%:*} + ex_ev_ctx=${1#*:} last_event_id=${event_line##*:}