From 00df37cbb691f5dd912048d418243eb2ff9698f8 Mon Sep 17 00:00:00 2001 From: Nick Connolly Date: Mon, 26 Apr 2021 13:42:40 +0100 Subject: [PATCH] ut/nvme_ctrlr_cmd: add missing mutex init Add missing mutex init for ctrlr ctrlr_lock. Signed-off-by: Nick Connolly Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7613 (master) (cherry picked from commit 0fdd826a009ffc496cf614fdf4afba6c4dff56f3) Change-Id: Ib3d665a28e91a72d1f1f6d09c374583ff731fb6f Signed-off-by: Krzysztof Karas Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7676 Reviewed-by: Tomasz Zawadzki Reviewed-by: Nick Connolly Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins --- test/unit/lib/nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/unit/lib/nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c b/test/unit/lib/nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c index fdbdb2864..610ce9903 100644 --- a/test/unit/lib/nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c +++ b/test/unit/lib/nvme/nvme_ctrlr_cmd.c/nvme_ctrlr_cmd_ut.c @@ -899,6 +899,7 @@ test_spdk_nvme_ctrlr_cmd_abort(void) ctrlr.adminq = &admin_qpair; admin_qpair.id = 0; MOCK_SET(nvme_ctrlr_submit_admin_request, 0); + CU_ASSERT(pthread_mutex_init(&ctrlr.ctrlr_lock, NULL) == 0); rc = spdk_nvme_ctrlr_cmd_abort(&ctrlr, qpair, 2, (void *)0xDEADBEEF, (void *)0xDCADBEEF); CU_ASSERT(rc == 0); @@ -914,6 +915,7 @@ test_spdk_nvme_ctrlr_cmd_abort(void) rc = spdk_nvme_ctrlr_cmd_abort(&ctrlr, qpair, 2, (void *)0xDEADBEEF, (void *)0xDCADBEEF); CU_ASSERT(rc == -ENOMEM); MOCK_CLEAR(nvme_ctrlr_submit_admin_request); + CU_ASSERT(pthread_mutex_destroy(&ctrlr.ctrlr_lock) == 0); } int main(int argc, char **argv)