From 002cd18b608c59782672b57124a8a4544583ef50 Mon Sep 17 00:00:00 2001
From: GangCao <gang.cao@intel.com>
Date: Tue, 29 Nov 2022 01:42:11 -0500
Subject: [PATCH] bdev/nvme: add the return check when creating ctrlr

Change-Id: I125b52056e51fc4f936d91ac2326b5a0f526f0ce
Signed-off-by: GangCao <gang.cao@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15679
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Mellanox Build Bot
---
 module/bdev/nvme/bdev_nvme.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/module/bdev/nvme/bdev_nvme.c b/module/bdev/nvme/bdev_nvme.c
index a3d7421af..0826ab55e 100644
--- a/module/bdev/nvme/bdev_nvme.c
+++ b/module/bdev/nvme/bdev_nvme.c
@@ -4355,9 +4355,11 @@ attach_cb(void *cb_ctx, const struct spdk_nvme_transport_id *trid,
 		return;
 	}
 
-	SPDK_DEBUGLOG(bdev_nvme, "Attached to %s (%s)\n", trid->traddr, name);
-
-	nvme_ctrlr_create(ctrlr, name, trid, NULL);
+	if (nvme_ctrlr_create(ctrlr, name, trid, NULL) == 0) {
+		SPDK_DEBUGLOG(bdev_nvme, "Attached to %s (%s)\n", trid->traddr, name);
+	} else {
+		SPDK_ERRLOG("Failed to attach to %s (%s)\n", trid->traddr, name);
+	}
 
 	free(name);
 }