ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
fb0b17a19f
Spdk/test/unit/lib/vhost/vhost.c/vhost_ut.c

345 lines
11 KiB
C
Raw Normal View History

vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
/*-
* BSD LICENSE
*
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "spdk/stdinc.h"
#include "CUnit/Basic.h"
#include "spdk_cunit.h"
#include "spdk_internal/mock.h"
vhost: use external event API in get_vhost_controllers RPC call Added spdk_vhost_call_external_event_foreach. Continuation of patch I689226c [1] [1] vhost: added API to call external spdk_events on vdev reactor Change-Id: I5a404ec9de586d197e84eeda82009a803b4fa623 Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/373262 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-08 16:52:53 +00:00
#include "lib/test_env.c"
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
#include "vhost.c"
DEFINE_STUB(rte_vhost_driver_unregister, int, (const char *path), 0);
DEFINE_STUB(spdk_event_allocate, struct spdk_event *,
(uint32_t lcore, spdk_event_fn fn, void *arg1, void *arg2), NULL);
env/vtophys: vtophys functions will now return error codes Change-Id: Ic2b799c7d1dbd3249a890a79f42118fc79a30b94 Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/373223 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-08-08 10:54:37 +00:00
DEFINE_STUB(spdk_mem_register, int, (void *vaddr, size_t len), 0);
DEFINE_STUB(spdk_mem_unregister, int, (void *vaddr, size_t len), 0);
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
DEFINE_STUB(spdk_app_get_core_mask, uint64_t, (void), 0);
DEFINE_STUB_V(spdk_app_stop, (int rc));
DEFINE_STUB_V(spdk_event_call, (struct spdk_event *event));
DEFINE_STUB(spdk_iommu_mem_unregister, int, (uint64_t addr, uint64_t len), 0);
DEFINE_STUB(rte_vhost_get_mem_table, int, (int vid, struct rte_vhost_memory **mem), 0);
DEFINE_STUB(rte_vhost_get_negotiated_features, int, (int vid, uint64_t *features), 0);
DEFINE_STUB(rte_vhost_get_vhost_vring, int,
(int vid, uint16_t vring_idx, struct rte_vhost_vring *vring), 0);
DEFINE_STUB(rte_vhost_enable_guest_notification, int,
(int vid, uint16_t queue_id, int enable), 0);
DEFINE_STUB(rte_vhost_get_ifname, int, (int vid, char *buf, size_t len), 0);
DEFINE_STUB(rte_vhost_get_vring_num, uint16_t, (int vid), 0);
DEFINE_STUB(rte_vhost_driver_start, int, (const char *name), 0);
DEFINE_STUB(rte_vhost_driver_callback_register, int,
(const char *path, struct vhost_device_ops const *const ops), 0);
DEFINE_STUB(rte_vhost_driver_disable_features, int, (const char *path, uint64_t features), 0);
DEFINE_STUB(rte_vhost_driver_set_features, int, (const char *path, uint64_t features), 0);
DEFINE_STUB(rte_vhost_driver_register, int, (const char *path, uint64_t flags), 0);
DEFINE_STUB(spdk_vhost_scsi_controller_construct, int, (void), 0);
DEFINE_STUB(spdk_vhost_blk_controller_construct, int, (void), 0);
DEFINE_STUB(rte_vhost_set_vhost_vring_last_idx, int,
(int vid, uint16_t vring_idx, uint16_t last_avail_idx, uint16_t last_used_idx), 0);
vhost: use trylock inside async events body This makes the async event body non-blocking and also fixes potential deadlock scenario: * call_external_event() enqueues vhost_event * destroy_device() locks g_spdk_vhost_mutex * destroy_device() enqueues it's vhost_event * reactor dequeues events * cb from call_external_event is dequeued first * g_spdk_vhost_mutex is locked (deadlock) * destroy_device() times out, abort() Change-Id: If8f51ada3ee5c47ba126f74187a40a285c001c77 Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/380634 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-28 15:43:02 +00:00
DEFINE_STUB(spdk_env_get_current_core, uint32_t, (void), 0);
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
static int
test_setup(void)
{
return 0;
}
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
static struct spdk_vhost_dev *
alloc_vdev(void)
{
struct spdk_vhost_dev *vdev = NULL;
int rc;
/* spdk_vhost_dev must be allocated on a cache line boundary. */
rc = posix_memalign((void **)&vdev, 64, sizeof(*vdev));
CU_ASSERT(rc == 0);
SPDK_CU_ASSERT_FATAL(vdev != NULL);
ut/vhost: add UT coverage for vhost.c Change-Id: Ie62f7684d64736fa393aaaddfc4a3232c6423c62 Signed-off-by: Pawel Niedzwiecki <pawelx.niedzwiecki@intel.com> Reviewed-on: https://review.gerrithub.io/375077 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-08-22 11:43:13 +00:00
memset(vdev, 0, sizeof(*vdev));
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
vdev->mem = calloc(1, sizeof(*vdev->mem) + 2 * sizeof(struct rte_vhost_mem_region));
SPDK_CU_ASSERT_FATAL(vdev->mem != NULL);
vdev->mem->nregions = 2;
vdev->mem->regions[0].guest_phys_addr = 0;
vdev->mem->regions[0].size = 0x400000; /* 4 MB */
vdev->mem->regions[0].host_user_addr = 0x1000000;
vdev->mem->regions[1].guest_phys_addr = 0x400000;
vdev->mem->regions[1].size = 0x400000; /* 4 MB */
vdev->mem->regions[1].host_user_addr = 0x2000000;
ut/vhost: add UT coverage for vhost.c Change-Id: Ie62f7684d64736fa393aaaddfc4a3232c6423c62 Signed-off-by: Pawel Niedzwiecki <pawelx.niedzwiecki@intel.com> Reviewed-on: https://review.gerrithub.io/375077 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-08-22 11:43:13 +00:00
vdev->vid = 0x10;
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
return vdev;
}
static void
free_vdev(struct spdk_vhost_dev *vdev)
{
ut/vhost: add UT coverage for vhost.c Change-Id: Ie62f7684d64736fa393aaaddfc4a3232c6423c62 Signed-off-by: Pawel Niedzwiecki <pawelx.niedzwiecki@intel.com> Reviewed-on: https://review.gerrithub.io/375077 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-08-22 11:43:13 +00:00
free(vdev->name);
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
free(vdev->mem);
free(vdev);
}
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
static void
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
desc_to_iov_test(void)
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
{
vhost: split iovs which span hugepage boundaries A virtio descriptor may specify a buffer that spans a huge page boundary or even a vhost memory region. So modify spdk_vhost_vring_desc_to_iov() to take this into account. While here, also change spdk_vhost_vring_desc_to_iov to return int instead of bool. int return with -1 is most standard to indicate failure. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I71faefce0367dc9e44d70ea4429a28dd64f04c10 Reviewed-on: https://review.gerrithub.io/371756 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Piotr Pelpliński <piotr.pelplinski@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
2017-07-28 15:36:53 +00:00
struct spdk_vhost_dev *vdev;
struct iovec iov[SPDK_VHOST_IOVS_MAX];
uint16_t iov_index;
struct vring_desc desc;
int rc;
vdev = alloc_vdev();
/* Test simple case where iov falls fully within a 2MB page. */
desc.addr = 0x110000;
desc.len = 0x1000;
iov_index = 0;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc == 0);
CU_ASSERT(iov_index == 1);
CU_ASSERT(iov[0].iov_base == (void *)0x1110000);
CU_ASSERT(iov[0].iov_len == 0x1000);
/*
* Always memset the iov to ensure each test validates data written by its call
* to the function under test.
*/
memset(iov, 0, sizeof(iov));
/* Same test, but ensure it respects the non-zero starting iov_index. */
iov_index = SPDK_VHOST_IOVS_MAX - 1;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc == 0);
CU_ASSERT(iov_index == SPDK_VHOST_IOVS_MAX);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 1].iov_base == (void *)0x1110000);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 1].iov_len == 0x1000);
memset(iov, 0, sizeof(iov));
/* Test for failure if iov_index already equals SPDK_VHOST_IOVS_MAX. */
iov_index = SPDK_VHOST_IOVS_MAX;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc != 0);
memset(iov, 0, sizeof(iov));
/* Test case where iov spans a 2MB boundary, but does not span a vhost memory region. */
desc.addr = 0x1F0000;
desc.len = 0x20000;
iov_index = 0;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc == 0);
CU_ASSERT(iov_index == 2);
CU_ASSERT(iov[0].iov_base == (void *)0x11F0000);
CU_ASSERT(iov[0].iov_len == 0x10000);
CU_ASSERT(iov[1].iov_base == (void *)0x1200000);
CU_ASSERT(iov[1].iov_len == 0x10000);
memset(iov, 0, sizeof(iov));
/* Same test, but ensure it respects the non-zero starting iov_index. */
iov_index = SPDK_VHOST_IOVS_MAX - 2;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc == 0);
CU_ASSERT(iov_index == SPDK_VHOST_IOVS_MAX);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 2].iov_base == (void *)0x11F0000);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 2].iov_len == 0x10000);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 1].iov_base == (void *)0x1200000);
CU_ASSERT(iov[SPDK_VHOST_IOVS_MAX - 1].iov_len == 0x10000);
memset(iov, 0, sizeof(iov));
/*
* This test should fail. The first part of the descriptor will fit in the last
* iov, but the part after the 2MB boundary would overflow.
*/
iov_index = SPDK_VHOST_IOVS_MAX - 1;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc != 0);
memset(iov, 0, sizeof(iov));
/* Test case where iov spans a vhost memory region. */
desc.addr = 0x3F0000;
desc.len = 0x20000;
iov_index = 0;
rc = spdk_vhost_vring_desc_to_iov(vdev, iov, &iov_index, &desc);
CU_ASSERT(rc == 0);
CU_ASSERT(iov_index == 2);
CU_ASSERT(iov[0].iov_base == (void *)0x13F0000);
CU_ASSERT(iov[0].iov_len == 0x10000);
CU_ASSERT(iov[1].iov_base == (void *)0x2000000);
CU_ASSERT(iov[1].iov_len == 0x10000);
memset(iov, 0, sizeof(iov));
free_vdev(vdev);
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
CU_ASSERT(true);
}
ut/vhost: add UT coverage for vhost.c Change-Id: Ie62f7684d64736fa393aaaddfc4a3232c6423c62 Signed-off-by: Pawel Niedzwiecki <pawelx.niedzwiecki@intel.com> Reviewed-on: https://review.gerrithub.io/375077 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-08-22 11:43:13 +00:00
static void
create_controller_test(void)
{
struct spdk_vhost_dev *vdev;
int ret;
unsigned ctrlr_num;
char long_name[PATH_MAX];
struct spdk_vhost_dev_backend backend;
MOCK_SET(spdk_app_get_core_mask, uint64_t, 1);
/* Create device with no name */
vdev = alloc_vdev();
ret = spdk_vhost_dev_construct(vdev, NULL, "0x1", SPDK_VHOST_DEV_T_BLK, &backend);
CU_ASSERT(ret != 0);
/* Create device with incorrect cpumask */
ret = spdk_vhost_dev_construct(vdev, "vdev_name_0", "0x2", SPDK_VHOST_DEV_T_BLK, &backend);
CU_ASSERT(ret != 0);
/* Create device with too long name and path */
memset(long_name, 'x', sizeof(long_name));
long_name[PATH_MAX - 1] = 0;
snprintf(dev_dirname, sizeof(dev_dirname), "some_path/");
ret = spdk_vhost_dev_construct(vdev, long_name, "0x1", SPDK_VHOST_DEV_T_BLK, &backend);
CU_ASSERT(ret != 0);
dev_dirname[0] = 0;
/* Create device when device name is already taken */
vdev->name = strdup("vdev_name_0");
g_spdk_vhost_devices[0] = vdev;
ret = spdk_vhost_dev_construct(vdev, "vdev_name_0", "0x1", SPDK_VHOST_DEV_T_BLK, &backend);
CU_ASSERT(ret != 0);
/* Create device when max number of devices is reached */
for (ctrlr_num = 0; ctrlr_num < MAX_VHOST_DEVICES; ctrlr_num ++) {
g_spdk_vhost_devices[ctrlr_num] = vdev;
}
ret = spdk_vhost_dev_construct(vdev, "vdev_name_1", "0x1", SPDK_VHOST_DEV_T_BLK, &backend);
CU_ASSERT(ret != 0);
free_vdev(vdev);
for (ctrlr_num = 0; ctrlr_num < MAX_VHOST_DEVICES; ctrlr_num++) {
g_spdk_vhost_devices[ctrlr_num] = NULL;
}
}
static void
dev_find_by_vid_test(void)
{
struct spdk_vhost_dev *vdev;
g_spdk_vhost_devices[0] = alloc_vdev();
vdev = spdk_vhost_dev_find_by_vid(0x10);
CU_ASSERT(vdev != NULL);
/* Search for a device with incorrect vid */
vdev = spdk_vhost_dev_find_by_vid(0xFF);
CU_ASSERT(vdev == NULL);
free_vdev(g_spdk_vhost_devices[0]);
g_spdk_vhost_devices[0] = NULL;
}
static void
remove_controller_test(void)
{
struct spdk_vhost_dev *vdev;
char long_name[PATH_MAX];
int ret;
vdev = alloc_vdev();
vdev->lcore = 0;
vdev->name = strdup("vdev_name_0");
/* Remove device when controller is in use */
ret = spdk_vhost_dev_remove(vdev);
CU_ASSERT(ret != 0);
if (ret == 0) {
vdev->name = strdup("vdev_name_0");
}
/* Remove nonexistent device */
vdev->lcore = -1;
ret = spdk_vhost_dev_remove(vdev);
CU_ASSERT(ret != 0);
if (ret != 0) {
free(vdev->name);
}
/* Remove device with too long name and path */
memset(long_name, 'x', sizeof(long_name));
long_name[PATH_MAX - 1] = 0;
snprintf(dev_dirname, sizeof(dev_dirname), "some_path/");
vdev->name = strdup(long_name);
g_spdk_vhost_devices[0] = vdev;
ret = spdk_vhost_dev_remove(vdev);
CU_ASSERT(ret != 0);
if (ret == 0) {
vdev->name = NULL;
}
free_vdev(vdev);
g_spdk_vhost_devices[0] = NULL;
dev_dirname[0] = 0;
}
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
int
main(int argc, char **argv)
{
CU_pSuite suite = NULL;
unsigned int num_failures;
if (CU_initialize_registry() != CUE_SUCCESS) {
return CU_get_error();
}
suite = CU_add_suite("vhost_suite", test_setup, NULL);
if (suite == NULL) {
CU_cleanup_registry();
return CU_get_error();
}
if (
ut/vhost: add UT coverage for vhost.c Change-Id: Ie62f7684d64736fa393aaaddfc4a3232c6423c62 Signed-off-by: Pawel Niedzwiecki <pawelx.niedzwiecki@intel.com> Reviewed-on: https://review.gerrithub.io/375077 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-08-22 11:43:13 +00:00
CU_add_test(suite, "desc_to_iov", desc_to_iov_test) == NULL ||
CU_add_test(suite, "create_controller", create_controller_test) == NULL ||
CU_add_test(suite, "dev_find_by_vid", dev_find_by_vid_test) == NULL ||
CU_add_test(suite, "remove_controller", remove_controller_test) == NULL
vhost: add unit test framework While here, add a new DEFINE_STUB_V for void stubs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6b0b27616ddc2525cdd425f65edf8a0bd89ba564 Reviewed-on: https://review.gerrithub.io/371735 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-07-28 16:24:52 +00:00
) {
CU_cleanup_registry();
return CU_get_error();
}
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
return num_failures;
}
Reference in New Issue Copy Permalink