2018-09-17 23:18:53 +00:00
|
|
|
/*-
|
|
|
|
* BSD LICENSE
|
|
|
|
*
|
2020-04-09 04:52:39 +00:00
|
|
|
* Copyright (c) Intel Corporation. All rights reserved.
|
|
|
|
* Copyright (c) 2020 Mellanox Technologies LTD. All rights reserved.
|
2018-09-17 23:18:53 +00:00
|
|
|
*
|
|
|
|
* Redistribution and use in source and binary forms, with or without
|
|
|
|
* modification, are permitted provided that the following conditions
|
|
|
|
* are met:
|
|
|
|
*
|
|
|
|
* * Redistributions of source code must retain the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer.
|
|
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
|
|
* notice, this list of conditions and the following disclaimer in
|
|
|
|
* the documentation and/or other materials provided with the
|
|
|
|
* distribution.
|
|
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
|
|
* contributors may be used to endorse or promote products derived
|
|
|
|
* from this software without specific prior written permission.
|
|
|
|
*
|
|
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef SPDK_THREAD_INTERNAL_H_
|
|
|
|
#define SPDK_THREAD_INTERNAL_H_
|
|
|
|
|
|
|
|
#include "spdk/stdinc.h"
|
2020-02-20 08:00:06 +00:00
|
|
|
#include "spdk/thread.h"
|
2018-09-17 23:18:53 +00:00
|
|
|
|
2020-02-11 01:16:35 +00:00
|
|
|
#define SPDK_MAX_POLLER_NAME_LEN 256
|
2020-02-20 08:00:06 +00:00
|
|
|
#define SPDK_MAX_THREAD_NAME_LEN 256
|
|
|
|
|
2020-02-21 00:20:45 +00:00
|
|
|
enum spdk_poller_state {
|
|
|
|
/* The poller is registered with a thread but not currently executing its fn. */
|
|
|
|
SPDK_POLLER_STATE_WAITING,
|
|
|
|
|
|
|
|
/* The poller is currently running its fn. */
|
|
|
|
SPDK_POLLER_STATE_RUNNING,
|
|
|
|
|
|
|
|
/* The poller was unregistered during the execution of its fn. */
|
|
|
|
SPDK_POLLER_STATE_UNREGISTERED,
|
|
|
|
|
|
|
|
/* The poller is in the process of being paused. It will be paused
|
|
|
|
* during the next time it's supposed to be executed.
|
|
|
|
*/
|
|
|
|
SPDK_POLLER_STATE_PAUSING,
|
|
|
|
|
|
|
|
/* The poller is registered but currently paused. It's on the
|
|
|
|
* paused_pollers list.
|
|
|
|
*/
|
|
|
|
SPDK_POLLER_STATE_PAUSED,
|
|
|
|
};
|
|
|
|
|
|
|
|
struct spdk_poller {
|
|
|
|
TAILQ_ENTRY(spdk_poller) tailq;
|
|
|
|
|
|
|
|
/* Current state of the poller; should only be accessed from the poller's thread. */
|
|
|
|
enum spdk_poller_state state;
|
|
|
|
|
|
|
|
uint64_t period_ticks;
|
|
|
|
uint64_t next_run_tick;
|
2020-03-10 08:47:15 +00:00
|
|
|
uint64_t run_count;
|
2020-04-07 10:42:28 +00:00
|
|
|
uint64_t busy_count;
|
2020-02-21 00:20:45 +00:00
|
|
|
spdk_poller_fn fn;
|
|
|
|
void *arg;
|
|
|
|
struct spdk_thread *thread;
|
2020-09-16 20:03:56 +00:00
|
|
|
int timerfd;
|
2020-12-30 11:48:29 +00:00
|
|
|
spdk_poller_set_interrupt_mode_cb set_intr_cb_fn;
|
|
|
|
void *set_intr_cb_arg;
|
2020-02-11 01:16:35 +00:00
|
|
|
|
|
|
|
char name[SPDK_MAX_POLLER_NAME_LEN + 1];
|
2020-02-21 00:20:45 +00:00
|
|
|
};
|
|
|
|
|
2020-04-04 03:16:27 +00:00
|
|
|
enum spdk_thread_state {
|
|
|
|
/* The thread is pocessing poller and message by spdk_thread_poll(). */
|
|
|
|
SPDK_THREAD_STATE_RUNNING,
|
|
|
|
|
|
|
|
/* The thread is in the process of termination. It reaps unregistering
|
|
|
|
* poller are releasing I/O channel.
|
|
|
|
*/
|
|
|
|
SPDK_THREAD_STATE_EXITING,
|
|
|
|
|
|
|
|
/* The thread is exited. It is ready to call spdk_thread_destroy(). */
|
|
|
|
SPDK_THREAD_STATE_EXITED,
|
|
|
|
};
|
|
|
|
|
2020-02-20 08:00:06 +00:00
|
|
|
struct spdk_thread {
|
|
|
|
uint64_t tsc_last;
|
|
|
|
struct spdk_thread_stats stats;
|
|
|
|
/*
|
|
|
|
* Contains pollers actively running on this thread. Pollers
|
|
|
|
* are run round-robin. The thread takes one poller from the head
|
|
|
|
* of the ring, executes it, then puts it back at the tail of
|
|
|
|
* the ring.
|
|
|
|
*/
|
|
|
|
TAILQ_HEAD(active_pollers_head, spdk_poller) active_pollers;
|
|
|
|
/**
|
|
|
|
* Contains pollers running on this thread with a periodic timer.
|
|
|
|
*/
|
|
|
|
TAILQ_HEAD(timed_pollers_head, spdk_poller) timed_pollers;
|
|
|
|
/*
|
|
|
|
* Contains paused pollers. Pollers on this queue are waiting until
|
|
|
|
* they are resumed (in which case they're put onto the active/timer
|
|
|
|
* queues) or unregistered.
|
|
|
|
*/
|
|
|
|
TAILQ_HEAD(paused_pollers_head, spdk_poller) paused_pollers;
|
|
|
|
struct spdk_ring *messages;
|
2020-09-16 20:03:56 +00:00
|
|
|
int msg_fd;
|
2020-02-20 08:00:06 +00:00
|
|
|
SLIST_HEAD(, spdk_msg) msg_cache;
|
|
|
|
size_t msg_cache_count;
|
|
|
|
spdk_msg_fn critical_msg;
|
2020-04-09 04:52:39 +00:00
|
|
|
uint64_t id;
|
|
|
|
enum spdk_thread_state state;
|
lib/thread: Defer exiting thread if thread is unregistering io_device
Current SPDK thread library has a issue which occurs if there is
a race between exiting thread and unregistering io_device.
For example, there are two threads. Thread 1 registers a device
and thread 2 gets a channel of the device. Then if thread 1 starts
exiting and unregisters the device, and then thread 2 puts the channel,
thread 2 sends a message to thread 1 to complete releasing the device,
thread 1 already moved exited. Hence thread 2 failed to send the
message.
This patch fixes the race issue. The code is verified by adding
a unit test case.
In detail, add a count, unregistering_dev, to struct spdk_thread,
increment it if a callback is specified to spdk_io_device_unregister(),
and then decrement it in _finish_unregister(), and thread_exit()
checks if it is zero.
The contents of struct spdk_thread is changed but it is not public
data structure, and hence suppress it for ABI testing.
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Change-Id: Idf5faa55335c3ea89f47ccce32687a6be2e26c68
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5796
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: <dongx.yi@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2021-01-05 23:56:15 +00:00
|
|
|
int pending_unregister_count;
|
2020-04-09 04:52:39 +00:00
|
|
|
|
|
|
|
TAILQ_HEAD(, spdk_io_channel) io_channels;
|
|
|
|
TAILQ_ENTRY(spdk_thread) tailq;
|
|
|
|
|
|
|
|
char name[SPDK_MAX_THREAD_NAME_LEN + 1];
|
|
|
|
struct spdk_cpuset cpumask;
|
2020-04-05 14:00:53 +00:00
|
|
|
uint64_t exit_timeout_tsc;
|
|
|
|
|
2021-01-11 10:17:30 +00:00
|
|
|
/* Indicates whether this spdk_thread currently runs in interrupt. */
|
|
|
|
bool in_interrupt;
|
2020-09-16 20:03:56 +00:00
|
|
|
struct spdk_fd_group *fgrp;
|
|
|
|
|
2020-02-20 08:00:06 +00:00
|
|
|
/* User context allocated at the end */
|
|
|
|
uint8_t ctx[0];
|
|
|
|
};
|
2018-09-17 23:18:53 +00:00
|
|
|
|
2020-02-06 07:26:33 +00:00
|
|
|
const char *spdk_poller_state_str(enum spdk_poller_state state);
|
|
|
|
|
2020-03-05 22:24:06 +00:00
|
|
|
const char *spdk_io_device_get_name(struct io_device *dev);
|
|
|
|
|
2018-09-17 23:18:53 +00:00
|
|
|
#endif /* SPDK_THREAD_INTERNAL_H_ */
|