ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
b72893a6f2
Spdk/lib/iscsi/portal_grp.h

89 lines
3.5 KiB
C
Raw Normal View History

iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/*-
* BSD LICENSE
*
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#ifndef SPDK_PORTAL_GRP_H
#define SPDK_PORTAL_GRP_H
iscsi: Remove gropu_state from IG and PG By supporting the management based on linked list for PG and IG the group state of PG and IG are no longer necessary. Change-Id: I249424cacd2d27dda4e4cb2182442d0d1e9bfb8e Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/388863 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 07:02:31 +00:00
#include "spdk/conf.h"
iscsi: Move macros to define max port name from portal_grp.h to iscsi.h This is a preparation to the next patch which will change portal_host and portal_port from malloc to fixed size. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I0f95d969edfd88efde41a43eaf0426fcd4b98987 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464135 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-08-08 05:57:43 +00:00
#include "spdk/cpuset.h"
#include "iscsi/iscsi.h"
iscsi: Use not malloc'ed but fixed size string for portal IP address Using malloc'ed string for string in iSCSI target has caused scan-build error. Define maximum IP address of portal to be 256 and use fixed size string whose size is 257 for spdk_iscsi_portal_grp::host. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Iceeae94e250ea426f72ff72355a213606308da51 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459708 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-06-28 01:36:31 +00:00
iscsi: Add JSON config/info dump for portal group. Support JSON config/info dump for portal group. These are added to portal_grp.c. Text config dump is moved to portal_grp.c. Add accesses to g_spdk_iscsi.pg_head are consolidated into portal_grp.c to extract pg_head from g_spdk_iscsi. Change-Id: I8c551b067c68a785eb0c7d83d695bde5f7219c2b Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/407850 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-05-09 22:56:04 +00:00
struct spdk_json_write_ctx;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
struct spdk_iscsi_portal {
struct spdk_iscsi_portal_grp *group;
iscsi: Use not malloc'ed but fixed size string for portal IP address Using malloc'ed string for string in iSCSI target has caused scan-build error. Define maximum IP address of portal to be 256 and use fixed size string whose size is 257 for spdk_iscsi_portal_grp::host. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Iceeae94e250ea426f72ff72355a213606308da51 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459708 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-06-28 01:36:31 +00:00
char host[MAX_PORTAL_ADDR + 1];
iscsi: Use not malloc'ed but fixed size string for portal porta number Using malloc'ed string for string in iSCSI target has caused scan-build error. Define maximum port number of portal to be 32 and use fixed size string whose size is 33 for spdk_iscsi_portal_grp::port. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Ie1fcdbd45ce000a9c1c53761195697555b8d030a Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459709 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-06-28 01:47:10 +00:00
char port[MAX_PORTAL_PORT + 1];
net, iscsi: add struct spdk_sock abstraction This provides an abstraction layer around TCP sockets. Previously we just used fd integers, but we don't want to be tied to integers for alternative userspace TCP stacks. Future patches will do more work to enable multiple implementations of this abstraction. For now, just get the abstraction in place for POSIX sockets and make all of the iSCSI changes associated with it. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I9a825e9e02eb6927c8702d205665c626f57b3771 Reviewed-on: https://review.gerrithub.io/398861 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com>
2018-02-07 21:46:22 +00:00
struct spdk_sock *sock;
iscsi: login poller per portal and portal cache A few foundational change to support safe removal of portal. - global login poller -> login poller per portal - Caching portal data for active connection Change-Id: I62f4d90c9ac11a433ad47421b2b0c69bfc3c70b7 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379930 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-30 04:01:07 +00:00
struct spdk_poller *acceptor_poller;
iscsi: Assign connections to poll groups instead of lcores. This patch binds poll groups to SPDK thread through IO channel and assigns connections to poll groups instead of cores. iSCSI subsystem registers iSCSI global object as an IO device, and create poll groups as context of IO channels of the IO device. Each portal get and hold portal group on which the corresponding acceptor is running. When a connection is constructed, iSCSI subsystem assigns a poll group to the connection by getting it from the corresponding portal. When a connection enters full-feature phase, iSCSI subsystem schedules the connection to a poll group by round-robin. Then, each connection can know its running SPDK thread directly and can use SPDK message passing infrastructure instead of SPDK event framework. By this change, iSCSI connections are binded to SPDK thread, and not binded to processor core anymore. Some other changes in this patch are - core ID is removed from the output of get_iscsi_connections RPC. The upcoming patches will change the RPC to use spdk_for_each_channel and can access SPDK thread safely, and add SPDK thread ID instead. - utilize UT multithread framework added by the last patch to test iSCSI poll groups by UT. Change-Id: Iec73c778aa413bcabdb63141cc41d4160911ea0e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463359 Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-07-30 03:00:15 +00:00
struct spdk_iscsi_poll_group *acceptor_pg;
iscsi: check duplication of portal by portal list Check duplication of registration of portals by using a global portal list Change-Id: I608fc9bd4473c11e69686e6474892f3f4272cd53 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379929 Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-30 02:23:27 +00:00
TAILQ_ENTRY(spdk_iscsi_portal) per_pg_tailq;
TAILQ_ENTRY(spdk_iscsi_portal) g_tailq;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
};
struct spdk_iscsi_portal_grp {
lib/iscsi: Portal group holds CHAP params and passes them to connections This is another preparation to support per portal group CHAP authentication for discovery session. Add CHAP params into struct spdk_iscsi_portal_grp, and initialize them by global parameters at spdk_iscsi_portal_grp_create(). Copy CHAP params from portal group to connection at spdk_iscsi_conn_construct(). Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I1ecb812266ac3d090f8e6db21d1d6a090f1811d9 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469368 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-09-25 04:53:34 +00:00
int ref;
int tag;
bool disable_chap;
bool require_chap;
bool mutual_chap;
int32_t chap_group;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
TAILQ_ENTRY(spdk_iscsi_portal_grp) tailq;
TAILQ_HEAD(, spdk_iscsi_portal) head;
};
/* SPDK iSCSI Portal Group management API */
iscsi: Remove cpumask from portals Connections will soon be assigned to poll groups, which will be dynamically moved between CPU cores based on load. It no longer makes sense to restrict certain portal groups to specific cpu cores in this model. Change-Id: Iee983d75febc9797aa60021c5bc0680335e895cd Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463358 Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-07-10 14:18:01 +00:00
struct spdk_iscsi_portal *spdk_iscsi_portal_create(const char *host, const char *port);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
void spdk_iscsi_portal_destroy(struct spdk_iscsi_portal *p);
iscsi: Unify the ordering of PG create_op between conf-file and JSON-RPC Orderings of portal group create operation are diferrent between config file and JSON-RPC. Unification is necessary for correct concurrency control and the global accept poller like NVMf-tgt. Hence unify the ordering of operations in this patch. Common ordering of portal group create operation between configuration file and JSON-RPC after this patch is the following: - create a portal group - create portals - add the portals to the portal group - open the portals of the portal group - add the portal group to the global portal group list After this patch, the gap between listening socket and accepting socket will be increased a little when portals groups are creted by config file. However this will cause no issue because of the TCP backlog and resend mechanism. Besides, necessary concurrency control is added and minor refactoring is done. About portal group delete operation, orderings of application shutdown and JSON-RPC are already unified. Change-Id: I1db7ef4400388127134d7734c68e138a4573b734 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/396848 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-01-29 04:36:03 +00:00
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_create(int tag);
void spdk_iscsi_portal_grp_add_portal(struct spdk_iscsi_portal_grp *pg,
struct spdk_iscsi_portal *p);
void spdk_iscsi_portal_grp_destroy(struct spdk_iscsi_portal_grp *pg);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
void spdk_iscsi_portal_grp_release(struct spdk_iscsi_portal_grp *pg);
iscsi: Change function names of iSCSI subsystem configuration Portal, portal group, initiator group, and target node don't use fixed size array anymore. To use the same naming rule in iSCSI subsystem and in SPDK is helpful to understand and maintain. Current naming rule is not bad but to use unified and compact name is prioritized at this time. This patch changes function names as follows: - spdk_iscsi_init_tgt_nodes() -> spdk_iscsi_parse_tgt_nodes() - spdk_cf_add_iscsi_tgt_node() -> spdk_iscsi_parse_tgt_node() - spdk_iscsi_portal_grp_array_create() -> spdk_iscsi_parse_portal_grps() - spdk_iscsi_portal_grp_create_from_configfile() -> spdk_iscsi_parse_portal_grp() - spdk_iscsi_portal_create_from_configline() -> spdk_iscsi_parse_portal() - spdk_iscsi_portal_grp_array_destroy() -> spdk_iscsi_portal_grps_destroy() - spdk_iscsi_init_grp_array_create() -> spdk_iscsi_parse_init_grps() - spdk_iscsi_init_grp_create_from_configfile() -> spdk_iscsi_parse_init_grp() - spdk_iscsi_init_grp_array_destroy() -> spdk_iscsi_init_grps_destroy() For example "parse" is already used to explain the operation in portal_grp.c. Hence using "parse" is familiar and not strange in iSCSI. Change-Id: Ieff952069d39bd96b7afa1586bfff927968accc2 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/403149 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-03-08 23:25:34 +00:00
int spdk_iscsi_parse_portal_grps(void);
void spdk_iscsi_portal_grps_destroy(void);
iscsi: Unify the ordering of PG create_op between conf-file and JSON-RPC Orderings of portal group create operation are diferrent between config file and JSON-RPC. Unification is necessary for correct concurrency control and the global accept poller like NVMf-tgt. Hence unify the ordering of operations in this patch. Common ordering of portal group create operation between configuration file and JSON-RPC after this patch is the following: - create a portal group - create portals - add the portals to the portal group - open the portals of the portal group - add the portal group to the global portal group list After this patch, the gap between listening socket and accepting socket will be increased a little when portals groups are creted by config file. However this will cause no issue because of the TCP backlog and resend mechanism. Besides, necessary concurrency control is added and minor refactoring is done. About portal group delete operation, orderings of application shutdown and JSON-RPC are already unified. Change-Id: I1db7ef4400388127134d7734c68e138a4573b734 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/396848 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-01-29 04:36:03 +00:00
int spdk_iscsi_portal_grp_register(struct spdk_iscsi_portal_grp *pg);
iscsi: Consolidate checking uniqueness of PG into register/unregister Checking uniqueness of portal group is done without mutex and before register/unregister. This is not thread-safe. Hence this patch is added to ensure PG uniqueness. A little related refactoring is also done. Change-Id: Iaa3b5e380f2be5cfdaa2d69f9f2763c98954b0c3 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/396847 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-01-29 07:51:51 +00:00
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_unregister(int tag);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
struct spdk_iscsi_portal_grp *spdk_iscsi_portal_grp_find_by_tag(int tag);
iscsi: Unify the ordering of PG create_op between conf-file and JSON-RPC Orderings of portal group create operation are diferrent between config file and JSON-RPC. Unification is necessary for correct concurrency control and the global accept poller like NVMf-tgt. Hence unify the ordering of operations in this patch. Common ordering of portal group create operation between configuration file and JSON-RPC after this patch is the following: - create a portal group - create portals - add the portals to the portal group - open the portals of the portal group - add the portal group to the global portal group list After this patch, the gap between listening socket and accepting socket will be increased a little when portals groups are creted by config file. However this will cause no issue because of the TCP backlog and resend mechanism. Besides, necessary concurrency control is added and minor refactoring is done. About portal group delete operation, orderings of application shutdown and JSON-RPC are already unified. Change-Id: I1db7ef4400388127134d7734c68e138a4573b734 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/396848 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-01-29 04:36:03 +00:00
int spdk_iscsi_portal_grp_open(struct spdk_iscsi_portal_grp *pg);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
iscsi: turn the <open/close portal> code into functions Group the code fragments of open/close portal procedure and create spdk_iscsi_portal_open/close() function. Change-Id: Id6e291f3f6e5a926f3ea0d01741a200fa64db81b Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379934 Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-28 05:37:49 +00:00
void spdk_iscsi_portal_grp_close_all(void);
iscsi: Add JSON config/info dump for portal group. Support JSON config/info dump for portal group. These are added to portal_grp.c. Text config dump is moved to portal_grp.c. Add accesses to g_spdk_iscsi.pg_head are consolidated into portal_grp.c to extract pg_head from g_spdk_iscsi. Change-Id: I8c551b067c68a785eb0c7d83d695bde5f7219c2b Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/407850 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-05-09 22:56:04 +00:00
void spdk_iscsi_portal_grps_config_text(FILE *fp);
void spdk_iscsi_portal_grps_info_json(struct spdk_json_write_ctx *w);
void spdk_iscsi_portal_grps_config_json(struct spdk_json_write_ctx *w);
iscsi: Move acceptor into portal_grp It's 3 functions that are only called from this compilation unit. Change-Id: I033ced4c19ee2a33b9537c347532ea5706d02d6a Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/454493 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-05-13 22:12:32 +00:00
iscsi: Use not C++ style comments // but C-style comments /* */ Change-Id: Ia81209e1dd7c0892bb14ae8b2a5850130fcbf199 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/431078 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-10-29 02:20:47 +00:00
#endif /* SPDK_PORTAL_GRP_H */
Reference in New Issue Copy Permalink