ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
a1fb441c84
Spdk/test/unit/lib/iscsi/init_grp.c/init_grp_ut.c

588 lines
13 KiB
C
Raw Normal View History

Replace most BSD 3-clause license text with SPDX identifier. Many open source projects have moved to using SPDX identifiers to specify license information, reducing the amount of boilerplate code in every source file. This patch replaces the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause identifier. Almost all of these files share the exact same license text, and this patch only modifies the files that contain the most common license text. There can be slight variations because the third clause contains company names - most say "Intel Corporation", but there are instances for Nvidia, Samsung, Eideticom and even "the copyright holder". Used a bash script to automate replacement of the license text with SPDX identifier which is checked into scripts/spdx.sh. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: <qun.wan@intel.com>
2022-06-03 19:15:11 +00:00
/* SPDX-License-Identifier: BSD-3-Clause
update Intel copyright notices per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices. git log --follow -C90% --format=%ad --date default <file> | tail -1 and then pull just the 4 digit year from the result. Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc). Contribution date used "--follow -C95%" to get the most accurate date. Note that several files in this patch didn't end the license/(c) block with a blank comment line so these were added as the vast majority of files do have this last blank line. Simply there for consistency. Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
2022-11-01 20:26:26 +00:00
* Copyright (C) 2017 Intel Corporation.
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
* All rights reserved.
*/
update Intel copyright notices per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices. git log --follow -C90% --format=%ad --date default <file> | tail -1 and then pull just the 4 digit year from the result. Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc). Contribution date used "--follow -C95%" to get the most accurate date. Note that several files in this patch didn't end the license/(c) block with a blank comment line so these were added as the vast majority of files do have this last blank line. Simply there for consistency. Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
2022-11-01 20:26:26 +00:00
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
#include "spdk/stdinc.h"
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
#include "spdk_cunit.h"
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
#include "CUnit/Basic.h"
#include "iscsi/init_grp.c"
iscsi: Add JSON config/info dump for initiator group. Support JSON config/info dump for initiator group. These are added to init_grp.c. Text config dump is moved to init_grp.c too. Add accesses to g_spdk_iscsi.ig_head are consolidated into init_grp.c to extract ig_head from g_spdk_iscsi. Change-Id: I88131d248ed13e42e4da56aed8ae0edc01a65715 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/407849 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-05-09 22:55:12 +00:00
#include "unit/lib/json_mock.c"
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
log: simplify SPDK_LOG_REGISTER_COMPONENT This patch removes the string from register component. Removed are all instances in libs or hardcoded in apps. Starting with this patch literal passed to register, serves as name for the flag. All instances of SPDK_LOG_* were replaced with just * in lowercase. No actual name change for flags occur in this patch. Affected are SPDK_LOG_REGISTER_COMPONENT() and SPDK_*LOG() macros. Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I002b232fde57ecf9c6777726b181fc0341f1bb17 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4495 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Mellanox Build Bot Reviewed-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Broadcom CI
2020-09-04 11:27:29 +00:00
SPDK_LOG_REGISTER_COMPONENT(iscsi)
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
test/iscsi: initialize mutex for portability For correct behaviour, pthread_mutex must be initialized before use. Add static initialization to a couple of structures containing a mutex. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I7049824bb292135dbebab201083a1858597f94d1 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6124 Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2021-01-27 17:17:14 +00:00
struct spdk_iscsi_globals g_iscsi = {
.mutex = PTHREAD_MUTEX_INITIALIZER
};
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
static int
test_setup(void)
{
lib/iscsi: Rename iSCSI global data from g_spdk_iscsi to g_iscsi The following patch will remove the "spdk_" prefix from iSCSI internal APIs. The iSCSI global data g_spdk_iscsi is also local in SPDK iSCSI library. Hence rename it by g_iscsi for consistency. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: If35e9d58b1388fd725a505ee9be870e414c37ba5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1831 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-13 21:05:20 +00:00
TAILQ_INIT(&g_iscsi.ig_head);
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
return 0;
}
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
static void
create_initiator_group_success_case(void)
{
struct spdk_iscsi_init_grp *ig;
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
find_initiator_group_success_case(void)
{
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
struct spdk_iscsi_init_grp *ig, *tmp;
int rc;
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
rc = iscsi_init_grp_register(ig);
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
CU_ASSERT(rc == 0);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
ig = iscsi_init_grp_find_by_tag(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
tmp = iscsi_init_grp_unregister(1);
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
CU_ASSERT(ig == tmp);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
ig = iscsi_init_grp_find_by_tag(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig == NULL);
}
static void
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
register_initiator_group_twice_case(void)
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
{
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
struct spdk_iscsi_init_grp *ig, *tmp;
int rc;
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
rc = iscsi_init_grp_register(ig);
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
CU_ASSERT(rc == 0);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
rc = iscsi_init_grp_register(ig);
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
CU_ASSERT(rc != 0);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
ig = iscsi_init_grp_find_by_tag(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
tmp = iscsi_init_grp_unregister(1);
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
CU_ASSERT(tmp == ig);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
ig = iscsi_init_grp_find_by_tag(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig == NULL);
}
static void
add_initiator_name_success_case(void)
{
iscsi: Consolidating checking uniqueness of IG into register/unregister Checking uniqueness of initiator group is done without mutex and before register/unregister. This is not thread-safe. This patch is a preparation to dynamic addition of initiator information to existing initiator groups. Change-Id: I44f48c857210522eee70d14bc3735ec73b0c5c6f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/397032 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-05 04:02:25 +00:00
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *name1 = "iqn.2017-10.spdk.io:0001";
char *name2 = "iqn.2017-10.spdk.io:0002";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add two different names to the empty name list */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
/* check if two names are added correctly. */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname != NULL);
/* restore the initial state */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname == NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
add_initiator_name_fail_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *name1 = "iqn.2017-10.spdk.io:0001";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add an name to the full name list */
ig->ninitiators = MAX_INITIATOR;
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc != 0);
ig->ninitiators = 0;
/* add the same name to the name list twice */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc != 0);
/* restore the initial state */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname == NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
delete_all_initiator_names_success_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *name1 = "iqn.2017-10.spdk.io:0001";
char *name2 = "iqn.2017-10.spdk.io:0002";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add two different names to the empty name list */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
/* delete all initiator names */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iscsi_init_grp_delete_all_initiators(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
/* check if two names are deleted correctly. */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, name2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(iname == NULL);
/* restore the initial state */
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
add_netmask_success_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *imask;
char *netmask1 = "192.168.2.0";
char *netmask2 = "192.168.2.1";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add two different netmasks to the empty netmask list */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
/* check if two netmasks are added correctly. */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask != NULL);
/* restore the initial state */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask == NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
add_netmask_fail_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *imask;
char *netmask1 = "192.168.2.0";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add an netmask to the full netmask list */
ig->nnetmasks = MAX_NETMASK;
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc != 0);
ig->nnetmasks = 0;
/* add the same netmask to the netmask list twice */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc != 0);
/* restore the initial state */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask == NULL);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
static void
delete_all_netmasks_success_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *imask;
char *netmask1 = "192.168.2.0";
char *netmask2 = "192.168.2.1";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(ig != NULL);
/* add two different netmasks to the empty netmask list */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(rc == 0);
/* delete all netmasks */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iscsi_init_grp_delete_all_netmasks(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
/* check if two netmasks are deleted correctly. */
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask1);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, netmask2);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
CU_ASSERT(imask == NULL);
/* restore the initial state */
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: manage IG's name and mask by linked list To add initiators to an existing target, manage name and netmask of initiator group by linked list. It is not easy for array to detect duplication and change configuration. Change-Id: Id9e77740e24ac309a33d8de1be37663681160d94 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379932 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-15 00:14:27 +00:00
}
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
static void
initiator_name_overwrite_all_to_any_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *all = "ALL";
char *any = "ANY";
char *all_not = "!ALL";
char *any_not = "!ANY";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, all);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, all);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(iname == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, any);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(iname != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiator(ig, any);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiator(ig, all_not);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, all_not);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(iname == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, any_not);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(iname != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiator(ig, any_not);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
}
static void
netmask_overwrite_all_to_any_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *imask;
char *all = "ALL";
char *any = "ANY";
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmask(ig, all);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, all);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(imask == NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
imask = iscsi_init_grp_find_netmask(ig, any);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(imask != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmask(ig, any);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
CU_ASSERT(rc == 0);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi: Replace "ALL" by "ANY" for access control In the accessibility control of iSCSI target, "ALL" is used to allow ANY IP address-port pair or iSCSI name of initiators. However iSCSI targets cannot know ALL initiators beforehand. Hence "ANY" will be better than "ALL" and will avoid misunderstanding. Comments and iscsi_tgt test code are also changed and UT code is added. Change-Id: Id004d819df6e9ee89f6c1db2e4b4c149be062733 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385168 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 05:51:23 +00:00
}
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
static void
add_delete_initiator_names_case(void)
{
int rc, i;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *names[3] = {"iqn.2018-02.spdk.io:0001", "iqn.2018-02.spdk.io:0002", "iqn.2018-02.spdk.io:0003"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiators(ig, 3, names);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, names[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(iname != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiators(ig, 3, names);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->initiator_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
static void
add_duplicated_initiator_names_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
char *names[3] = {"iqn.2018-02.spdk.io:0001", "iqn.2018-02.spdk.io:0002", "iqn.2018-02.spdk.io:0001"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiators(ig, 3, names);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc != 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->initiator_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
static void
delete_nonexisting_initiator_names_case(void)
{
int rc, i;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_name *iname;
char *names1[3] = {"iqn.2018-02.spdk.io:0001", "iqn.2018-02.spdk.io:0002", "iqn.2018-02.spdk.io:0003"};
char *names2[3] = {"iqn.2018-02.spdk.io:0001", "iqn.2018-02.spdk.io:0002", "iqn.2018-02.spdk.io:0004"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_initiators(ig, 3, names1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, names1[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(iname != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiators(ig, 3, names2);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc != 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
iname = iscsi_init_grp_find_initiator(ig, names1[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(iname != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_initiators(ig, 3, names1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->initiator_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
static void
add_delete_netmasks_case(void)
{
int rc, i;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *netmask;
char *netmasks[3] = {"192.168.2.0", "192.168.2.1", "192.168.2.2"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmasks(ig, 3, netmasks);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
netmask = iscsi_init_grp_find_netmask(ig, netmasks[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(netmask != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmasks(ig, 3, netmasks);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->netmask_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
static void
add_duplicated_netmasks_case(void)
{
int rc;
struct spdk_iscsi_init_grp *ig;
char *netmasks[3] = {"192.168.2.0", "192.168.2.1", "192.168.2.0"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmasks(ig, 3, netmasks);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc != 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->netmask_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
static void
delete_nonexisting_netmasks_case(void)
{
int rc, i;
struct spdk_iscsi_init_grp *ig;
struct spdk_iscsi_initiator_netmask *netmask;
char *netmasks1[3] = {"192.168.2.0", "192.168.2.1", "192.168.2.2"};
char *netmasks2[3] = {"192.168.2.0", "192.168.2.1", "192.168.2.3"};
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
ig = iscsi_init_grp_create(1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
SPDK_CU_ASSERT_FATAL(ig != NULL);
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_add_netmasks(ig, 3, netmasks1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
netmask = iscsi_init_grp_find_netmask(ig, netmasks1[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(netmask != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmasks(ig, 3, netmasks2);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc != 0);
for (i = 0; i < 3; i++) {
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
netmask = iscsi_init_grp_find_netmask(ig, netmasks1[i]);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(netmask != NULL);
}
iscsi: Remove the prefix spdk_ from names of private functions iSCSI library had used the prefix spdk_ for most functions regardless of private or public. Using the prefix spdk_ only for public functions will be helpful to distinguish private and public functions, and will be helpful to investigate issues or do further improvement. Besides in iscsi.c static variable spdk_arc4random_initialized had the prefix spdk_, and change it to g_arc4random_initialized according to the SPDK's good practice. iSCSI library still have some issues but is more stable than before and now will be the good time to adjust the naming rule to other libraries. This patch doesn't change any behavior. Change-Id: Ia0b8585a7ce6662cabc0e6f57b7ccb8a40342297 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449396 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-03-27 21:53:37 +00:00
rc = iscsi_init_grp_delete_netmasks(ig, 3, netmasks1);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
CU_ASSERT(rc == 0);
if (ig != NULL) {
CU_ASSERT(TAILQ_EMPTY(&ig->netmask_head));
}
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in init_grp.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4f06612aa6e619371f28b2df435e0966d30da275 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1887 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-04-15 21:39:41 +00:00
iscsi_init_grp_destroy(ig);
iscsi&rpc: Add new initiator information to an existing initiator group Adding new initiator to an existing initiator group to allow login will be usual. This patch support the following JSON-RPC commands: - add_initiators_to_initiator_group - delete_initiators_from_initiator_group Both initiator's name and netmask are optional but already added name or netmask cannot be added. Test code is added too. Change-Id: Ic101210b9d00c2b36e37ece23fcba8cfe8e44eb8 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/398361 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-06 23:22:00 +00:00
}
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
int
main(int argc, char **argv)
{
CU_pSuite suite = NULL;
unsigned int num_failures;
ut: simplify error handling at initialization This patch changes the way that unittests initialize. The new way is shorter and simpler. It assumes that error during initialization is a fatal error, but in our cases it always is. This patch is a followp up to https://review.spdk.io/gerrit/c/spdk/spdk/+/930 lvol_ut.c is the only test that skipped because it runs same tests multiple times which is not allowed by new method. Change-Id: I0baf7ad09a35d5fca2dc4a03b4453c12c14f38a7 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1238 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-03-11 17:59:24 +00:00
CU_set_error_action(CUEA_ABORT);
CU_initialize_registry();
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
suite = CU_add_suite("init_grp_suite", test_setup, NULL);
ut: make use of CUnit macro to reduce duplications CUnit provides a helper macro CU_ADD_TEST() that simplifies usage of CU_add_test() function. Test name no longer needs to be provided, as it will be inherited from function name. This is a follow up to https://review.spdk.io/gerrit/c/spdk/spdk/+/931 Change-Id: I8078f02e08b14f12328ae022d7090ba13fbd64e4 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1239 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-03-11 19:15:39 +00:00
CU_ADD_TEST(suite, create_initiator_group_success_case);
CU_ADD_TEST(suite, find_initiator_group_success_case);
CU_ADD_TEST(suite, register_initiator_group_twice_case);
CU_ADD_TEST(suite, add_initiator_name_success_case);
CU_ADD_TEST(suite, add_initiator_name_fail_case);
CU_ADD_TEST(suite, delete_all_initiator_names_success_case);
CU_ADD_TEST(suite, add_netmask_success_case);
CU_ADD_TEST(suite, add_netmask_fail_case);
CU_ADD_TEST(suite, delete_all_netmasks_success_case);
CU_ADD_TEST(suite, initiator_name_overwrite_all_to_any_case);
CU_ADD_TEST(suite, netmask_overwrite_all_to_any_case);
CU_ADD_TEST(suite, add_delete_initiator_names_case);
CU_ADD_TEST(suite, add_duplicated_initiator_names_case);
CU_ADD_TEST(suite, delete_nonexisting_initiator_names_case);
CU_ADD_TEST(suite, add_delete_netmasks_case);
CU_ADD_TEST(suite, add_duplicated_netmasks_case);
CU_ADD_TEST(suite, delete_nonexisting_netmasks_case);
iscsi and ut/iscsi: return code to fail of IG creation spdk_iscsi_init_grp_create_from_configfile() returns 0 even if creating an initiator group (IG) is failed due to empty netmask or initiator name. This will be unexpected behavior for end users. Hence change the return code from 0 to -ENVAL for this failure. Besides do the following. Change other error return codes in the function by using errno too. Current IG don't have any UT code in repository. UT code to confirm this fix is also submitted. Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/384408 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-15 00:10:00 +00:00
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
return num_failures;
}
Reference in New Issue Copy Permalink