2022-06-03 19:15:11 +00:00
|
|
|
/* SPDX-License-Identifier: BSD-3-Clause
|
2020-02-11 18:48:05 +00:00
|
|
|
*
|
2022-11-01 20:26:26 +00:00
|
|
|
* Copyright (C) 2020 Intel Corporation.
|
2020-02-11 18:48:05 +00:00
|
|
|
* All rights reserved.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "spdk_cunit.h"
|
|
|
|
|
|
|
|
#include "common/lib/test_env.c"
|
|
|
|
#include "nvme/nvme_cuse.c"
|
|
|
|
|
|
|
|
DEFINE_STUB(nvme_io_msg_send, int, (struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid,
|
|
|
|
spdk_nvme_io_msg_fn fn, void *arg), 0);
|
|
|
|
|
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_alloc_cmb_io_buffer, void *, (struct spdk_nvme_ctrlr *ctrlr,
|
|
|
|
size_t size), NULL);
|
|
|
|
|
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_cmd_admin_raw, int, (struct spdk_nvme_ctrlr *ctrlr,
|
|
|
|
struct spdk_nvme_cmd *cmd, void *buf, uint32_t len,
|
|
|
|
spdk_nvme_cmd_cb cb_fn, void *cb_arg), 0);
|
|
|
|
|
2021-12-27 04:05:53 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_cmd_io_raw_with_md, int, (struct spdk_nvme_ctrlr *ctrlr,
|
|
|
|
struct spdk_nvme_qpair *qpair, struct spdk_nvme_cmd *cmd, void *buf, uint32_t len, void *md_buf,
|
2021-05-05 00:25:31 +00:00
|
|
|
spdk_nvme_cmd_cb cb_fn, void *cb_arg), 0);
|
|
|
|
|
2020-02-11 18:48:05 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_get_num_ns, uint32_t, (struct spdk_nvme_ctrlr *ctrlr), 128);
|
|
|
|
|
|
|
|
static uint32_t g_active_num_ns = 4;
|
|
|
|
static uint32_t g_active_nsid_min = 1;
|
|
|
|
|
|
|
|
bool
|
|
|
|
spdk_nvme_ctrlr_is_active_ns(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid)
|
|
|
|
{
|
|
|
|
return nsid >= g_active_nsid_min && nsid < g_active_num_ns + g_active_nsid_min;
|
|
|
|
}
|
|
|
|
|
2021-08-19 21:01:09 +00:00
|
|
|
uint32_t
|
|
|
|
spdk_nvme_ctrlr_get_first_active_ns(struct spdk_nvme_ctrlr *ctrlr)
|
|
|
|
{
|
|
|
|
return g_active_nsid_min;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint32_t
|
|
|
|
spdk_nvme_ctrlr_get_next_active_ns(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid)
|
|
|
|
{
|
|
|
|
nsid = nsid + 1;
|
|
|
|
|
|
|
|
if (spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
|
|
|
|
return nsid;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-02-11 18:48:05 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_reset, int, (struct spdk_nvme_ctrlr *ctrlr), 0);
|
|
|
|
|
2021-05-27 06:54:37 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_reset_subsystem, int, (struct spdk_nvme_ctrlr *ctrlr), 0);
|
|
|
|
|
2021-12-27 04:05:53 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ns_cmd_read_with_md, int, (struct spdk_nvme_ns *ns,
|
|
|
|
struct spdk_nvme_qpair *qpair,
|
|
|
|
void *payload, void *metadata,
|
2020-02-11 18:48:05 +00:00
|
|
|
uint64_t lba, uint32_t lba_count, spdk_nvme_cmd_cb cb_fn, void *cb_arg,
|
2021-12-27 04:05:53 +00:00
|
|
|
uint32_t io_flags, uint16_t apptag_mask, uint16_t apptag), 0);
|
2020-02-11 18:48:05 +00:00
|
|
|
|
2021-12-27 04:05:53 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ns_cmd_write_with_md, int, (struct spdk_nvme_ns *ns,
|
|
|
|
struct spdk_nvme_qpair *qpair,
|
|
|
|
void *payload, void *metadata,
|
2020-02-11 18:48:05 +00:00
|
|
|
uint64_t lba, uint32_t lba_count, spdk_nvme_cmd_cb cb_fn, void *cb_arg,
|
2021-12-27 04:05:53 +00:00
|
|
|
uint32_t io_flags, uint16_t apptag_mask, uint16_t apptag), 0);
|
2020-02-11 18:48:05 +00:00
|
|
|
|
|
|
|
DEFINE_STUB(spdk_nvme_ns_get_num_sectors, uint64_t, (struct spdk_nvme_ns *ns), 0);
|
|
|
|
|
|
|
|
DEFINE_STUB(spdk_nvme_ns_get_sector_size, uint32_t, (struct spdk_nvme_ns *ns), 0);
|
|
|
|
|
2021-12-27 04:05:53 +00:00
|
|
|
DEFINE_STUB(spdk_nvme_ns_get_md_size, uint32_t, (struct spdk_nvme_ns *ns), 0);
|
|
|
|
|
2020-02-11 18:48:05 +00:00
|
|
|
DEFINE_STUB_V(spdk_unaffinitize_thread, (void));
|
|
|
|
|
|
|
|
DEFINE_STUB(spdk_nvme_ctrlr_get_ns, struct spdk_nvme_ns *, (struct spdk_nvme_ctrlr *ctrlr,
|
|
|
|
uint32_t nsid), NULL);
|
|
|
|
|
2020-10-23 18:01:14 +00:00
|
|
|
DEFINE_STUB(nvme_io_msg_ctrlr_register, int,
|
|
|
|
(struct spdk_nvme_ctrlr *ctrlr, struct nvme_io_msg_producer *io_msg_producer), 0);
|
|
|
|
|
|
|
|
DEFINE_STUB_V(nvme_io_msg_ctrlr_unregister,
|
|
|
|
(struct spdk_nvme_ctrlr *ctrlr, struct nvme_io_msg_producer *io_msg_producer));
|
|
|
|
|
2021-06-01 22:40:00 +00:00
|
|
|
DEFINE_STUB_V(nvme_ctrlr_update_namespaces, (struct spdk_nvme_ctrlr *ctrlr));
|
|
|
|
|
2020-02-11 18:48:05 +00:00
|
|
|
static bool
|
|
|
|
wait_for_file(char *filename, bool exists)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < 1000; i++) {
|
|
|
|
if ((access(filename, F_OK) != -1) ^ (!exists)) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
usleep(100);
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
verify_devices(struct spdk_nvme_ctrlr *ctrlr)
|
|
|
|
{
|
|
|
|
char ctrlr_name[256];
|
|
|
|
size_t ctrlr_name_size;
|
test/cuse: fix ns_dev format truncation
gcc 12 assumes that nsid might take value of UINT32_MAX,
which when represented as a string does not fit in ns_dev.
This is fixed by accomodating the UINT32_MAX string representation
and the 'n' character.
Following error was shown before this patch:
cuse.c: In function ‘verify_devices’:
cuse.c:133:42: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
133 | snprintf(ns_dev, sizeof(ns_dev), "%sn%" PRIu32, ctrlr_dev, nsid);
| ^~~~~~
In file included from /home/tzawadzk/spdk/include/spdk/stdinc.h:23,
from /home/tzawadzk/spdk/test/spdk_cunit.h:9,
from cuse.c:7:
/usr/include/inttypes.h:104:27: note: format string is defined here
104 | # define PRIu32 "u"
| ^
cuse.c:133:9: note: ‘snprintf’ output between 3 and 267 bytes into a destination of size 266
133 | snprintf(ns_dev, sizeof(ns_dev), "%sn%" PRIu32, ctrlr_dev, nsid);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: I14e058edc780d33abdd5eb6ce5ab47ac5d18f10a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13412
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2022-06-22 13:37:16 +00:00
|
|
|
char ctrlr_dev[256];
|
|
|
|
char ns_dev[256 + 1 + 10]; /* sizeof ctrl_dev + 'n' + string size of UINT32_MAX */
|
2020-02-11 18:48:05 +00:00
|
|
|
uint32_t nsid, num_ns;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
ctrlr_name_size = sizeof(ctrlr_name);
|
|
|
|
rv = spdk_nvme_cuse_get_ctrlr_name(ctrlr, ctrlr_name, &ctrlr_name_size);
|
|
|
|
SPDK_CU_ASSERT_FATAL(rv == 0);
|
|
|
|
|
|
|
|
rv = snprintf(ctrlr_dev, sizeof(ctrlr_dev), "/dev/%s", ctrlr_name);
|
|
|
|
CU_ASSERT(rv > 0);
|
|
|
|
CU_ASSERT(wait_for_file(ctrlr_dev, true));
|
|
|
|
|
|
|
|
num_ns = spdk_nvme_ctrlr_get_num_ns(ctrlr);
|
|
|
|
|
|
|
|
for (nsid = 1; nsid <= num_ns; nsid++) {
|
|
|
|
snprintf(ns_dev, sizeof(ns_dev), "%sn%" PRIu32, ctrlr_dev, nsid);
|
|
|
|
if (spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid)) {
|
|
|
|
CU_ASSERT(wait_for_file(ns_dev, true));
|
|
|
|
} else {
|
|
|
|
CU_ASSERT(wait_for_file(ns_dev, false));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Next one should never exist */
|
|
|
|
snprintf(ns_dev, sizeof(ns_dev), "%sn%" PRIu32, ctrlr_dev, nsid);
|
|
|
|
CU_ASSERT(wait_for_file(ns_dev, false));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
test_cuse_update(void)
|
|
|
|
{
|
|
|
|
int rc;
|
|
|
|
struct spdk_nvme_ctrlr ctrlr = {};
|
|
|
|
|
|
|
|
rc = nvme_cuse_start(&ctrlr);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
g_active_num_ns = 4;
|
|
|
|
g_active_nsid_min = 1;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 0;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 4;
|
|
|
|
g_active_nsid_min = spdk_nvme_ctrlr_get_num_ns(&ctrlr) - g_active_num_ns;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 2;
|
|
|
|
g_active_nsid_min = 2;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 10;
|
|
|
|
g_active_nsid_min = 5;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 5;
|
|
|
|
g_active_nsid_min = 3;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
g_active_num_ns = 6;
|
|
|
|
g_active_nsid_min = 1;
|
|
|
|
nvme_cuse_update(&ctrlr);
|
|
|
|
verify_devices(&ctrlr);
|
|
|
|
|
|
|
|
nvme_cuse_stop(&ctrlr);
|
|
|
|
}
|
|
|
|
|
2022-06-22 21:35:04 +00:00
|
|
|
int
|
|
|
|
main(int argc, char **argv)
|
2020-02-11 18:48:05 +00:00
|
|
|
{
|
|
|
|
CU_pSuite suite = NULL;
|
|
|
|
unsigned int num_failures;
|
|
|
|
|
|
|
|
CU_set_error_action(CUEA_ABORT);
|
|
|
|
CU_initialize_registry();
|
|
|
|
suite = CU_add_suite("nvme_cuse", NULL, NULL);
|
|
|
|
CU_ADD_TEST(suite, test_cuse_update);
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
|
|
CU_basic_run_tests();
|
|
|
|
num_failures = CU_get_number_of_failures();
|
|
|
|
CU_cleanup_registry();
|
|
|
|
return num_failures;
|
|
|
|
}
|