ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
713333fdc9
Spdk/lib/iscsi/tgt_node.h

151 lines
5.5 KiB
C
Raw Normal View History

iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/*-
* BSD LICENSE
*
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#ifndef SPDK_ISCSI_TGT_NODE_H_
#define SPDK_ISCSI_TGT_NODE_H_
include: Move the remainder of the code base to stdinc.h Change-Id: I6a142feeaad3117bd3c75e7c5cb7231a1cfa78ae Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2017-05-02 18:18:25 +00:00
#include "spdk/stdinc.h"
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
iscsi: Use not malloc'ed but fixed size string for target name and alias Using malloc'ed string for string in iSCSI target has caused scan-build error. Maximum size of target name is already defined to be MAX_TARGET_NAME, and hence use fixed size string whose size is MAX_TARGET_NAME + 1 for spdk_iscsi_tgt_node::name. Change psdk_iscsi_tgt_node::alias together. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Iac4cd6e9d60173ddeb68ca21ce712126c13bc3c4 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459707 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-06-28 01:18:07 +00:00
#include "iscsi/iscsi.h"
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
struct spdk_iscsi_conn;
iscsi: Manage PG-IG maps of the target by linked list This patch is a preparation for dynamic reconfiguration of PG-IG maps. Current PG-IG map is implemented by a fixed-size array. Linked list will make much easier to support dynamic reconfiguration of PG-IG maps. Current: target - (1..n) ---> PG_map (1..1) -> PG | --> IG_map (1..1) -> IG This proposal: target - (1..n) -> PG_map --- (1..1) -> PG | -- (1..m) -> IG_map - (1..1) -> IG Change-Id: I92f668b81cdd8003aff222926f8f1ed96b61e56d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385532 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-30 01:43:01 +00:00
struct spdk_iscsi_init_grp;
struct spdk_iscsi_portal_grp;
struct spdk_iscsi_portal;
iscsi: Add JSON config/info dump for target node. Support JSON config/info dump for target node. These are added to tgt_node.c Text config dump is moved to tgt_node.c too. All accesses to g_spdk_iscsi.target_head are consolidated into tgt_node.c to extract target_head from g_spdk_iscsi. Change-Id: Ibdf57c6ec9457d762c5640483b5810c9a74604ef Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/407848 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-05-04 07:20:02 +00:00
struct spdk_json_write_ctx;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
#define MAX_TARGET_MAP 256
scripts/check_format: check for spaces before tabs Automatically detect more whitespace errors. All existing cases are fixed; only whitespace change (verify with diff -w) except for one comment style fixup in include/spdk/nvme.h. Change-Id: If750e54b9c8e3421ea6feda5f20184a31431631e Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/402360 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-03-02 19:49:36 +00:00
#define SPDK_TN_TAG_MAX 0x0000ffff
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
lib/iscsi: Make iscsi_shutdown_tgt_node_by_name asynchronous This patch changes spdk_rpc_delete_target_node() to pass rpc_delete_target_node_done() and its context to spdk_iscsi_shutdown_tgt_node_by_name(). iscsi_tgt_node_destruct() is not asynchronized yet and so spdk_iscsi_shutdown_tgt_node_by_name() calls the callback passed from the caller directly for now. The next patch will replace the call. Change-Id: Ide2d9fcc6738e02de19f91249c21ac2d0d37138a Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450605 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-04-11 03:51:56 +00:00
typedef void (*iscsi_tgt_node_destruct_cb)(void *cb_arg, int rc);
iscsi: Manage PG-IG maps of the target by linked list This patch is a preparation for dynamic reconfiguration of PG-IG maps. Current PG-IG map is implemented by a fixed-size array. Linked list will make much easier to support dynamic reconfiguration of PG-IG maps. Current: target - (1..n) ---> PG_map (1..1) -> PG | --> IG_map (1..1) -> IG This proposal: target - (1..n) -> PG_map --- (1..1) -> PG | -- (1..m) -> IG_map - (1..1) -> IG Change-Id: I92f668b81cdd8003aff222926f8f1ed96b61e56d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385532 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-30 01:43:01 +00:00
struct spdk_iscsi_ig_map {
struct spdk_iscsi_init_grp *ig;
TAILQ_ENTRY(spdk_iscsi_ig_map) tailq;
};
struct spdk_iscsi_pg_map {
struct spdk_iscsi_portal_grp *pg;
int num_ig_maps;
TAILQ_HEAD(, spdk_iscsi_ig_map) ig_map_head;
lib/iscsi: Update redirect portal of public portal group iscsi_tgt_node_redirect() updates redirect portal of the initial portal iin a primary portal group for the target node. Check if the specified portal group is a public portal group and is mapped to the target node first. Then if the passed IP address-port pair is NULL, clear the current redirect setting. Public portal group and private portal group are clearly separated and redirect portal must be chosen from a private portal group. Hence this clear method is intuitive and simple. If the passed IP address-port pair is not NULL, check if they are valid, and are not in the specified portal group. Then update a redirect portal of the portal group map. Finally, send asynchronous logout request to all corresponding initiators. Besides, change allocating pg_map from malloc to calloc to initialize redirect portal. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I79d826663f4c3d5a117add286f133adeb1ce07f5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3222 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-07-22 06:48:36 +00:00
char redirect_host[MAX_PORTAL_ADDR + 1];
char redirect_port[MAX_PORTAL_PORT + 1];
iscsi: Manage PG-IG maps of the target by linked list This patch is a preparation for dynamic reconfiguration of PG-IG maps. Current PG-IG map is implemented by a fixed-size array. Linked list will make much easier to support dynamic reconfiguration of PG-IG maps. Current: target - (1..n) ---> PG_map (1..1) -> PG | --> IG_map (1..1) -> IG This proposal: target - (1..n) -> PG_map --- (1..1) -> PG | -- (1..m) -> IG_map - (1..1) -> IG Change-Id: I92f668b81cdd8003aff222926f8f1ed96b61e56d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385532 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-30 01:43:01 +00:00
TAILQ_ENTRY(spdk_iscsi_pg_map) tailq ;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
};
struct spdk_iscsi_tgt_node {
int num;
iscsi: Use not malloc'ed but fixed size string for target name and alias Using malloc'ed string for string in iSCSI target has caused scan-build error. Maximum size of target name is already defined to be MAX_TARGET_NAME, and hence use fixed size string whose size is MAX_TARGET_NAME + 1 for spdk_iscsi_tgt_node::name. Change psdk_iscsi_tgt_node::alias together. This change will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Iac4cd6e9d60173ddeb68ca21ce712126c13bc3c4 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/459707 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-06-28 01:18:07 +00:00
char name[MAX_TARGET_NAME + 1];
char alias[MAX_TARGET_NAME + 1];
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
pthread_mutex_t mutex;
iscsi: Adjust variable's name to JSON for iSCSI CHAP During converting type of CHAP params of target from int to bool for JSON, changed names of them to be consistent with others. In this patch, adjust variable name of struct to of JSON. Change-Id: I1ccbfa11d57479dc55680835eb80e111bd24d9a3 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/400928 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-02-22 23:01:42 +00:00
bool disable_chap;
bool require_chap;
bool mutual_chap;
int chap_group;
iscsi/rpc: Convert type of data/header digest params of target from int to bool This is a TODO from long ago. Complete this while adjusting dump() and construct() format of target. Change-Id: I44348ec404cae8882086a1a71a65914c9bafccc3 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/400202 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-21 09:47:34 +00:00
bool header_digest;
bool data_digest;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
int queue_depth;
struct spdk_scsi_dev *dev;
iscsi: start all sessions for a target node on the same lcore This ensures against races, when an existing session to a target node stalls, causing the initiator to create a new session. These new session's connection may get migrated to a different core than the core of the stalled session. In practice, this does not happen, but is a common occurrence when debugging the iSCSI target using gdb. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I1864c2ca0c330dc4faeeb1312adac7a02c8281dc
2016-09-21 21:11:39 +00:00
/**
* Counts number of active iSCSI connections associated with this
* target node.
*/
uint32_t num_active_conns;
iscsi: Assign connections to poll groups instead of lcores. This patch binds poll groups to SPDK thread through IO channel and assigns connections to poll groups instead of cores. iSCSI subsystem registers iSCSI global object as an IO device, and create poll groups as context of IO channels of the IO device. Each portal get and hold portal group on which the corresponding acceptor is running. When a connection is constructed, iSCSI subsystem assigns a poll group to the connection by getting it from the corresponding portal. When a connection enters full-feature phase, iSCSI subsystem schedules the connection to a poll group by round-robin. Then, each connection can know its running SPDK thread directly and can use SPDK message passing infrastructure instead of SPDK event framework. By this change, iSCSI connections are binded to SPDK thread, and not binded to processor core anymore. Some other changes in this patch are - core ID is removed from the output of get_iscsi_connections RPC. The upcoming patches will change the RPC to use spdk_for_each_channel and can access SPDK thread safely, and add SPDK thread ID instead. - utilize UT multithread framework added by the last patch to test iSCSI poll groups by UT. Change-Id: Iec73c778aa413bcabdb63141cc41d4160911ea0e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463359 Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-07-30 03:00:15 +00:00
struct spdk_iscsi_poll_group *pg;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
iscsi: Manage PG-IG maps of the target by linked list This patch is a preparation for dynamic reconfiguration of PG-IG maps. Current PG-IG map is implemented by a fixed-size array. Linked list will make much easier to support dynamic reconfiguration of PG-IG maps. Current: target - (1..n) ---> PG_map (1..1) -> PG | --> IG_map (1..1) -> IG This proposal: target - (1..n) -> PG_map --- (1..1) -> PG | -- (1..m) -> IG_map - (1..1) -> IG Change-Id: I92f668b81cdd8003aff222926f8f1ed96b61e56d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385532 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-11-30 01:43:01 +00:00
int num_pg_maps;
TAILQ_HEAD(, spdk_iscsi_pg_map) pg_map_head;
iscsi: make target management thread-safe by linked list Current fixed sized array for iSCSI target is not thread safe. When newly created targets are inserted into the array, multiple targets may be inserted into the same position. Linked list is better than fixed size array to support dynamic reconfiguration. Change-Id: I4db5a3ec16844db06e0cfcd2aef1f97952f15afa Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/385371 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-29 06:56:19 +00:00
TAILQ_ENTRY(spdk_iscsi_tgt_node) tailq;
lib/iscsi: Set destructed at the start of target node destruction Add the flag destructed to struct spdk_iscsi_tgt_node and iscsi_op_login_check_target() refers it and returns ISCSI_LOGIN_TARGET_REMOVED if it is true. When destructing iSCSI target node, it will be nice if iSCSI library can stop further connections are created but, connections are not associated with any target node until processing login. Hence stop creating sessions instead. Additionally, when destructing iSCSI target node, if the flag destructed is already set, return immediately, and the flag destructed does not affect discovery session. Change-Id: Ic73bdd93f2ca7d5ca1d2f897d5046cbc51650d5f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450881 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-04-11 00:34:42 +00:00
bool destructed;
lib/iscsi: Exit related connections at the start of target node destruction When any iSCSI target is destructed, if the target exits all corresponding connections first, destructing SCSI device will be easier. Hence, iscsi_tgt_node_destruct() starts exiting all corresponding connections. Then it destructs SCSI device immediately if no active active connections, or waits for the completion if there is any active connection for the target. Change-Id: Ibd4a29789faecfefccefa1153a519c43d040a00d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450737 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-04-12 04:38:42 +00:00
struct spdk_poller *destruct_poller;
lib/iscsi: Make iscsi_tgt_node_destruct asynchronous This patch changes iscsi_tgt_node_destruct to be asynchronous. spdk_iscsi_shutdown_tgt_node_by_name() uses the callback provided by iscsi_tgt_node_destruct(), but spdk_iscsi_shutdown_tgt_nodes() doesn't use it. The reason is that during shutdown all sessions are terminated already, and spdk_iscsi_shutdown_tgt_nodes() doesn't need to wait for the completion of iscsi_tgt_node_destruct() by using the callback. iscsi_tgt_node_destruct() will complete immediately in this case. spdk_scsi_dev_destruct() is not asynchronized yet and so iscsi_tgt_node_destruct() calls its callback directly in this patch. The next patch will replace the call. Change-Id: I86911c5297a93560551e0404d6ea85f49d647c22 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450606 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-04-12 04:50:40 +00:00
iscsi_tgt_node_destruct_cb destruct_cb_fn;
void *destruct_cb_arg;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
};
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in tgt_node.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I27419445fbd938b56b66a5ba2cc1cde75e7129ac Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1886 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com>
2020-04-15 21:04:36 +00:00
void iscsi_shutdown_tgt_nodes(void);
void iscsi_shutdown_tgt_node_by_name(const char *target_name,
iscsi_tgt_node_destruct_cb cb_fn, void *cb_arg);
bool iscsi_tgt_node_is_destructed(struct spdk_iscsi_tgt_node *target);
int iscsi_send_tgts(struct spdk_iscsi_conn *conn, const char *iiqn,
lib/iscsi: Remove unused the param iaddr from iscsi_send_tgts() Previously we might have any possibility to need iaddr in iscsi_send_tgts(), but it is highly unlikely now. Let's remove the param iaddr from iscsi_send_tgts(). Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Ide3405706b727a9d6ebaa92ed83509196ff675da Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3442 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2020-07-19 22:27:24 +00:00
const char *tiqn, uint8_t *data, int alloc_len, int data_len);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
scsi: remove lun name There is no need to keep a lun name anymore - we always use the bdev name as the lun name so it is not providing any additional value. This also keeps us from associating the same bdev with different LUNs on different iSCSI target nodes or vhost-scsi controllers. Side effect of this change is: 1) Use "bdev_name" across the APIs to make it more clear what these names refer to. Signed-off-by: Jim Harris <james.r.harris@intel.com> Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I3d42fde22087352ce1d5dc80178bd8c5cac8cb7c Reviewed-on: https://review.gerrithub.io/390843 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-01-10 05:55:53 +00:00
/*
* bdev_name_list and lun_id_list are equal sized arrays of size num_luns.
* bdev_name_list refers to the names of the bdevs that will be used for the LUNs on the
* new target node.
* lun_id_list refers to the LUN IDs that will be used for the LUNs on the target node.
*/
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in tgt_node.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I27419445fbd938b56b66a5ba2cc1cde75e7129ac Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1886 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com>
2020-04-15 21:04:36 +00:00
struct spdk_iscsi_tgt_node *iscsi_tgt_node_construct(int target_index,
lib/iscsi: Remove workaround for astyle format check about break-after-return-type To avoid the strange formatting, typedef has been used. But this comment is hard to get the meaning. So stop breaking after return type for this case. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I317604de67aab9f201d691e0f886bd673f451f3f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1051 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-02-28 06:20:06 +00:00
const char *name, const char *alias,
int *pg_tag_list, int *ig_tag_list, uint16_t num_maps,
const char *bdev_name_list[], int *lun_id_list, int num_luns,
int queue_depth,
bool disable_chap, bool require_chap, bool mutual_chap, int chap_group,
bool header_digest, bool data_digest);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in tgt_node.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I27419445fbd938b56b66a5ba2cc1cde75e7129ac Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1886 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com>
2020-04-15 21:04:36 +00:00
bool iscsi_check_chap_params(bool disable, bool require, bool mutual, int group);
int iscsi_target_node_add_pg_ig_maps(struct spdk_iscsi_tgt_node *target,
int *pg_tag_list, int *ig_tag_list,
uint16_t num_maps);
int iscsi_target_node_remove_pg_ig_maps(struct spdk_iscsi_tgt_node *target,
int *pg_tag_list, int *ig_tag_list,
uint16_t num_maps);
lib/iscsi: Update redirect portal of public portal group iscsi_tgt_node_redirect() updates redirect portal of the initial portal iin a primary portal group for the target node. Check if the specified portal group is a public portal group and is mapped to the target node first. Then if the passed IP address-port pair is NULL, clear the current redirect setting. Public portal group and private portal group are clearly separated and redirect portal must be chosen from a private portal group. Hence this clear method is intuitive and simple. If the passed IP address-port pair is not NULL, check if they are valid, and are not in the specified portal group. Then update a redirect portal of the portal group map. Finally, send asynchronous logout request to all corresponding initiators. Besides, change allocating pg_map from malloc to calloc to initialize redirect portal. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I79d826663f4c3d5a117add286f133adeb1ce07f5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3222 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-07-22 06:48:36 +00:00
int iscsi_tgt_node_redirect(struct spdk_iscsi_tgt_node *target, int pg_tag,
const char *host, const char *port);
lib/iscsi: Inform initiator that target has temporary moved to a different address If the portal group map of the target has a redirect portal, iscsi_tgt_node_is_moved() fills the buffer by the redirected address and returns true. iscsi_op_login_check_target() calls iscsi_tgt_node_is_redirected() before calling iscsi_tgt_node_access() because login redirection can be checked before any or after all security check. If iscsi_tgt_node_is_redirected() returns true, notify login redirection to the corresponding initiator. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I4573a69c0a32eafcfe48080a033c135e127da321 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3221 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-08-09 15:41:40 +00:00
bool iscsi_tgt_node_is_redirected(struct spdk_iscsi_conn *conn,
struct spdk_iscsi_tgt_node *target,
char *buf, int buf_len);
lib/iscsi: Remove the "spdk_" prefix from internal APIs declared in tgt_node.h Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I27419445fbd938b56b66a5ba2cc1cde75e7129ac Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1886 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Seth Howell <seth.howell@intel.com>
2020-04-15 21:04:36 +00:00
bool iscsi_tgt_node_access(struct spdk_iscsi_conn *conn,
struct spdk_iscsi_tgt_node *target, const char *iqn,
const char *addr);
struct spdk_iscsi_tgt_node *iscsi_find_tgt_node(const char *target_name);
int iscsi_tgt_node_cleanup_luns(struct spdk_iscsi_conn *conn,
struct spdk_iscsi_tgt_node *target);
void iscsi_tgt_node_delete_map(struct spdk_iscsi_portal_grp *portal_group,
struct spdk_iscsi_init_grp *initiator_group);
int iscsi_tgt_node_add_lun(struct spdk_iscsi_tgt_node *target,
const char *bdev_name, int lun_id);
int iscsi_tgt_node_set_chap_params(struct spdk_iscsi_tgt_node *target,
bool disable_chap, bool require_chap,
bool mutual_chap, int32_t chap_group);
void iscsi_tgt_nodes_info_json(struct spdk_json_write_ctx *w);
void iscsi_tgt_nodes_config_json(struct spdk_json_write_ctx *w);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
#endif /* SPDK_ISCSI_TGT_NODE_H_ */
Reference in New Issue Copy Permalink