ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6cc18a64aa
Spdk/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c

1177 lines
41 KiB
C
Raw Normal View History

test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
/*-
* BSD LICENSE
*
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
include: Move the remainder of the code base to stdinc.h Change-Id: I6a142feeaad3117bd3c75e7c5cb7231a1cfa78ae Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2017-05-02 18:18:25 +00:00
#include "spdk/stdinc.h"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
#include "spdk_cunit.h"
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
#include "spdk_internal/mock.h"
thread: Use TLS to accelerate thread look up Change-Id: I8136db265c9cb8d61de4845ce6eaff2351b5b597 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/435939 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-09-17 23:18:53 +00:00
#include "spdk_internal/thread.h"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
#include "common/lib/ut_multithread.c"
test: use spdk.unittest.mk for nvmf unit tests This includes removing the nvmf.unittest.mk that these unit tests were using previously. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I3b53db0a565aee910587826b37e8b43d6a324e75 Reviewed-on: https://review.gerrithub.io/399724 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-02-13 15:24:28 +00:00
#include "nvmf/ctrlr.c"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
log: rename SPDK_TRACE_* to SPDK_LOG_* Disambiguate the log components from the trace functionality (include/spdk/trace.h). The internal spdk_trace_flag structure and related functions will be renamed in a later commit - this is just a find and replace on SPDK_TRACE_* and SPDK_LOG_REGISTER_TRACE_FLAG(). Change-Id: I617bd5a9fbe35ffb44ae6020b292658c094a0ad6 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/376421 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-08-30 18:06:33 +00:00
SPDK_LOG_REGISTER_COMPONENT("nvmf", SPDK_LOG_NVMF)
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
nvmf: implement NS Identification Descriptor list Currently, this just reports the EUI64 and NGUID types, which are already available in the Identify Namespace data, but this sets up the framework for reporting a Namespace UUID (which doesn't have a corresponding field in Identify Namespace) in the future. Change-Id: I758e6d402ff874d65eca3f1db98d92c1a3f7a11f Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400893 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-21 23:10:39 +00:00
struct spdk_bdev {
int ut_mock;
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
uint64_t blockcnt;
nvmf: implement NS Identification Descriptor list Currently, this just reports the EUI64 and NGUID types, which are already available in the Identify Namespace data, but this sets up the framework for reporting a Namespace UUID (which doesn't have a corresponding field in Identify Namespace) in the future. Change-Id: I758e6d402ff874d65eca3f1db98d92c1a3f7a11f Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400893 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-21 23:10:39 +00:00
};
nvmf: refactor controller creation Simplify the initialization of controller identify data and properties. This is mostly common between discovery and NVM subsystems. Change-Id: Id8074d5260213e32892fd77845884a80071c9d88 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/374534 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-16 21:03:42 +00:00
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_tgt_find_subsystem,
struct spdk_nvmf_subsystem *,
(struct spdk_nvmf_tgt *tgt, const char *subnqn),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_poll_group_create,
struct spdk_nvmf_poll_group *,
(struct spdk_nvmf_tgt *tgt),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_get_sn,
const char *,
(const struct spdk_nvmf_subsystem *subsystem),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
NVMF: Add model number as parameter to construct_nvmf_subsystem (-d option). Change-Id: Ia1a458a0ac1c5a17d2955a3f31c6dfe77538eb17 Signed-off-by: Gregory Shapiro <gregory.shapiro@kaminario.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/438562 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-12-29 19:39:48 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_get_mn,
const char *,
(const struct spdk_nvmf_subsystem *subsystem),
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_get_first_ns,
struct spdk_nvmf_ns *,
(struct spdk_nvmf_subsystem *subsystem),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_get_next_ns,
struct spdk_nvmf_ns *,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ns *prev_ns),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_host_allowed,
bool,
(struct spdk_nvmf_subsystem *subsystem, const char *hostnqn),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
true);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr,
int,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
0);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr,
struct spdk_nvmf_ctrlr *,
(struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
NULL);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported,
bool,
(struct spdk_nvmf_ctrlr *ctrlr),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
false);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported,
bool,
(struct spdk_nvmf_ctrlr *ctrlr),
test/nvmf: add semicolons to avoid astyle 3.1 bug The DEFINE_STUB macro doesn't actually need a trailing semicolon, but adding one avoids a new astyle 3.1 bug that otherwise causes these stubs to get reformatted incorrectly. Change-Id: Idc281d08ba8e1ca0593442b6e4d25add25bea2d7 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/410068 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-05-04 17:52:28 +00:00
false);
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page,
nvmf: Discover commands use the nvmf_req->iov struct Discover commands previously blindly used the nvmf_req->data structure. This only works if the entire command fits in a single contiguous buffer. commit 1d9be84bfdf8 changed the default buffer size such that this would become a problem for as few as 8 subsystems. Fixes github issue 525 This change may also help prevent data corruption as we were copying up to nvmf_req->length data into the buffer. For requests with multiple data buffers this can cause us to copy off the end of that buffer. Change-Id: I788259da988b2458f57ee2795e1c5d3ced8803dd Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/435544 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-29 21:11:31 +00:00
(struct spdk_nvmf_tgt *tgt, struct iovec *iov, uint32_t iovcnt, uint64_t offset, uint32_t length));
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
nvmf: Correctly enforce subsystem listener access control Connections to a subsystem may only originate on listeners that have been explicitly allowed for the given subsystem. Change-Id: Ib575a5803cc7af75c15d1a2c76b9866594e7a1db Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/425024 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-09-07 21:05:01 +00:00
DEFINE_STUB(spdk_nvmf_qpair_get_listen_trid,
int,
(struct spdk_nvmf_qpair *qpair, struct spdk_nvme_transport_id *trid),
0);
DEFINE_STUB(spdk_nvmf_subsystem_listener_allowed,
bool,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvme_transport_id *trid),
true);
nvme: Add the NVMe over fabrics TCP/IP transport support It is the first patch to follow the NVMe over fabrics spec and implmenent the NVMe/TCP transport. It can be divided into work in the host and target sides: Host side: Add the TCP/IP transport in nvme lib (lib/nvme). Target side: Add the TCP/IP transport in nvmf lib (lib/nvmf). Change-Id: Idc4f93750df676354f6c2ea8ecdb234e3638fd44 Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/425191 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-08-02 02:21:45 +00:00
DEFINE_STUB(spdk_nvmf_transport_qpair_set_sqsize,
int,
(struct spdk_nvmf_qpair *qpair),
0);
nvmf: Move spdk_nvmf_ctrlr_process_io_cmd into ctrlr.c Previously, all I/O commands were implemented by simply passing them to the bdev layer. Now, some I/O commands will be emulated. Prepare for that by moving the code for this function to ctrlr.c, where the emulation will occur. Change-Id: Id34e5549e5ce216d602fb347b4506fbd324eed4e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440591 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 17:47:56 +00:00
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_read_cmd,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_cmd,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_write_zeroes_cmd,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_flush_cmd,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_dsm_cmd,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_nvme_passthru_io,
int,
(struct spdk_bdev *bdev, struct spdk_bdev_desc *desc, struct spdk_io_channel *ch,
struct spdk_nvmf_request *req),
0);
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
DEFINE_STUB(spdk_nvmf_transport_req_complete,
int,
(struct spdk_nvmf_request *req),
0);
nvmf: add namespace reservation register command support Reservations can be used by two or more hosts to coordinate acccess to a shared namespace, host must register to a namespace prior to establishing a reservation. Unregistering by a host may cause a reservation release, this feature will be supported after reservation acquire patch. Change-Id: Id44aa1f82f30d9ecc5999a2a9a7c20b2af77774a Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/436936 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2019-02-28 02:50:03 +00:00
DEFINE_STUB_V(spdk_nvmf_ns_reservation_request, (void *ctx));
nvmf: Add the Keep Alive feature The controller shall treat a Keep Alive Timeout in the same manner as connection loss. If the Keep Alive feature is in use and the timer expires, then the controller shall: 1, stop processing commands and set the Controller Fatal Status (CSTS,CFS) bit to '1'; 2, terminate the NVMe Transport connection; 3, break the host to controller association; A timer poller is added to each subsystem to monitor timeout event. Change-Id: I001afab8a6764f30c39df37fa96384180d117486 Signed-off-by: JinYu <jin.yu@intel.com> Reviewed-on: https://review.gerrithub.io/c/439330 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2019-01-07 10:47:29 +00:00
int
spdk_nvmf_qpair_disconnect(struct spdk_nvmf_qpair *qpair, nvmf_qpair_disconnect_cb cb_fn, void *ctx)
{
return 0;
}
ctrlr_bdev: change spdk_nvmf_bdev_ctrlr_identify_ns to return void This function doesn't return error code Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I67a8fa7393990470e509baa8934e78bc6f6a6c9e Reviewed-on: https://review.gerrithub.io/429441 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-10-15 09:23:24 +00:00
void
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
spdk_nvmf_bdev_ctrlr_identify_ns(struct spdk_nvmf_ns *ns, struct spdk_nvme_ns_data *nsdata)
{
uint64_t num_blocks;
SPDK_CU_ASSERT_FATAL(ns->bdev != NULL);
num_blocks = ns->bdev->blockcnt;
nsdata->nsze = num_blocks;
nsdata->ncap = num_blocks;
nsdata->nuse = num_blocks;
nsdata->nlbaf = 0;
nsdata->flbas.format = 0;
nsdata->lbaf[0].lbads = spdk_u32log2(512);
}
nvmf: refactor get_log_page into a common function Both regular NVM controllers and discovery controllers implement the Get Log Page command; combine the implementations into one in ctrlr.c. Change-Id: I7fabf40ec52d8738263ac152afe9cd7773ff7fbd Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/374555 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-17 01:13:49 +00:00
static void
test_get_log_page(void)
{
struct spdk_nvmf_subsystem subsystem = {};
struct spdk_nvmf_request req = {};
struct spdk_nvmf_qpair qpair = {};
struct spdk_nvmf_ctrlr ctrlr = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
char data[4096];
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
ctrlr.subsys = &subsystem;
qpair.ctrlr = &ctrlr;
req.qpair = &qpair;
req.cmd = &cmd;
req.rsp = &rsp;
req.data = &data;
req.length = sizeof(data);
/* Get Log Page - all valid */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
/* Get Log Page with invalid log ID */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = 0;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
/* Get Log Page with invalid offset (not dword aligned) */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
cmd.nvme_cmd.cdw12 = 2;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
/* Get Log Page without data buffer */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
req.data = NULL;
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
req.data = data;
}
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
static void
test_process_fabrics_cmd(void)
{
struct spdk_nvmf_request req = {};
int ret;
struct spdk_nvmf_qpair req_qpair = {};
union nvmf_h2c_msg req_cmd = {};
union nvmf_c2h_msg req_rsp = {};
req.qpair = &req_qpair;
req.cmd = &req_cmd;
req.rsp = &req_rsp;
req.qpair->ctrlr = NULL;
/* No ctrlr and invalid command check */
req.cmd->nvmf_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET;
ret = spdk_nvmf_ctrlr_process_fabrics_cmd(&req);
CU_ASSERT_EQUAL(req.rsp->nvme_cpl.status.sc, SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR);
CU_ASSERT_EQUAL(ret, SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
}
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
static bool
nvme_status_success(const struct spdk_nvme_status *status)
{
return status->sct == SPDK_NVME_SCT_GENERIC && status->sc == SPDK_NVME_SC_SUCCESS;
}
static void
test_connect(void)
{
struct spdk_nvmf_fabric_connect_data connect_data;
struct spdk_nvmf_poll_group group;
struct spdk_nvmf_transport transport;
struct spdk_nvmf_subsystem subsystem;
struct spdk_nvmf_request req;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
struct spdk_nvmf_qpair admin_qpair;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
struct spdk_nvmf_qpair qpair;
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
struct spdk_nvmf_qpair qpair2;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
struct spdk_nvmf_ctrlr ctrlr;
struct spdk_nvmf_tgt tgt;
union nvmf_h2c_msg cmd;
union nvmf_c2h_msg rsp;
const uint8_t hostid[16] = {
0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F
};
const char subnqn[] = "nqn.2016-06.io.spdk:subsystem1";
const char hostnqn[] = "nqn.2016-06.io.spdk:host1";
int rc;
memset(&group, 0, sizeof(group));
test/nvmf: Simplify thread handling in ctrlr_ut Change-Id: Ic804ad99a28b3ba03b67c1733e46f280e0ad9cb8 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/433681 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-16 21:49:20 +00:00
group.thread = spdk_get_thread();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&ctrlr, 0, sizeof(ctrlr));
ctrlr.subsys = &subsystem;
nvmf: Perform QID validation using a bit mask Instead of scanning a list of all qpairs, use a bit mask to determine if the requested QID is unique. This is not for performance reasons, but because eventually the ctrlr's list of qpairs is going to need to go away. Change-Id: Ic25ee60e4f9cd9d596815719760d5be892f29d0c Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413286 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-06-01 22:00:20 +00:00
ctrlr.qpair_mask = spdk_bit_array_create(3);
SPDK_CU_ASSERT_FATAL(ctrlr.qpair_mask != NULL);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
ctrlr.vcprop.cc.bits.en = 1;
ctrlr.vcprop.cc.bits.iosqes = 6;
ctrlr.vcprop.cc.bits.iocqes = 4;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
memset(&admin_qpair, 0, sizeof(admin_qpair));
admin_qpair.group = &group;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&tgt, 0, sizeof(tgt));
memset(&transport, 0, sizeof(transport));
nvmf: Move target opts to transport opts (part 1) - Move most of the target opts from nvmf_tgt to nvmf_transport. - Update transport create functions to pass in transport opts. - When transport opts are NULL in transport create function, use target opts. (for backward compatiblity) - Part 1 of 2 patches. Part 2 (to follow after part 1 accepted) will allow independent creation of transport with specific opts while maintaining backward compatibility with current apps and rpc configuration that still use the add listener method to create a transport. Change-Id: I0e27447c4a98e0b6a6c590541404b4e4be879b47 Signed-off-by: John Barnard <john.barnard@broadcom.com> Reviewed-on: https://review.gerrithub.io/423329 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-08-22 23:04:16 +00:00
transport.opts.max_queue_depth = 64;
transport.opts.max_qpairs_per_ctrlr = 3;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
transport.tgt = &tgt;
memset(&qpair, 0, sizeof(qpair));
qpair.transport = &transport;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
qpair.group = &group;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
qpair.state = SPDK_NVMF_QPAIR_ACTIVE;
TAILQ_INIT(&qpair.outstanding);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&connect_data, 0, sizeof(connect_data));
memcpy(connect_data.hostid, hostid, sizeof(hostid));
connect_data.cntlid = 0xFFFF;
test: Remove all uses of strncpy strncpy is going to be added to the list of banned functions because it does not guarantee strings are null terminated. Change-Id: I73adb5d3eea5c95ea705c67de4fc967e926eb6ce Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/407025 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-04-09 23:10:21 +00:00
snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn);
snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&subsystem, 0, sizeof(subsystem));
test/nvmf: Simplify thread handling in ctrlr_ut Change-Id: Ic804ad99a28b3ba03b67c1733e46f280e0ad9cb8 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/433681 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-16 21:49:20 +00:00
subsystem.thread = spdk_get_thread();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
subsystem.id = 1;
TAILQ_INIT(&subsystem.ctrlrs);
subsystem.tgt = &tgt;
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
nvmf: Only present subsystem if it is ready We do not want to present those subsystems which are not ready. Change-Id: I7f5c171fbac4c31d839421e37e93e62569c0e87a Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/c/437222 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-12-14 01:57:55 +00:00
subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
snprintf(subsystem.subnqn, sizeof(subsystem.subnqn), "%s", subnqn);
memset(&cmd, 0, sizeof(cmd));
cmd.connect_cmd.opcode = SPDK_NVME_OPC_FABRIC;
cmd.connect_cmd.cid = 1;
cmd.connect_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_CONNECT;
cmd.connect_cmd.recfmt = 0;
cmd.connect_cmd.qid = 0;
cmd.connect_cmd.sqsize = 31;
cmd.connect_cmd.cattr = 0;
cmd.connect_cmd.kato = 120000;
memset(&req, 0, sizeof(req));
req.qpair = &qpair;
req.length = sizeof(connect_data);
req.xfer = SPDK_NVME_DATA_HOST_TO_CONTROLLER;
req.data = &connect_data;
req.cmd = &cmd;
req.rsp = &rsp;
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_tgt_find_subsystem, &subsystem);
MOCK_SET(spdk_nvmf_poll_group_create, &group);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Valid admin connect command */
memset(&rsp, 0, sizeof(rsp));
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Make the ctrlr create/remove in subsystem in an asynchronous way Ctrlrs list maintanined by the subsystem structure should be operated by the thread which creates the subsystem. And this will make the operations correct. Change-Id: I7f881a77b1846658b3acd4270b74f86816e87803 Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/401541 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-27 04:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
CU_ASSERT(qpair.ctrlr != NULL);
nvmf: Add the Keep Alive feature The controller shall treat a Keep Alive Timeout in the same manner as connection loss. If the Keep Alive feature is in use and the timer expires, then the controller shall: 1, stop processing commands and set the Controller Fatal Status (CSTS,CFS) bit to '1'; 2, terminate the NVMe Transport connection; 3, break the host to controller association; A timer poller is added to each subsystem to monitor timeout event. Change-Id: I001afab8a6764f30c39df37fa96384180d117486 Signed-off-by: JinYu <jin.yu@intel.com> Reviewed-on: https://review.gerrithub.io/c/439330 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2019-01-07 10:47:29 +00:00
spdk_nvmf_ctrlr_stop_keep_alive_timer(qpair.ctrlr);
nvmf: Perform QID validation using a bit mask Instead of scanning a list of all qpairs, use a bit mask to determine if the requested QID is unique. This is not for performance reasons, but because eventually the ctrlr's list of qpairs is going to need to go away. Change-Id: Ic25ee60e4f9cd9d596815719760d5be892f29d0c Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413286 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-06-01 22:00:20 +00:00
spdk_bit_array_free(&qpair.ctrlr->qpair_mask);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
free(qpair.ctrlr);
qpair.ctrlr = NULL;
nvmf: add keep alive unit test Add the KATO==0 uint test of keep alive feature. 1, If subsystem == nvme && KATO == 0, it means initiator don't want to enable keep alive feature, the keep_alive_poller would not be registered. 2, If subsystem == discovery, KATO must be 0. Change-Id: I212b344e235e94d5f34168d43d45766283773446 Signed-off-by: JinYu <jin.yu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451819 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-04-24 12:59:50 +00:00
/* Valid admin connect command with kato = 0 */
cmd.connect_cmd.kato = 0;
memset(&rsp, 0, sizeof(rsp));
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
rc = spdk_nvmf_ctrlr_connect(&req);
poll_threads();
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
CU_ASSERT(qpair.ctrlr != NULL && qpair.ctrlr->keep_alive_poller == NULL);
spdk_bit_array_free(&qpair.ctrlr->qpair_mask);
free(qpair.ctrlr);
qpair.ctrlr = NULL;
cmd.connect_cmd.kato = 120000;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Invalid data length */
memset(&rsp, 0, sizeof(rsp));
req.length = sizeof(connect_data) - 1;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
CU_ASSERT(qpair.ctrlr == NULL);
req.length = sizeof(connect_data);
/* Invalid recfmt */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.recfmt = 1234;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INCOMPATIBLE_FORMAT);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.recfmt = 0;
/* Unterminated subnqn */
memset(&rsp, 0, sizeof(rsp));
memset(connect_data.subnqn, 'a', sizeof(connect_data.subnqn));
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256);
CU_ASSERT(qpair.ctrlr == NULL);
test: Remove all uses of strncpy strncpy is going to be added to the list of banned functions because it does not guarantee strings are null terminated. Change-Id: I73adb5d3eea5c95ea705c67de4fc967e926eb6ce Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/407025 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-04-09 23:10:21 +00:00
snprintf(connect_data.subnqn, sizeof(connect_data.subnqn), "%s", subnqn);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Subsystem not found */
memset(&rsp, 0, sizeof(rsp));
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_tgt_find_subsystem, NULL);
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256);
CU_ASSERT(qpair.ctrlr == NULL);
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_tgt_find_subsystem, &subsystem);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Unterminated hostnqn */
memset(&rsp, 0, sizeof(rsp));
memset(connect_data.hostnqn, 'b', sizeof(connect_data.hostnqn));
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 512);
CU_ASSERT(qpair.ctrlr == NULL);
test: Remove all uses of strncpy strncpy is going to be added to the list of banned functions because it does not guarantee strings are null terminated. Change-Id: I73adb5d3eea5c95ea705c67de4fc967e926eb6ce Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/407025 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-04-09 23:10:21 +00:00
snprintf(connect_data.hostnqn, sizeof(connect_data.hostnqn), "%s", hostnqn);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Host not allowed */
memset(&rsp, 0, sizeof(rsp));
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_subsystem_host_allowed, false);
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_HOST);
CU_ASSERT(qpair.ctrlr == NULL);
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_subsystem_host_allowed, true);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Invalid sqsize == 0 */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.sqsize = 0;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.sqsize = 31;
/* Invalid sqsize > max_queue_depth */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.sqsize = 64;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.sqsize = 31;
/* Invalid cntlid for admin queue */
memset(&rsp, 0, sizeof(rsp));
connect_data.cntlid = 0x1234;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16);
CU_ASSERT(qpair.ctrlr == NULL);
connect_data.cntlid = 0xFFFF;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
ctrlr.admin_qpair = &admin_qpair;
ctrlr.subsys = &subsystem;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Valid I/O queue connect command */
memset(&rsp, 0, sizeof(rsp));
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
cmd.connect_cmd.qid = 1;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
CU_ASSERT(qpair.ctrlr == &ctrlr);
qpair.ctrlr = NULL;
/* Non-existent controller */
memset(&rsp, 0, sizeof(rsp));
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, NULL);
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Make the ctrlr create/remove in subsystem in an asynchronous way Ctrlrs list maintanined by the subsystem structure should be operated by the thread which creates the subsystem. And this will make the operations correct. Change-Id: I7f881a77b1846658b3acd4270b74f86816e87803 Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/401541 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-27 04:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16);
CU_ASSERT(qpair.ctrlr == NULL);
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, &ctrlr);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* I/O connect to discovery controller */
memset(&rsp, 0, sizeof(rsp));
subsystem.subtype = SPDK_NVMF_SUBTYPE_DISCOVERY;
nvmf: Only present subsystem if it is ready We do not want to present those subsystems which are not ready. Change-Id: I7f5c171fbac4c31d839421e37e93e62569c0e87a Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/c/437222 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-12-14 01:57:55 +00:00
subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
nvmf: add keep alive unit test Add the KATO==0 uint test of keep alive feature. 1, If subsystem == nvme && KATO == 0, it means initiator don't want to enable keep alive feature, the keep_alive_poller would not be registered. 2, If subsystem == discovery, KATO must be 0. Change-Id: I212b344e235e94d5f34168d43d45766283773446 Signed-off-by: JinYu <jin.yu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/451819 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-04-24 12:59:50 +00:00
/* I/O connect to discovery controller keep-alive-timeout should be 0 */
cmd.connect_cmd.qid = 0;
memset(&rsp, 0, sizeof(rsp));
subsystem.subtype = SPDK_NVMF_SUBTYPE_DISCOVERY;
subsystem.state = SPDK_NVMF_SUBSYSTEM_ACTIVE;
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
rc = spdk_nvmf_ctrlr_connect(&req);
poll_threads();
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INTERNAL_DEVICE_ERROR);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.qid = 1;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
/* I/O connect to disabled controller */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.en = 0;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.en = 1;
/* I/O connect with invalid IOSQES */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.iosqes = 3;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.iosqes = 6;
/* I/O connect with invalid IOCQES */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.iocqes = 3;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.iocqes = 4;
/* I/O connect with too many existing qpairs */
memset(&rsp, 0, sizeof(rsp));
nvmf: Eliminate num_qpairs counter in controller struct The qpair mask can be used instead. Change-Id: I9063e656c7c44663dc96adfd5ef52a5a1065d2ba Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413860 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-06-04 20:45:59 +00:00
spdk_bit_array_set(ctrlr.qpair_mask, 0);
spdk_bit_array_set(ctrlr.qpair_mask, 1);
spdk_bit_array_set(ctrlr.qpair_mask, 2);
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
nvmf: Return the correct error for out-of-range QID This one is actually a bit tough to deduce in the specification. The NVMe-oF spec says that QID errors detected in the RDMA transport shall return an RDMA-specific error indicating the problem. However, our code doesn't detect the error in RDMA-specific code, and it isn't clear if the language is a "must" or a "should". The NVMe specification does clearly indicate what error to return on invalid QID in response to a Create I/O Queue Pair command. For now, return that while we game plan whether we need to call into the RDMA transport to correctly report this error. Change-Id: I7faf37bad9b9202bc50a906214a51c17e4808fc0 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413858 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-06-04 20:54:23 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(qpair.ctrlr == NULL);
nvmf: Eliminate num_qpairs counter in controller struct The qpair mask can be used instead. Change-Id: I9063e656c7c44663dc96adfd5ef52a5a1065d2ba Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413860 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-06-04 20:45:59 +00:00
spdk_bit_array_clear(ctrlr.qpair_mask, 0);
spdk_bit_array_clear(ctrlr.qpair_mask, 1);
spdk_bit_array_clear(ctrlr.qpair_mask, 2);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
/* I/O connect with duplicate queue ID */
memset(&rsp, 0, sizeof(rsp));
memset(&qpair2, 0, sizeof(qpair2));
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
qpair2.group = &group;
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
qpair2.qid = 1;
nvmf: Perform QID validation using a bit mask Instead of scanning a list of all qpairs, use a bit mask to determine if the requested QID is unique. This is not for performance reasons, but because eventually the ctrlr's list of qpairs is going to need to go away. Change-Id: Ic25ee60e4f9cd9d596815719760d5be892f29d0c Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413286 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-06-01 22:00:20 +00:00
spdk_bit_array_set(ctrlr.qpair_mask, 1);
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
cmd.connect_cmd.qid = 1;
nvmf: Collapse request.c into ctrlr.c request.c didn't have much code, so let's collapse it into ctrlr.c and make that the place where all software emulator of the NVMe controller, including request handling, is done. Change-Id: Id7c98010cb222a414a5aa0b78bfb299a0ffc418f Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/440592 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-15 20:19:42 +00:00
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
rc = spdk_nvmf_ctrlr_connect(&req);
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
poll_threads();
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
nvmf: Return the correct error for out-of-range QID This one is actually a bit tough to deduce in the specification. The NVMe-oF spec says that QID errors detected in the RDMA transport shall return an RDMA-specific error indicating the problem. However, our code doesn't detect the error in RDMA-specific code, and it isn't clear if the language is a "must" or a "should". The NVMe specification does clearly indicate what error to return on invalid QID in response to a Create I/O Queue Pair command. For now, return that while we game plan whether we need to call into the RDMA transport to correctly report this error. Change-Id: I7faf37bad9b9202bc50a906214a51c17e4808fc0 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413858 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-06-04 20:54:23 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_QUEUE_IDENTIFIER);
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
CU_ASSERT(qpair.ctrlr == NULL);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Clean up globals */
test: Simplify the mock library Unify the regular mocks and the pointer mocks. Simplify several of the #defines. Change-Id: Ica8c69dbb70a685a55b5961b73fd7872f451c305 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/418884 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-07-10 17:47:14 +00:00
MOCK_CLEAR(spdk_nvmf_tgt_find_subsystem);
MOCK_CLEAR(spdk_nvmf_poll_group_create);
nvmf: Perform QID validation using a bit mask Instead of scanning a list of all qpairs, use a bit mask to determine if the requested QID is unique. This is not for performance reasons, but because eventually the ctrlr's list of qpairs is going to need to go away. Change-Id: Ic25ee60e4f9cd9d596815719760d5be892f29d0c Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/413286 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-06-01 22:00:20 +00:00
spdk_bit_array_free(&ctrlr.qpair_mask);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
}
nvmf: implement NS Identification Descriptor list Currently, this just reports the EUI64 and NGUID types, which are already available in the Identify Namespace data, but this sets up the framework for reporting a Namespace UUID (which doesn't have a corresponding field in Identify Namespace) in the future. Change-Id: I758e6d402ff874d65eca3f1db98d92c1a3f7a11f Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400893 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-21 23:10:39 +00:00
static void
test_get_ns_id_desc_list(void)
{
struct spdk_nvmf_subsystem subsystem;
struct spdk_nvmf_qpair qpair;
struct spdk_nvmf_ctrlr ctrlr;
struct spdk_nvmf_request req;
struct spdk_nvmf_ns *ns_ptrs[1];
struct spdk_nvmf_ns ns;
union nvmf_h2c_msg cmd;
union nvmf_c2h_msg rsp;
struct spdk_bdev bdev;
uint8_t buf[4096];
memset(&subsystem, 0, sizeof(subsystem));
ns_ptrs[0] = &ns;
subsystem.ns = ns_ptrs;
subsystem.max_nsid = 1;
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
memset(&ns, 0, sizeof(ns));
ns.opts.nsid = 1;
ns.bdev = &bdev;
memset(&qpair, 0, sizeof(qpair));
qpair.ctrlr = &ctrlr;
memset(&ctrlr, 0, sizeof(ctrlr));
ctrlr.subsys = &subsystem;
ctrlr.vcprop.cc.bits.en = 1;
memset(&req, 0, sizeof(req));
req.qpair = &qpair;
req.cmd = &cmd;
req.rsp = &rsp;
req.xfer = SPDK_NVME_DATA_CONTROLLER_TO_HOST;
req.data = buf;
req.length = sizeof(buf);
memset(&cmd, 0, sizeof(cmd));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_IDENTIFY;
cmd.nvme_cmd.cdw10 = SPDK_NVME_IDENTIFY_NS_ID_DESCRIPTOR_LIST;
/* Invalid NSID */
cmd.nvme_cmd.nsid = 0;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT);
/* Valid NSID, but ns has no IDs defined */
cmd.nvme_cmd.nsid = 1;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(spdk_mem_all_zero(buf, sizeof(buf)));
/* Valid NSID, only EUI64 defined */
ns.opts.eui64[0] = 0x11;
ns.opts.eui64[7] = 0xFF;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64);
CU_ASSERT(buf[1] == 8);
CU_ASSERT(buf[4] == 0x11);
CU_ASSERT(buf[11] == 0xFF);
CU_ASSERT(buf[13] == 0);
/* Valid NSID, only NGUID defined */
memset(ns.opts.eui64, 0, sizeof(ns.opts.eui64));
ns.opts.nguid[0] = 0x22;
ns.opts.nguid[15] = 0xEE;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(buf[0] == SPDK_NVME_NIDT_NGUID);
CU_ASSERT(buf[1] == 16);
CU_ASSERT(buf[4] == 0x22);
CU_ASSERT(buf[19] == 0xEE);
CU_ASSERT(buf[21] == 0);
/* Valid NSID, both EUI64 and NGUID defined */
ns.opts.eui64[0] = 0x11;
ns.opts.eui64[7] = 0xFF;
ns.opts.nguid[0] = 0x22;
ns.opts.nguid[15] = 0xEE;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64);
CU_ASSERT(buf[1] == 8);
CU_ASSERT(buf[4] == 0x11);
CU_ASSERT(buf[11] == 0xFF);
CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID);
CU_ASSERT(buf[13] == 16);
CU_ASSERT(buf[16] == 0x22);
CU_ASSERT(buf[31] == 0xEE);
CU_ASSERT(buf[33] == 0);
nvmf: retrieve namespace UUID from bdev A new optional parameter is added to the NVMe-oF target namespace options to set the Namespace UUID, which will be reported via the Identify command Namespace Identification Descriptor list. Change-Id: I53c6d6fa6475d3395d412d196b42000715e9ed81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400894 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-22 00:09:56 +00:00
/* Valid NSID, EUI64, NGUID, and UUID defined */
ns.opts.eui64[0] = 0x11;
ns.opts.eui64[7] = 0xFF;
ns.opts.nguid[0] = 0x22;
ns.opts.nguid[15] = 0xEE;
ns.opts.uuid.u.raw[0] = 0x33;
ns.opts.uuid.u.raw[15] = 0xDD;
memset(&rsp, 0, sizeof(rsp));
CU_ASSERT(spdk_nvmf_ctrlr_process_admin_cmd(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(buf[0] == SPDK_NVME_NIDT_EUI64);
CU_ASSERT(buf[1] == 8);
CU_ASSERT(buf[4] == 0x11);
CU_ASSERT(buf[11] == 0xFF);
CU_ASSERT(buf[12] == SPDK_NVME_NIDT_NGUID);
CU_ASSERT(buf[13] == 16);
CU_ASSERT(buf[16] == 0x22);
CU_ASSERT(buf[31] == 0xEE);
CU_ASSERT(buf[32] == SPDK_NVME_NIDT_UUID);
CU_ASSERT(buf[33] == 16);
CU_ASSERT(buf[36] == 0x33);
CU_ASSERT(buf[51] == 0xDD);
CU_ASSERT(buf[53] == 0);
nvmf: implement NS Identification Descriptor list Currently, this just reports the EUI64 and NGUID types, which are already available in the Identify Namespace data, but this sets up the framework for reporting a Namespace UUID (which doesn't have a corresponding field in Identify Namespace) in the future. Change-Id: I758e6d402ff874d65eca3f1db98d92c1a3f7a11f Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400893 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-21 23:10:39 +00:00
}
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
static void
test_identify_ns(void)
{
struct spdk_nvmf_subsystem subsystem = {};
nvmf: set noiob no larger than mdts Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I875cc9d6a6bd1e9e9ac25ca9103a2070226ac236 Reviewed-on: https://review.gerrithub.io/428877 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-10-11 07:07:16 +00:00
struct spdk_nvmf_transport transport = {};
struct spdk_nvmf_qpair admin_qpair = { .transport = &transport};
struct spdk_nvmf_ctrlr ctrlr = { .subsys = &subsystem, .admin_qpair = &admin_qpair };
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
struct spdk_nvme_cmd cmd = {};
struct spdk_nvme_cpl rsp = {};
struct spdk_nvme_ns_data nsdata = {};
struct spdk_bdev bdev[3] = {{.blockcnt = 1234}, {.blockcnt = 0}, {.blockcnt = 5678}};
struct spdk_nvmf_ns ns[3] = {{.bdev = &bdev[0]}, {.bdev = NULL}, {.bdev = &bdev[2]}};
struct spdk_nvmf_ns *ns_arr[3] = {&ns[0], NULL, &ns[2]};
subsystem.ns = ns_arr;
subsystem.max_nsid = SPDK_COUNTOF(ns_arr);
/* Invalid NSID 0 */
cmd.nsid = 0;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT);
CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata)));
/* Valid NSID 1 */
cmd.nsid = 1;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(nsdata.nsze == 1234);
/* Valid but inactive NSID 2 */
cmd.nsid = 2;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata)));
/* Valid NSID 3 */
cmd.nsid = 3;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_SUCCESS);
CU_ASSERT(nsdata.nsze == 5678);
/* Invalid NSID 4 */
cmd.nsid = 4;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT);
CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata)));
/* Invalid NSID 0xFFFFFFFF (NS management not supported) */
cmd.nsid = 0xFFFFFFFF;
memset(&nsdata, 0, sizeof(nsdata));
memset(&rsp, 0, sizeof(rsp));
nvmf: provide ctrlr to spdk_nvmf_ctrlr_identify_ns Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I90f68e9dbe00854f569f6574b9c89508f89caa43 Reviewed-on: https://review.gerrithub.io/428876 Reviewed-by: Maciej Szwed <maciej.szwed@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-11 07:28:23 +00:00
CU_ASSERT(spdk_nvmf_ctrlr_identify_ns(&ctrlr, &cmd, &rsp,
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
&nsdata) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.status.sc == SPDK_NVME_SC_INVALID_NAMESPACE_OR_FORMAT);
CU_ASSERT(spdk_mem_all_zero(&nsdata, sizeof(nsdata)));
}
UT/nvmf: add reservation filter check Unit test Change-Id: I16136f9a622c23dc232629981110a1ff07593035 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448346 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-03-19 10:05:38 +00:00
/*
* Reservation Unit Test Configuration
* -------- -------- --------
* | Host A | | Host B | | Host C |
* -------- -------- --------
* / \ | |
* -------- -------- ------- -------
* |Ctrlr1_A| |Ctrlr2_A| |Ctrlr_B| |Ctrlr_C|
* -------- -------- ------- -------
* \ \ / /
* \ \ / /
* \ \ / /
* --------------------------------------
* | NAMESPACE 1 |
* --------------------------------------
*/
static struct spdk_nvmf_ctrlr g_ctrlr1_A, g_ctrlr2_A, g_ctrlr_B, g_ctrlr_C;
struct spdk_nvmf_subsystem_pg_ns_info g_ns_info;
static void
ut_reservation_init(enum spdk_nvme_reservation_type rtype)
{
/* Host A has two controllers */
spdk_uuid_generate(&g_ctrlr1_A.hostid);
spdk_uuid_copy(&g_ctrlr2_A.hostid, &g_ctrlr1_A.hostid);
/* Host B has 1 controller */
spdk_uuid_generate(&g_ctrlr_B.hostid);
/* Host C has 1 controller */
spdk_uuid_generate(&g_ctrlr_C.hostid);
memset(&g_ns_info, 0, sizeof(g_ns_info));
g_ns_info.rtype = rtype;
g_ns_info.reg_hostid[0] = g_ctrlr1_A.hostid;
g_ns_info.reg_hostid[1] = g_ctrlr_B.hostid;
g_ns_info.reg_hostid[2] = g_ctrlr_C.hostid;
}
static void
test_reservation_write_exclusive(void)
{
struct spdk_nvmf_request req = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
int rc;
req.cmd = &cmd;
req.rsp = &rsp;
/* Host A holds reservation with type SPDK_NVME_RESERVE_WRITE_EXCLUSIVE */
ut_reservation_init(SPDK_NVME_RESERVE_WRITE_EXCLUSIVE);
g_ns_info.holder_id = g_ctrlr1_A.hostid;
/* Test Case: Issue a Read command from Host A and Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr1_A, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
/* Test Case: Issue a DSM Write command from Host A and Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_DATASET_MANAGEMENT;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr1_A, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
/* Test Case: Issue a Write command from Host C */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_WRITE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
/* Test Case: Issue a Read command from Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
/* Unregister Host C */
memset(&g_ns_info.reg_hostid[2], 0, sizeof(struct spdk_uuid));
/* Test Case: Read and Write commands from non-registrant Host C */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_WRITE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
}
static void
test_reservation_exclusive_access(void)
{
struct spdk_nvmf_request req = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
int rc;
req.cmd = &cmd;
req.rsp = &rsp;
/* Host A holds reservation with type SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS */
ut_reservation_init(SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS);
g_ns_info.holder_id = g_ctrlr1_A.hostid;
/* Test Case: Issue a Read command from Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
/* Test Case: Issue a Reservation Release command from a valid Registrant */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_RESERVATION_RELEASE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
}
static void
_test_reservation_write_exclusive_regs_only_and_all_regs(enum spdk_nvme_reservation_type rtype)
{
struct spdk_nvmf_request req = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
int rc;
req.cmd = &cmd;
req.rsp = &rsp;
/* SPDK_NVME_RESERVE_WRITE_EXCLUSIVE_REG_ONLY and SPDK_NVME_RESERVE_WRITE_EXCLUSIVE_ALL_REGS */
ut_reservation_init(rtype);
g_ns_info.holder_id = g_ctrlr1_A.hostid;
/* Test Case: Issue a Read command from Host A and Host C */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr1_A, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
/* Test Case: Issue a DSM Write command from Host A and Host C */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_DATASET_MANAGEMENT;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr1_A, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
/* Unregister Host C */
memset(&g_ns_info.reg_hostid[2], 0, sizeof(struct spdk_uuid));
/* Test Case: Read and Write commands from non-registrant Host C */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
cmd.nvme_cmd.opc = SPDK_NVME_OPC_WRITE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_C, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
}
static void
test_reservation_write_exclusive_regs_only_and_all_regs(void)
{
_test_reservation_write_exclusive_regs_only_and_all_regs(
SPDK_NVME_RESERVE_WRITE_EXCLUSIVE_REG_ONLY);
_test_reservation_write_exclusive_regs_only_and_all_regs(
SPDK_NVME_RESERVE_WRITE_EXCLUSIVE_ALL_REGS);
}
static void
_test_reservation_exclusive_access_regs_only_and_all_regs(enum spdk_nvme_reservation_type rtype)
{
struct spdk_nvmf_request req = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
int rc;
req.cmd = &cmd;
req.rsp = &rsp;
/* SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS_REG_ONLY and SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS_ALL_REGS */
ut_reservation_init(rtype);
g_ns_info.holder_id = g_ctrlr1_A.hostid;
/* Test Case: Issue a Write command from Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_WRITE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc == 0);
/* Unregister Host B */
memset(&g_ns_info.reg_hostid[1], 0, sizeof(struct spdk_uuid));
/* Test Case: Issue a Read command from Host B */
cmd.nvme_cmd.opc = SPDK_NVME_OPC_READ;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
cmd.nvme_cmd.opc = SPDK_NVME_OPC_WRITE;
rc = nvmf_ns_reservation_request_check(&g_ns_info, &g_ctrlr_B, &req);
SPDK_CU_ASSERT_FATAL(rc < 0);
SPDK_CU_ASSERT_FATAL(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_RESERVATION_CONFLICT);
}
static void
test_reservation_exclusive_access_regs_only_and_all_regs(void)
{
_test_reservation_exclusive_access_regs_only_and_all_regs(
SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS_REG_ONLY);
_test_reservation_exclusive_access_regs_only_and_all_regs(
SPDK_NVME_RESERVE_EXCLUSIVE_ACCESS_ALL_REGS);
}
UT/nvmf: add controller reservation notification log unit tests Change-Id: I98dba9998e412db101437e9276648dac6eba2de5 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450490 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-04-08 06:43:10 +00:00
static void
test_reservation_notification_log_page(void)
{
struct spdk_nvmf_ctrlr ctrlr;
struct spdk_nvmf_qpair qpair;
struct spdk_nvmf_ns ns;
struct spdk_nvmf_request req;
union nvmf_h2c_msg cmd;
union nvmf_c2h_msg rsp;
union spdk_nvme_async_event_completion event = {0};
struct spdk_nvme_reservation_notification_log logs[3];
memset(&ctrlr, 0, sizeof(ctrlr));
ctrlr.thread = spdk_get_thread();
TAILQ_INIT(&ctrlr.log_head);
ns.nsid = 1;
/* Test Case: Mask all the reservation notifications */
ns.mask = SPDK_NVME_REGISTRATION_PREEMPTED_MASK |
SPDK_NVME_RESERVATION_RELEASED_MASK |
SPDK_NVME_RESERVATION_PREEMPTED_MASK;
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_REGISTRATION_PREEMPTED);
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_RESERVATION_RELEASED);
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_RESERVATION_PREEMPTED);
poll_threads();
SPDK_CU_ASSERT_FATAL(TAILQ_EMPTY(&ctrlr.log_head));
/* Test Case: Unmask all the reservation notifications,
* 3 log pages are generated, and AER was triggered.
*/
ns.mask = 0;
ctrlr.num_avail_log_pages = 0;
req.cmd = &cmd;
req.rsp = &rsp;
ctrlr.aer_req = &req;
req.qpair = &qpair;
TAILQ_INIT(&qpair.outstanding);
qpair.state = SPDK_NVMF_QPAIR_ACTIVE;
TAILQ_INSERT_TAIL(&qpair.outstanding, &req, link);
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_REGISTRATION_PREEMPTED);
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_RESERVATION_RELEASED);
spdk_nvmf_ctrlr_reservation_notice_log(&ctrlr, &ns,
SPDK_NVME_RESERVATION_PREEMPTED);
poll_threads();
event.raw = rsp.nvme_cpl.cdw0;
SPDK_CU_ASSERT_FATAL(event.bits.async_event_type == SPDK_NVME_ASYNC_EVENT_TYPE_IO);
SPDK_CU_ASSERT_FATAL(event.bits.async_event_info == SPDK_NVME_ASYNC_EVENT_RESERVATION_LOG_AVAIL);
SPDK_CU_ASSERT_FATAL(event.bits.log_page_identifier == SPDK_NVME_LOG_RESERVATION_NOTIFICATION);
SPDK_CU_ASSERT_FATAL(ctrlr.num_avail_log_pages == 3);
/* Test Case: Get Log Page to clear the log pages */
spdk_nvmf_get_reservation_notification_log_page(&ctrlr, (void *)logs, 0, sizeof(logs));
SPDK_CU_ASSERT_FATAL(ctrlr.num_avail_log_pages == 0);
}
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
int main(int argc, char **argv)
{
CU_pSuite suite = NULL;
unsigned int num_failures;
if (CU_initialize_registry() != CUE_SUCCESS) {
return CU_get_error();
}
suite = CU_add_suite("nvmf", NULL, NULL);
if (suite == NULL) {
CU_cleanup_registry();
return CU_get_error();
}
if (
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
CU_add_test(suite, "get_log_page", test_get_log_page) == NULL ||
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_add_test(suite, "process_fabrics_cmd", test_process_fabrics_cmd) == NULL ||
nvmf: implement NS Identification Descriptor list Currently, this just reports the EUI64 and NGUID types, which are already available in the Identify Namespace data, but this sets up the framework for reporting a Namespace UUID (which doesn't have a corresponding field in Identify Namespace) in the future. Change-Id: I758e6d402ff874d65eca3f1db98d92c1a3f7a11f Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/400893 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-02-21 23:10:39 +00:00
CU_add_test(suite, "connect", test_connect) == NULL ||
nvmf: fix Identify Namespace for inactive NSIDs The NVMe spec says that Identify Namespace should return a zero filled data structure for namespaces that aren't active, rather than failing the command with a status code of Invalid Namespace or Format. Change-Id: Ia9156477d8701694f8b295a67e1669fd09e2cb62 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/412872 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-05-29 21:33:37 +00:00
CU_add_test(suite, "get_ns_id_desc_list", test_get_ns_id_desc_list) == NULL ||
UT/nvmf: add reservation filter check Unit test Change-Id: I16136f9a622c23dc232629981110a1ff07593035 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448346 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-03-19 10:05:38 +00:00
CU_add_test(suite, "identify_ns", test_identify_ns) == NULL ||
CU_add_test(suite, "reservation_write_exclusive", test_reservation_write_exclusive) == NULL ||
CU_add_test(suite, "reservation_exclusive_access", test_reservation_exclusive_access) == NULL ||
CU_add_test(suite, "reservation_write_exclusive_regs_only_and_all_regs",
test_reservation_write_exclusive_regs_only_and_all_regs) == NULL ||
CU_add_test(suite, "reservation_exclusive_access_regs_only_and_all_regs",
UT/nvmf: add controller reservation notification log unit tests Change-Id: I98dba9998e412db101437e9276648dac6eba2de5 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450490 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-04-08 06:43:10 +00:00
test_reservation_exclusive_access_regs_only_and_all_regs) == NULL ||
CU_add_test(suite, "reservation_notification_log_page",
test_reservation_notification_log_page) == NULL
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
) {
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
CU_cleanup_registry();
return CU_get_error();
}
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
allocate_threads(1);
set_thread(0);
test/nvmf: Simplify thread handling in ctrlr_ut Change-Id: Ic804ad99a28b3ba03b67c1733e46f280e0ad9cb8 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/433681 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-16 21:49:20 +00:00
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
test/nvmf: Simplify thread handling in ctrlr_ut Change-Id: Ic804ad99a28b3ba03b67c1733e46f280e0ad9cb8 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/433681 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-16 21:49:20 +00:00
test: Use ut_multithread framework in nvmf/ctrlr Change-Id: I497abe0996287203f4b99850202a23f35d360f5e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/422467 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-08-15 21:00:05 +00:00
free_threads();
test/nvmf: Simplify thread handling in ctrlr_ut Change-Id: Ic804ad99a28b3ba03b67c1733e46f280e0ad9cb8 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/433681 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-11-16 21:49:20 +00:00
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
return num_failures;
}
Reference in New Issue Copy Permalink