ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
526cd58003
Spdk/test/unit/lib/nvmf/ctrlr.c/ctrlr_ut.c

559 lines
20 KiB
C
Raw Normal View History

test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
/*-
* BSD LICENSE
*
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
include: Move the remainder of the code base to stdinc.h Change-Id: I6a142feeaad3117bd3c75e7c5cb7231a1cfa78ae Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2017-05-02 18:18:25 +00:00
#include "spdk/stdinc.h"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
#include "spdk_cunit.h"
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
#include "spdk_internal/mock.h"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
test: use spdk.unittest.mk for nvmf unit tests This includes removing the nvmf.unittest.mk that these unit tests were using previously. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I3b53db0a565aee910587826b37e8b43d6a324e75 Reviewed-on: https://review.gerrithub.io/399724 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-02-13 15:24:28 +00:00
#include "nvmf/ctrlr.c"
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
log: rename SPDK_TRACE_* to SPDK_LOG_* Disambiguate the log components from the trace functionality (include/spdk/trace.h). The internal spdk_trace_flag structure and related functions will be renamed in a later commit - this is just a find and replace on SPDK_TRACE_* and SPDK_LOG_REGISTER_TRACE_FLAG(). Change-Id: I617bd5a9fbe35ffb44ae6020b292658c094a0ad6 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/376421 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-08-30 18:06:33 +00:00
SPDK_LOG_REGISTER_COMPONENT("nvmf", SPDK_LOG_NVMF)
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
nvmf: refactor controller creation Simplify the initialization of controller identify data and properties. This is mostly common between discovery and NVM subsystems. Change-Id: Id8074d5260213e32892fd77845884a80071c9d88 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/374534 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-16 21:03:42 +00:00
ut/nvmf/ctrlr: replace stubs with mock.h macros Change-Id: Ifd00dd647002ea226df826c558232d97d366ab81 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390660 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:18:25 +00:00
DEFINE_STUB(spdk_nvmf_tgt_find_subsystem,
struct spdk_nvmf_subsystem *,
(struct spdk_nvmf_tgt *tgt, const char *subnqn),
NULL)
DEFINE_STUB(spdk_nvmf_poll_group_create,
struct spdk_nvmf_poll_group *,
(struct spdk_nvmf_tgt *tgt),
NULL)
DEFINE_STUB_V(spdk_nvmf_poll_group_destroy,
(struct spdk_nvmf_poll_group *group))
DEFINE_STUB_V(spdk_nvmf_transport_qpair_fini,
(struct spdk_nvmf_qpair *qpair))
DEFINE_STUB(spdk_nvmf_poll_group_add,
int,
(struct spdk_nvmf_poll_group *group, struct spdk_nvmf_qpair *qpair),
0)
DEFINE_STUB(spdk_nvmf_poll_group_remove,
int,
(struct spdk_nvmf_poll_group *group, struct spdk_nvmf_qpair *qpair),
0)
DEFINE_STUB(spdk_nvmf_subsystem_get_sn,
const char *,
(const struct spdk_nvmf_subsystem *subsystem),
NULL)
DEFINE_STUB(spdk_nvmf_subsystem_get_ns,
struct spdk_nvmf_ns *,
(struct spdk_nvmf_subsystem *subsystem, uint32_t nsid),
NULL)
DEFINE_STUB(spdk_nvmf_subsystem_get_first_ns,
struct spdk_nvmf_ns *,
(struct spdk_nvmf_subsystem *subsystem),
NULL)
DEFINE_STUB(spdk_nvmf_subsystem_get_next_ns,
struct spdk_nvmf_ns *,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ns *prev_ns),
NULL)
DEFINE_STUB(spdk_nvmf_subsystem_host_allowed,
bool,
(struct spdk_nvmf_subsystem *subsystem, const char *hostnqn),
true)
DEFINE_STUB(spdk_nvmf_subsystem_add_ctrlr,
int,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr),
0)
DEFINE_STUB_V(spdk_nvmf_subsystem_remove_ctrlr,
(struct spdk_nvmf_subsystem *subsystem, struct spdk_nvmf_ctrlr *ctrlr))
DEFINE_STUB(spdk_nvmf_subsystem_get_ctrlr,
struct spdk_nvmf_ctrlr *,
(struct spdk_nvmf_subsystem *subsystem, uint16_t cntlid),
NULL)
DEFINE_STUB(spdk_nvmf_ctrlr_dsm_supported,
bool,
(struct spdk_nvmf_ctrlr *ctrlr),
false)
DEFINE_STUB(spdk_nvmf_ctrlr_write_zeroes_supported,
bool,
(struct spdk_nvmf_ctrlr *ctrlr),
false)
DEFINE_STUB(spdk_nvmf_bdev_ctrlr_identify_ns,
int,
(struct spdk_bdev *bdev, struct spdk_nvme_ns_data *nsdata),
-1)
DEFINE_STUB_V(spdk_nvmf_get_discovery_log_page,
(struct spdk_nvmf_tgt *tgt, void *buffer, uint64_t offset, uint32_t length))
DEFINE_STUB(spdk_nvmf_request_complete,
int,
(struct spdk_nvmf_request *req),
-1)
DEFINE_STUB(spdk_nvmf_request_abort,
int,
(struct spdk_nvmf_request *req),
-1)
nvmf: move admin processing to ctrlr.c Now that the discovery controller is using the common admin command functions, move all of them into the common ctrlr.c file. This also eliminates the subsystem ops, which are now just direct calls. Change-Id: I0a25a61e0ad8742d3d76a3cacd46db4701fc7d63 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/374733 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-17 23:28:00 +00:00
nvmf: refactor get_log_page into a common function Both regular NVM controllers and discovery controllers implement the Get Log Page command; combine the implementations into one in ctrlr.c. Change-Id: I7fabf40ec52d8738263ac152afe9cd7773ff7fbd Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/374555 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-08-17 01:13:49 +00:00
static void
test_get_log_page(void)
{
struct spdk_nvmf_subsystem subsystem = {};
struct spdk_nvmf_request req = {};
struct spdk_nvmf_qpair qpair = {};
struct spdk_nvmf_ctrlr ctrlr = {};
union nvmf_h2c_msg cmd = {};
union nvmf_c2h_msg rsp = {};
char data[4096];
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
ctrlr.subsys = &subsystem;
qpair.ctrlr = &ctrlr;
req.qpair = &qpair;
req.cmd = &cmd;
req.rsp = &rsp;
req.data = &data;
req.length = sizeof(data);
/* Get Log Page - all valid */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_SUCCESS);
/* Get Log Page with invalid log ID */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = 0;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
/* Get Log Page with invalid offset (not dword aligned) */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
cmd.nvme_cmd.cdw12 = 2;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
/* Get Log Page without data buffer */
memset(&cmd, 0, sizeof(cmd));
memset(&rsp, 0, sizeof(rsp));
req.data = NULL;
cmd.nvme_cmd.opc = SPDK_NVME_OPC_GET_LOG_PAGE;
cmd.nvme_cmd.cdw10 = SPDK_NVME_LOG_ERROR | (req.length / 4 - 1) << 16;
CU_ASSERT(spdk_nvmf_ctrlr_get_log_page(&req) == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(req.rsp->nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(req.rsp->nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
req.data = data;
}
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
static void
test_process_fabrics_cmd(void)
{
struct spdk_nvmf_request req = {};
int ret;
struct spdk_nvmf_qpair req_qpair = {};
union nvmf_h2c_msg req_cmd = {};
union nvmf_c2h_msg req_rsp = {};
req.qpair = &req_qpair;
req.cmd = &req_cmd;
req.rsp = &req_rsp;
req.qpair->ctrlr = NULL;
/* No ctrlr and invalid command check */
req.cmd->nvmf_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_PROPERTY_GET;
ret = spdk_nvmf_ctrlr_process_fabrics_cmd(&req);
CU_ASSERT_EQUAL(req.rsp->nvme_cpl.status.sc, SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR);
CU_ASSERT_EQUAL(ret, SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
}
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
static bool
nvme_status_success(const struct spdk_nvme_status *status)
{
return status->sct == SPDK_NVME_SCT_GENERIC && status->sc == SPDK_NVME_SC_SUCCESS;
}
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
void
spdk_thread_send_msg(const struct spdk_thread *thread, spdk_thread_fn fn, void *ctx)
{
fn(ctx);
}
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
static void
test_connect(void)
{
struct spdk_nvmf_fabric_connect_data connect_data;
struct spdk_nvmf_poll_group group;
struct spdk_nvmf_transport transport;
struct spdk_nvmf_subsystem subsystem;
struct spdk_nvmf_request req;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
struct spdk_nvmf_qpair admin_qpair;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
struct spdk_nvmf_qpair qpair;
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
struct spdk_nvmf_qpair qpair2;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
struct spdk_nvmf_ctrlr ctrlr;
struct spdk_nvmf_tgt tgt;
union nvmf_h2c_msg cmd;
union nvmf_c2h_msg rsp;
const uint8_t hostid[16] = {
0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F
};
const char subnqn[] = "nqn.2016-06.io.spdk:subsystem1";
const char hostnqn[] = "nqn.2016-06.io.spdk:host1";
int rc;
memset(&group, 0, sizeof(group));
memset(&ctrlr, 0, sizeof(ctrlr));
TAILQ_INIT(&ctrlr.qpairs);
ctrlr.subsys = &subsystem;
ctrlr.vcprop.cc.bits.en = 1;
ctrlr.vcprop.cc.bits.iosqes = 6;
ctrlr.vcprop.cc.bits.iocqes = 4;
ctrlr.max_qpairs_allowed = 3;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
memset(&admin_qpair, 0, sizeof(admin_qpair));
TAILQ_INSERT_TAIL(&ctrlr.qpairs, &admin_qpair, link);
admin_qpair.group = &group;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&tgt, 0, sizeof(tgt));
tgt.opts.max_queue_depth = 64;
tgt.opts.max_qpairs_per_ctrlr = 3;
memset(&transport, 0, sizeof(transport));
transport.tgt = &tgt;
memset(&qpair, 0, sizeof(qpair));
qpair.transport = &transport;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
qpair.group = &group;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
memset(&connect_data, 0, sizeof(connect_data));
memcpy(connect_data.hostid, hostid, sizeof(hostid));
connect_data.cntlid = 0xFFFF;
strncpy(connect_data.subnqn, subnqn, sizeof(connect_data.subnqn));
strncpy(connect_data.hostnqn, hostnqn, sizeof(connect_data.hostnqn));
memset(&subsystem, 0, sizeof(subsystem));
subsystem.id = 1;
TAILQ_INIT(&subsystem.ctrlrs);
subsystem.tgt = &tgt;
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
snprintf(subsystem.subnqn, sizeof(subsystem.subnqn), "%s", subnqn);
memset(&cmd, 0, sizeof(cmd));
cmd.connect_cmd.opcode = SPDK_NVME_OPC_FABRIC;
cmd.connect_cmd.cid = 1;
cmd.connect_cmd.fctype = SPDK_NVMF_FABRIC_COMMAND_CONNECT;
cmd.connect_cmd.recfmt = 0;
cmd.connect_cmd.qid = 0;
cmd.connect_cmd.sqsize = 31;
cmd.connect_cmd.cattr = 0;
cmd.connect_cmd.kato = 120000;
memset(&req, 0, sizeof(req));
req.qpair = &qpair;
req.length = sizeof(connect_data);
req.xfer = SPDK_NVME_DATA_HOST_TO_CONTROLLER;
req.data = &connect_data;
req.cmd = &cmd;
req.rsp = &rsp;
MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, &subsystem);
MOCK_SET(spdk_nvmf_poll_group_create, struct spdk_nvmf_poll_group *, &group);
/* Valid admin connect command */
memset(&rsp, 0, sizeof(rsp));
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
CU_ASSERT(qpair.ctrlr != NULL);
free(qpair.ctrlr);
qpair.ctrlr = NULL;
/* Invalid data length */
memset(&rsp, 0, sizeof(rsp));
req.length = sizeof(connect_data) - 1;
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_INVALID_FIELD);
CU_ASSERT(qpair.ctrlr == NULL);
req.length = sizeof(connect_data);
/* Invalid recfmt */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.recfmt = 1234;
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INCOMPATIBLE_FORMAT);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.recfmt = 0;
/* Unterminated subnqn */
memset(&rsp, 0, sizeof(rsp));
memset(connect_data.subnqn, 'a', sizeof(connect_data.subnqn));
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256);
CU_ASSERT(qpair.ctrlr == NULL);
strncpy(connect_data.subnqn, subnqn, sizeof(connect_data.subnqn));
/* Subsystem not found */
memset(&rsp, 0, sizeof(rsp));
MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, NULL);
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 256);
CU_ASSERT(qpair.ctrlr == NULL);
MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, &subsystem);
/* Unterminated hostnqn */
memset(&rsp, 0, sizeof(rsp));
memset(connect_data.hostnqn, 'b', sizeof(connect_data.hostnqn));
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 512);
CU_ASSERT(qpair.ctrlr == NULL);
strncpy(connect_data.hostnqn, hostnqn, sizeof(connect_data.hostnqn));
/* Host not allowed */
memset(&rsp, 0, sizeof(rsp));
MOCK_SET(spdk_nvmf_subsystem_host_allowed, bool, false);
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_HOST);
CU_ASSERT(qpair.ctrlr == NULL);
MOCK_SET(spdk_nvmf_subsystem_host_allowed, bool, true);
/* Invalid sqsize == 0 */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.sqsize = 0;
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.sqsize = 31;
/* Invalid sqsize > max_queue_depth */
memset(&rsp, 0, sizeof(rsp));
cmd.connect_cmd.sqsize = 64;
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 44);
CU_ASSERT(qpair.ctrlr == NULL);
cmd.connect_cmd.sqsize = 31;
/* Invalid cntlid for admin queue */
memset(&rsp, 0, sizeof(rsp));
connect_data.cntlid = 0x1234;
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16);
CU_ASSERT(qpair.ctrlr == NULL);
connect_data.cntlid = 0xFFFF;
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
ctrlr.admin_qpair = &admin_qpair;
ctrlr.subsys = &subsystem;
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Valid I/O queue connect command */
memset(&rsp, 0, sizeof(rsp));
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, &ctrlr);
cmd.connect_cmd.qid = 1;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(nvme_status_success(&rsp.nvme_cpl.status));
CU_ASSERT(qpair.ctrlr == &ctrlr);
qpair.ctrlr = NULL;
ctrlr.num_qpairs = 0;
TAILQ_INIT(&ctrlr.qpairs);
/* Non-existent controller */
memset(&rsp, 0, sizeof(rsp));
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, NULL);
rc = spdk_nvmf_ctrlr_connect(&req);
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_COMPLETE);
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 1);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 16);
CU_ASSERT(qpair.ctrlr == NULL);
MOCK_SET(spdk_nvmf_subsystem_get_ctrlr, struct spdk_nvmf_ctrlr *, &ctrlr);
/* I/O connect to discovery controller */
memset(&rsp, 0, sizeof(rsp));
subsystem.subtype = SPDK_NVMF_SUBTYPE_DISCOVERY;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
subsystem.subtype = SPDK_NVMF_SUBTYPE_NVME;
/* I/O connect to disabled controller */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.en = 0;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.en = 1;
/* I/O connect with invalid IOSQES */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.iosqes = 3;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.iosqes = 6;
/* I/O connect with invalid IOCQES */
memset(&rsp, 0, sizeof(rsp));
ctrlr.vcprop.cc.bits.iocqes = 3;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_INVALID_PARAM);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.iattr == 0);
CU_ASSERT(rsp.connect_rsp.status_code_specific.invalid.ipo == 42);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.vcprop.cc.bits.iocqes = 4;
/* I/O connect with too many existing qpairs */
memset(&rsp, 0, sizeof(rsp));
ctrlr.num_qpairs = 3;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_COMMAND_SPECIFIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVMF_FABRIC_SC_CONTROLLER_BUSY);
CU_ASSERT(qpair.ctrlr == NULL);
ctrlr.num_qpairs = 0;
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
/* I/O connect with duplicate queue ID */
memset(&rsp, 0, sizeof(rsp));
memset(&qpair2, 0, sizeof(qpair2));
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
qpair2.group = &group;
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
qpair2.qid = 1;
TAILQ_INSERT_TAIL(&ctrlr.qpairs, &qpair, link);
cmd.connect_cmd.qid = 1;
rc = spdk_nvmf_ctrlr_connect(&req);
nvmf: Solve the coredump issue when client conduct `nvme disconnect` This patch is used to solve https://github.com/spdk/spdk/issues/235 With multiple core bining for NVMe-oF target, the qpairs which belonging to the same ctrlr may be scheduled to different cores. Thus there is resource contention to access the struct spdk_nvmf_ctrlr. And we put the thread info in polling group. Morever, we introduce an admin_qpair in ctrlr. Since admin_qpair will always be created at first and freed at last, to reference this pointer is safe. Change-Id: I12ac26f9e65b4ed8e48687750046455af0e3be1d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/398904 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-08 03:54:59 +00:00
CU_ASSERT(rc == SPDK_NVMF_REQUEST_EXEC_STATUS_ASYNCHRONOUS);
nvmf: add duplicate QID check in I/O Connect Disallow multiple I/O queues for the same controller with the same queue ID. NVMe-oF 1.0 ECN 001 specifies that this condition should return a status value of Command Sequence Error. Change-Id: I41126ddec388a985c403025e099ab15da5d3987c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390662 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:50 +00:00
CU_ASSERT(rsp.nvme_cpl.status.sct == SPDK_NVME_SCT_GENERIC);
CU_ASSERT(rsp.nvme_cpl.status.sc == SPDK_NVME_SC_COMMAND_SEQUENCE_ERROR);
CU_ASSERT(qpair.ctrlr == NULL);
TAILQ_INIT(&ctrlr.qpairs);
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
/* Clean up globals */
MOCK_SET(spdk_nvmf_tgt_find_subsystem, struct spdk_nvmf_subsystem *, NULL);
MOCK_SET(spdk_nvmf_poll_group_create, struct spdk_nvmf_poll_group *, NULL);
}
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
int main(int argc, char **argv)
{
CU_pSuite suite = NULL;
unsigned int num_failures;
if (CU_initialize_registry() != CUE_SUCCESS) {
return CU_get_error();
}
suite = CU_add_suite("nvmf", NULL, NULL);
if (suite == NULL) {
CU_cleanup_registry();
return CU_get_error();
}
if (
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
CU_add_test(suite, "get_log_page", test_get_log_page) == NULL ||
ut/nvmf/ctrlr: add Connect command unit tests Change-Id: I4d3cced91e804fbbb96a15a09b575ff85960ddef Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/390661 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-06 18:19:08 +00:00
CU_add_test(suite, "process_fabrics_cmd", test_process_fabrics_cmd) == NULL ||
CU_add_test(suite, "connect", test_connect) == NULL
nvmf: move fabrics command processing to ctrlr.c This is the final set of command processing functions (admin and I/O commands were already handled in ctrlr.c), and it allows us to clean up the ctrlr.c API some more. Change-Id: Ic73c56c44d7fd64bfaa72b6f5f6f0984b4dfa053 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/378018 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-09-12 01:54:56 +00:00
) {
test/nvmf: stub out per-file unit tests Change-Id: I9606b82dbfaa6c84d8dafc07fb76a113e3436083 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-21 22:08:23 +00:00
CU_cleanup_registry();
return CU_get_error();
}
CU_basic_set_mode(CU_BRM_VERBOSE);
CU_basic_run_tests();
num_failures = CU_get_number_of_failures();
CU_cleanup_registry();
return num_failures;
}
Reference in New Issue Copy Permalink