ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4a4c905b32
Spdk/lib/ftl/utils/ftl_log.h

32 lines
881 B
C
Raw Normal View History

ftl: utils Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Signed-off-by: Kozlowski Mateusz <mateusz.kozlowski@intel.com> Change-Id: I3476a7b11e3078da519beb39fd5f49b8e838a238 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13409 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
2022-06-22 12:01:59 +00:00
/* SPDX-License-Identifier: BSD-3-Clause
update Intel copyright notices per Intel policy to include file commit date using git cmd below. The policy does not apply to non-Intel (C) notices. git log --follow -C90% --format=%ad --date default <file> | tail -1 and then pull just the 4 digit year from the result. Intel copyrights were not added to files where Intel either had no contribution ot the contribution lacked substance (ie license header updates, formatting changes, etc). Contribution date used "--follow -C95%" to get the most accurate date. Note that several files in this patch didn't end the license/(c) block with a blank comment line so these were added as the vast majority of files do have this last blank line. Simply there for consistency. Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: Id5b7ce4f658fe87132f14139ead58d6e285c04d4 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15192 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
2022-11-01 20:26:26 +00:00
* Copyright (C) 2022 Intel Corporation.
ftl: utils Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Signed-off-by: Kozlowski Mateusz <mateusz.kozlowski@intel.com> Change-Id: I3476a7b11e3078da519beb39fd5f49b8e838a238 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13409 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
2022-06-22 12:01:59 +00:00
* All rights reserved.
*/
#ifndef FTL_LOG_H
#define FTL_LOG_H
#include "spdk/stdinc.h"
#include "spdk/log.h"
#define FTL_LOG_COMMON(type, dev, format, ...) \
ftl: fix FTL_LOG_COMMON to avoid annoying gcc-12 warnings gcc-12 is really tricky. It detected that in ftl_nv_cache_load_state() that when we do an FTL_NOTICELOG, the dev and nv_cache values are associated with each other by the SPDK_CONTAINEROF() operation. So then in FTL_LOG_COMMON, it checks if dev is NULL. If it is, it doesn't print the dev->conf.name, but still prints the varargs which include nv_cache members. But if dev is NULL then these nv_cache members wouldn't be valid either, and that's what gcc-12 is complaining about, in a very unclear way. So now we just have FTL_LOG_COMMON contain a single line, with a tertiary operator to print either dev->conf.name or "N/A" depending on whether dev is NULL or not. I suspect this fixes it because we've replaced the if statement with a tertiary operator that is independent from the VA_ARGS. Fixes issue #2829 (partially). Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ia56e2c7fb7966e7a5ceff35b36b0346b556ce7e7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16342 Reviewed-by: <sebastian.brzezinka@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2023-01-18 20:14:00 +00:00
spdk_log(SPDK_LOG_##type, __FILE__, __LINE__, __func__, "[FTL][%s] "format, \
(dev) != NULL ? (dev)->conf.name : "N/A", ## __VA_ARGS__)
ftl: utils Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Signed-off-by: Kozlowski Mateusz <mateusz.kozlowski@intel.com> Change-Id: I3476a7b11e3078da519beb39fd5f49b8e838a238 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13409 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
2022-06-22 12:01:59 +00:00
#define FTL_ERRLOG(dev, format, ...) \
FTL_LOG_COMMON(ERROR, dev, format, ## __VA_ARGS__)
#define FTL_WARNLOG(dev, format, ...) \
FTL_LOG_COMMON(WARN, dev, format, ## __VA_ARGS__)
#define FTL_NOTICELOG(dev, format, ...) \
FTL_LOG_COMMON(NOTICE, dev, format, ## __VA_ARGS__)
#define FTL_INFOLOG(dev, format, ...) \
FTL_LOG_COMMON(INFO, dev, format, ## __VA_ARGS__)
#define FTL_DEBUGLOG(dev, format, ...) \
FTL_LOG_COMMON(DEBUG, dev, format, ## __VA_ARGS__)
#endif /* FTL_LOG_H */
Reference in New Issue Copy Permalink