ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
0951fc4fea
Spdk/lib/iscsi/conn.h

218 lines
7.4 KiB
C
Raw Normal View History

iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/*-
* BSD LICENSE
*
* Copyright (C) 2008-2012 Daisuke Aoyama <aoyama@peach.ne.jp>.
* Copyright (c) Intel Corporation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* * Neither the name of Intel Corporation nor the names of its
* contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#ifndef SPDK_ISCSI_CONN_H
#define SPDK_ISCSI_CONN_H
include: Move the remainder of the code base to stdinc.h Change-Id: I6a142feeaad3117bd3c75e7c5cb7231a1cfa78ae Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2017-05-02 18:18:25 +00:00
#include "spdk/stdinc.h"
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
#include "iscsi/iscsi.h"
#include "spdk/queue.h"
util: extend cpumask to hold more than 64 cpus Fixes github issue #218. This patch introduces spdk_cpuset object to store and manipulate the set of individual CPUs. The main objective of this object is to replace cpumask declared as uint64_t and extend the limitation of supported CPUs (lcores) above 64 CPUs. spdk_cpuset is always allocated dynamically and accessed by opaque pointer, what makes it easier to extend in the future without breaking API/ABI. This patch also extends parsing function allowing to set cpumask using a list of cpus e.g. "[0-4,10,12]" sets mask of 0,1,2,3,4,10,12 as well as hexadecimal string with and without "0x" prefix. Change-Id: I475c3ba7fab629021a22e03176e57e400dd24a49 Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> Reviewed-on: https://review.gerrithub.io/390794 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-12-21 16:48:31 +00:00
#include "spdk/cpuset.h"
iscsi: Support hot removal of LUN based on LUN open/close When hot removal of a LUN is started, callback is called for each iSCSI connection which accesses the LUN. Callback checks all transfer tasks complete and then close the LUN. If the connection clears all transfer tasks before getting all responses to them from the initiator, the initiator continues to retry data write. Hence the connection have to wait until all transfer tasks complete. Change-Id: Iad9063673cfedbd78758890d55a4254512e4fca4 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/417199 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-07-04 05:23:55 +00:00
#include "spdk/scsi.h"
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/*
* MAX_CONNECTION_PARAMS: The numbers of the params in conn_param_table
* MAX_SESSION_PARAMS: The numbers of the params in sess_param_table
*/
#define MAX_CONNECTION_PARAMS 14
#define MAX_SESSION_PARAMS 19
#define MAX_ADDRBUF 64
#define MAX_INITIATOR_ADDR (MAX_ADDRBUF)
#define MAX_TARGET_ADDR (MAX_ADDRBUF)
#define OWNER_ISCSI_CONN 0x1
#define OBJECT_ISCSI_PDU 0x1
#define TRACE_GROUP_ISCSI 0x1
iscsi: add iscsi prefix in every tracepoint name Change-Id: I6b074825142a073ab5fbeed0b96092396113a81f Signed-off-by: Liang Yan <liang.z.yan@intel.com> Reviewed-on: https://review.gerrithub.io/425879 Reviewed-by: GangCao <gang.cao@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-09-18 01:28:28 +00:00
#define TRACE_ISCSI_READ_FROM_SOCKET_DONE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x0)
#define TRACE_ISCSI_FLUSH_WRITEBUF_START SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x1)
#define TRACE_ISCSI_FLUSH_WRITEBUF_DONE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x2)
#define TRACE_ISCSI_READ_PDU SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x3)
#define TRACE_ISCSI_TASK_DONE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x4)
#define TRACE_ISCSI_TASK_QUEUE SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x5)
iscsi: update iscsi trace config The following changes are added in this patch: 1. Remove unused TRACE_ISCSI_CONN_ACTIVE and TRACE_ISCSI_CONN_IDLE. 2. TRACE_ISCSI_TASK_EXECUTED is added. This tracepoint can be used to record TSC for every PDU, especially non-SCSI PDU. 3. TRACE_ISCSI_PDU_COMPLETED is added. This tracepoint is for SCSI PDU. It will record the TSC which includes the cycles of flushing writebuf. Change-Id: I277bb2ce57e3cd2fc6fcb25845abdf2c11ed062b Signed-off-by: Liang Yan <liang.z.yan@intel.com> Reviewed-on: https://review.gerrithub.io/425036 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: GangCao <gang.cao@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-09-06 13:01:11 +00:00
#define TRACE_ISCSI_TASK_EXECUTED SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x6)
#define TRACE_ISCSI_PDU_COMPLETED SPDK_TPOINT_ID(TRACE_GROUP_ISCSI, 0x7)
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
lib/iscsi: Introduce state machine into receive PDUs operation Add PDU receive state to each connection, and each connection transits among states during receiving incoming PDUs. Four states, AWAIT_PDU_READY, AWAIT_PDU_HDR, AWAIT_PDU_PAYLOAD, and ERROR are same as SPDK NVMe-TCP target. Move clearing conn->pdu_in_progress just before putting pdu when PDU processing completes normally to match with error case. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id24b6d6662896b5685125a46ee20cbf216668838 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469966 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-10-15 01:37:21 +00:00
enum iscsi_pdu_recv_state {
/* Ready to wait for PDU */
ISCSI_PDU_RECV_STATE_AWAIT_PDU_READY,
/* Active connection waiting for any PDU header */
ISCSI_PDU_RECV_STATE_AWAIT_PDU_HDR,
/* Active connection waiting for payload */
ISCSI_PDU_RECV_STATE_AWAIT_PDU_PAYLOAD,
/* Active connection does not wait for payload */
ISCSI_PDU_RECV_STATE_ERROR,
};
iscsi: Remove nested, duplicated, or unreferenced file inclusion When header files include other header files, it can be difficult to read the chain of relationships. Hence remove obvious nested header inclusion. Remove obvious unreferenced header inclusion too. Change-Id: I13b1c4e107da8c1a93fae4a0e3c3ee273887aab0 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/391363 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-12-13 00:49:12 +00:00
struct spdk_poller;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
struct spdk_iscsi_conn {
int id;
int is_valid;
/*
* All fields below this point are reinitialized each time the
* connection object is allocated. Make sure to update the
* SPDK_ISCSI_CONNECTION_MEMSET() macro if changing which fields
* are initialized when allocated.
*/
iscsi: login poller per portal and portal cache A few foundational change to support safe removal of portal. - global login poller -> login poller per portal - Caching portal data for active connection Change-Id: I62f4d90c9ac11a433ad47421b2b0c69bfc3c70b7 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379930 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-30 04:01:07 +00:00
struct spdk_iscsi_portal *portal;
int pg_tag;
iscsi: Use fixed size string for host and port name of connection This will reduce the potential malloc failure. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Ibcd631bf318ef6ece4ac337219652323ca5fd8f1 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/464136 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-08-08 05:59:30 +00:00
char portal_host[MAX_PORTAL_ADDR + 1];
char portal_port[MAX_PORTAL_ADDR + 1];
iscsi: Assign connections to poll groups instead of lcores. This patch binds poll groups to SPDK thread through IO channel and assigns connections to poll groups instead of cores. iSCSI subsystem registers iSCSI global object as an IO device, and create poll groups as context of IO channels of the IO device. Each portal get and hold portal group on which the corresponding acceptor is running. When a connection is constructed, iSCSI subsystem assigns a poll group to the connection by getting it from the corresponding portal. When a connection enters full-feature phase, iSCSI subsystem schedules the connection to a poll group by round-robin. Then, each connection can know its running SPDK thread directly and can use SPDK message passing infrastructure instead of SPDK event framework. By this change, iSCSI connections are binded to SPDK thread, and not binded to processor core anymore. Some other changes in this patch are - core ID is removed from the output of get_iscsi_connections RPC. The upcoming patches will change the RPC to use spdk_for_each_channel and can access SPDK thread safely, and add SPDK thread ID instead. - utilize UT multithread framework added by the last patch to test iSCSI poll groups by UT. Change-Id: Iec73c778aa413bcabdb63141cc41d4160911ea0e Signed-off-by: Ben Walker <benjamin.walker@intel.com> Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463359 Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-07-30 03:00:15 +00:00
struct spdk_iscsi_poll_group *pg;
net, iscsi: add struct spdk_sock abstraction This provides an abstraction layer around TCP sockets. Previously we just used fd integers, but we don't want to be tied to integers for alternative userspace TCP stacks. Future patches will do more work to enable multiple implementations of this abstraction. For now, just get the abstraction in place for POSIX sockets and make all of the iSCSI changes associated with it. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I9a825e9e02eb6927c8702d205665c626f57b3771 Reviewed-on: https://review.gerrithub.io/398861 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com>
2018-02-07 21:46:22 +00:00
struct spdk_sock *sock;
iscsi: login poller per portal and portal cache A few foundational change to support safe removal of portal. - global login poller -> login poller per portal - Caching portal data for active connection Change-Id: I62f4d90c9ac11a433ad47421b2b0c69bfc3c70b7 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379930 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-09-30 04:01:07 +00:00
struct spdk_iscsi_sess *sess;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
enum iscsi_connection_state state;
int login_phase;
lib/iscsi: Replace ISCSI_CONN_STATE_LOGGED_OUT state by is_logged_out flag The connection state is mainly for flushing PDUs. ISCSI_CONN_STATE_LOGGED_OUT was as same as ISCSI_CONN_STATE_RUNNING for this point. Replace ISCSI_CONN_STATE_LOGGED_OUT state by a is_logged_out flag and use the latter to reject any incoming PDU after sending logout response. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I3426a3ecbd241db402b1a2f7b3914a18e3591591 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470703 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-10-07 22:55:20 +00:00
bool is_logged_out;
lib/iscsi: Separate PDU header and payload handling for Login Request Separate PDU header and payload handling for Login Request PDU. This will clarify the header handling and payload handling. Especially store the allocated and initialized response PDU to the current connection and refer it later. This idea is as same as iSCSI task and will work because login processing is synchronous and only once per connection. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I7e0eb413ee5f759724a685b83a742515a3546780 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/471472 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-10-16 08:38:18 +00:00
struct spdk_iscsi_pdu *login_rsp_pdu;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
uint64_t last_flush;
uint64_t last_fill;
uint64_t last_nopin;
lib/iscsi: Request logout to asynchronously to initiator Request logout to the initiator asynchronously when exiting the running connection from the target. Based on this patch, the next patch will make flushing PDUs possible only when the connection is RUNNING (or INVALID) and remove the tight loop in iscsi_conn_flush_pdus(). Set timeout of logout request as 30 seconds. 30 seconds is as same as NOP timeout and will be reasonable for now. Add and use logout_request_timer to check the timeout. When the connection gets internal a logout request, move the connection to EXITING state if the connection is in INVALID state, request logout to initiator and start 30 seconds timer if the connection is in RUNNING state and logout is not requested yet, or do nothing otherwise. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I43192be9fd7112ad444152c0dd88f99a14aa8d30 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470705 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-10-08 00:30:42 +00:00
/* Timer used to destroy connection after requesting logout if
* initiator does not send logout request.
*/
struct spdk_poller *logout_request_timer;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/* Timer used to destroy connection after logout if initiator does
* not close the connection.
*/
iscsi: convert connection timers to SPDK pollers Change-Id: I1a3da62409e5dce82fa45d20f433fd791cc0ca20 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-10-05 17:23:48 +00:00
struct spdk_poller *logout_timer;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
/* Timer used to wait for connection to close
*/
iscsi: convert connection timers to SPDK pollers Change-Id: I1a3da62409e5dce82fa45d20f433fd791cc0ca20 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-10-05 17:23:48 +00:00
struct spdk_poller *shutdown_timer;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
struct spdk_iscsi_pdu *pdu_in_progress;
lib/iscsi: Introduce state machine into receive PDUs operation Add PDU receive state to each connection, and each connection transits among states during receiving incoming PDUs. Four states, AWAIT_PDU_READY, AWAIT_PDU_HDR, AWAIT_PDU_PAYLOAD, and ERROR are same as SPDK NVMe-TCP target. Move clearing conn->pdu_in_progress just before putting pdu when PDU processing completes normally to match with error case. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: Id24b6d6662896b5685125a46ee20cbf216668838 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469966 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-10-15 01:37:21 +00:00
enum iscsi_pdu_recv_state pdu_recv_state;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
TAILQ_HEAD(, spdk_iscsi_pdu) write_pdu_list;
TAILQ_HEAD(, spdk_iscsi_pdu) snack_pdu_list;
int pending_r2t;
struct spdk_iscsi_task *outstanding_r2t_tasks[DEFAULT_MAXR2T];
uint16_t cid;
/* IP address */
char initiator_addr[MAX_INITIATOR_ADDR];
char target_addr[MAX_TARGET_ADDR];
/* Initiator/Target port binds */
char initiator_name[MAX_INITIATOR_NAME];
struct spdk_scsi_port *initiator_port;
char target_short_name[MAX_TARGET_NAME];
struct spdk_scsi_port *target_port;
struct spdk_iscsi_tgt_node *target;
struct spdk_scsi_dev *dev;
/* for fast access */
int header_digest;
int data_digest;
int full_feature;
struct iscsi_param *params;
bool sess_param_state_negotiated[MAX_SESSION_PARAMS];
bool conn_param_state_negotiated[MAX_CONNECTION_PARAMS];
struct iscsi_chap_auth auth;
iscsi: Make names of CHAP parameters consistent CHAP parameters in struct spdk_iscsi_conn had not been changed even after iSCSI CHAP was refactored and enhanced. Use names in iSCSI subsystem throughout. Change-Id: Ic61b0db42adaa406ab48cf3857a4c2859c88690d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/437056 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-12-13 05:08:59 +00:00
bool authenticated;
lib/iscsi: Separate CHAP params setup and authentication process This is a preparation to support per portal group CHAP authentication for discovery session. Previously require_chap, disable_chap, and mutual_chap had been set and used in iscsi_negotiate_param(), and chap_group had been set and used in iscsi_get_authinfo(). If a connection is in a discovery session, the connection can get all CHAP params at its creation, spdk_iscsi_conn_construct(). If a connection is in a normal session, the connection can get all CHAP params in iscsi_op_login_negotiate_chap_param(). Each connection is in either discovery session or normal session. So the following change is possible and is done in this patch. spdk_iscsi_conn_construct() sets all CHAP params of the connection by global parameters. Then iscsi_op_login_negotiate_chap_param() overwrites them by the corresponding target's parameters. iscsi_negotiate_chap_param() and iscsi_get_authinfo() just refer the CHAP params. Besides, iscsi_get_authinfo() changed to call just spdk_iscsi_chap_get_authinfo() inside, and so inline spdk_iscsi_chap_get_authinfo() into iscsi_auth_params() and then remove iscsi_get_authinfo(). Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I8028673cc6923e1b8bc20af55e0c3cc933972fc0 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469218 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-09-25 04:34:38 +00:00
bool disable_chap;
iscsi: Make names of CHAP parameters consistent CHAP parameters in struct spdk_iscsi_conn had not been changed even after iSCSI CHAP was refactored and enhanced. Use names in iSCSI subsystem throughout. Change-Id: Ic61b0db42adaa406ab48cf3857a4c2859c88690d Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/437056 Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-12-13 05:08:59 +00:00
bool require_chap;
bool mutual_chap;
lib/iscsi: Separate CHAP params setup and authentication process This is a preparation to support per portal group CHAP authentication for discovery session. Previously require_chap, disable_chap, and mutual_chap had been set and used in iscsi_negotiate_param(), and chap_group had been set and used in iscsi_get_authinfo(). If a connection is in a discovery session, the connection can get all CHAP params at its creation, spdk_iscsi_conn_construct(). If a connection is in a normal session, the connection can get all CHAP params in iscsi_op_login_negotiate_chap_param(). Each connection is in either discovery session or normal session. So the following change is possible and is done in this patch. spdk_iscsi_conn_construct() sets all CHAP params of the connection by global parameters. Then iscsi_op_login_negotiate_chap_param() overwrites them by the corresponding target's parameters. iscsi_negotiate_chap_param() and iscsi_get_authinfo() just refer the CHAP params. Besides, iscsi_get_authinfo() changed to call just spdk_iscsi_chap_get_authinfo() inside, and so inline spdk_iscsi_chap_get_authinfo() into iscsi_auth_params() and then remove iscsi_get_authinfo(). Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I8028673cc6923e1b8bc20af55e0c3cc933972fc0 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469218 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-09-25 04:34:38 +00:00
int32_t chap_group;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
uint32_t pending_task_cnt;
uint32_t data_out_cnt;
uint32_t data_in_cnt;
int timeout;
uint64_t nopininterval;
bool nop_outstanding;
/*
* This is the maximum data segment length that iscsi target can send
* to the initiator on this connection. Not to be confused with the
* maximum data segment length that initiators can send to iscsi target, which
* is statically defined as SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH.
*/
int MaxRecvDataSegmentLength;
uint32_t StatSN;
uint32_t exp_statsn;
scripts/check_format.sh: check spaces in comments Fix up all existing spacing errors in comments and add an automated check for patterns like /*comment*/. Change-Id: I28f61c93612dc0f8aed66bd509da78e91ea9737e Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-04-24 18:14:41 +00:00
uint32_t ttt; /* target transfer tag */
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
char *partial_text_parameter;
STAILQ_ENTRY(spdk_iscsi_conn) link;
iscsi: use temporary poller when PDUs cannot all be flushed This removes PDU flushing from the main connection poller - all PDU flushing is now done inline when the PDU is completed, or from the context of the new flush poller. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I703cb451d4b548e7f75892e31a7927b511fb4f55 Reviewed-on: https://review.gerrithub.io/395543 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com>
2018-01-19 17:22:41 +00:00
struct spdk_poller *flush_poller;
iscsi: Solve the potential no io channel issue. Reason: If we trigger the spdk_iscsi_conn_migration, we may face the issue that the io channel of lun is NULL(which means not allocated). So I think that if we trigger the migration, we need to stop the executing the further pdu of this conn by the current polling group. Also since the connection is triggered migration, we should stop execution on the current core, and let this connection be handled by next round. Change-Id: I0ab89d79c976f3233890ae25cb7eac98de5e30ac Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/409984 Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-05-04 06:43:59 +00:00
bool is_stopped; /* Set true when connection is stopped for migration */
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
TAILQ_HEAD(queued_r2t_tasks, spdk_iscsi_task) queued_r2t_tasks;
TAILQ_HEAD(active_r2t_tasks, spdk_iscsi_task) active_r2t_tasks;
TAILQ_HEAD(queued_datain_tasks, spdk_iscsi_task) queued_datain_tasks;
iscsi: Support hot removal of LUN based on LUN open/close When hot removal of a LUN is started, callback is called for each iSCSI connection which accesses the LUN. Callback checks all transfer tasks complete and then close the LUN. If the connection clears all transfer tasks before getting all responses to them from the initiator, the initiator continues to retry data write. Hence the connection have to wait until all transfer tasks complete. Change-Id: Iad9063673cfedbd78758890d55a4254512e4fca4 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/417199 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-07-04 05:23:55 +00:00
lib/scsi: Add lun to the names of descriptors and callback for LUN The next patch will add the function ponter typedef spdk_scsi_dev_destruct_cb for SCSI device destruction. Hence add lun to the names of descriptors and callback for SCSI LUN for clarification. This patch doesn't change any behavior. Change-Id: I73f2bce9129f7a6f16770ab6ed18428b16589108 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450883 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2019-04-11 02:01:30 +00:00
struct spdk_scsi_lun_desc *open_lun_descs[SPDK_SCSI_DEV_MAX_LUN];
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
};
iscsi: move extern g_conn_array to conn.h (#111)
2017-02-13 16:57:37 +00:00
extern struct spdk_iscsi_conn *g_conns_array;
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
int spdk_initialize_iscsi_conns(void);
void spdk_shutdown_iscsi_conns(void);
lib/iscsi: Request logout to asynchronously to initiator Request logout to the initiator asynchronously when exiting the running connection from the target. Based on this patch, the next patch will make flushing PDUs possible only when the connection is RUNNING (or INVALID) and remove the tight loop in iscsi_conn_flush_pdus(). Set timeout of logout request as 30 seconds. 30 seconds is as same as NOP timeout and will be reasonable for now. Add and use logout_request_timer to check the timeout. When the connection gets internal a logout request, move the connection to EXITING state if the connection is in INVALID state, request logout to initiator and start 30 seconds timer if the connection is in RUNNING state and logout is not requested yet, or do nothing otherwise. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I43192be9fd7112ad444152c0dd88f99a14aa8d30 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/470705 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-10-08 00:30:42 +00:00
void spdk_iscsi_conns_request_logout(struct spdk_iscsi_tgt_node *target);
lib/iscsi: Make two helper functions from private to public in iSCSI library These change will be used in the next patch. Change-Id: Ifdb4ccf20049b46e850122a4021cbbe7441e1270 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/450736 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-04-10 08:01:43 +00:00
int spdk_iscsi_get_active_conns(struct spdk_iscsi_tgt_node *target);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
net, iscsi: add struct spdk_sock abstraction This provides an abstraction layer around TCP sockets. Previously we just used fd integers, but we don't want to be tied to integers for alternative userspace TCP stacks. Future patches will do more work to enable multiple implementations of this abstraction. For now, just get the abstraction in place for POSIX sockets and make all of the iSCSI changes associated with it. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I9a825e9e02eb6927c8702d205665c626f57b3771 Reviewed-on: https://review.gerrithub.io/398861 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ziye Yang <optimistyzy@gmail.com>
2018-02-07 21:46:22 +00:00
int spdk_iscsi_conn_construct(struct spdk_iscsi_portal *portal, struct spdk_sock *sock);
lib/iscsi: Remove spdk_iscsi_conn_check_state This patch will also re-export spdk_iscsi_conn_destruct Change-Id: I7d6cbba33294c84398a919d888c8b375e901e09e Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/402485 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-03-06 04:46:55 +00:00
void spdk_iscsi_conn_destruct(struct spdk_iscsi_conn *conn);
lib/iscsi: Add nop_poller for iscsi polling group. Change-Id: I7f0f64845a5b980632991e7b6d130e4be60ffa20 Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/401749 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-02-28 05:55:38 +00:00
void spdk_iscsi_conn_handle_nop(struct spdk_iscsi_conn *conn);
iscsi: Rename spdk_iscsi_conn_migrate to spdk_iscsi_conn_schedule This function is in charge of scheduling new connections onto cores. It used to be used to dynamically migrate connections, but we no longer do that. Change-Id: I2fa04a7dfb43bf9fae7902376ba5ba6d18744469 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/452727 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-04-29 23:21:52 +00:00
void spdk_iscsi_conn_schedule(struct spdk_iscsi_conn *conn);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
void spdk_iscsi_conn_logout(struct spdk_iscsi_conn *conn);
int spdk_iscsi_drop_conns(struct spdk_iscsi_conn *conn,
const char *conn_match, int drop_all);
iscsi: Add a function to read PDU data from socket by spdk_sock_readv This patch adds spdk_iscsi_conn_readv_data() to read PDU data from network socket by using spdk_sock_readv(). Additionally, this patch changes the existing spdk_iscsi_conn_read_data() to call spdk_iscsi_conn_readv_data() by creating a single struct iovec. Change-Id: Ied487bb71bd4261ad53c9f3744ae272e65f98d7a Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/446377 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-02-27 02:06:25 +00:00
int spdk_iscsi_conn_read_data(struct spdk_iscsi_conn *conn, int len, void *buf);
int spdk_iscsi_conn_readv_data(struct spdk_iscsi_conn *conn,
struct iovec *iov, int iovcnt);
iscsi: put spdk_iscsi_conn_write_pdu() in lib/iscsi/conn.c This function was originally named spdk_iscsi_write_pdu() in lib/iscsi/iscsi.c. Since this is an operation on a connection, add "conn" to the name and move it to conn.c. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaad022907d43788108d5b2660306abcf5e94040d Reviewed-on: https://review.gerrithub.io/395522 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: <shuhei.matsumoto.xt@hitachi.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2018-01-18 06:34:47 +00:00
void spdk_iscsi_conn_write_pdu(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
iscsi: fix big READ task release process for ERL1 When we enabled the ERL1 configuation, for the DATAIN task release process, we will queue the task to the SNACK list firstly, and then remove the list when got ACK from initiator, but for this part of logic, the reference count of primary task was not released correctly. Change-Id: Ic5959cf644c74f676be0b84c5650292dc426b2d8 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
2016-12-07 05:02:40 +00:00
void spdk_iscsi_conn_free_pdu(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu);
iscsi: Factor out JSON information of connection Factor out writing connection information to JSON context into a helper function spdk_iscsi_conn_info_json. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I3e92bcb4f21cc7a36af182f850c944b8c5dd559f Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463568 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
2019-07-30 04:59:51 +00:00
void spdk_iscsi_conn_info_json(struct spdk_json_write_ctx *w, struct spdk_iscsi_conn *conn);
iscsi: Add an iscsi library. Change-Id: I28f3f4723a66f845eb478a6873d7aedb8f5409b8 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-02 16:34:45 +00:00
#endif /* SPDK_ISCSI_CONN_H */
Reference in New Issue Copy Permalink