优化代码

app/Http/Controllers/Admin/MaintenanceController.php

@@ -23,23 +23,11 @@ public function index(): View
         return view('admin.maintenances.index', compact('maintenances'));
     }
 
-    /**
-     * Show the form for creating a new resource.
-     *
-     * @return View
-     */
-    public function create(): View
-    {
-        $modules = (new Module)->all();
-
-        return view('admin.maintenances.create', compact('modules'));
-    }
-
     /**
      * Store a newly created resource in storage.
      *
-     * @param  \Illuminate\Http\Request  $request
+     * @param  Request  $request
-     * @return \Illuminate\Http\Response
+     * @return RedirectResponse
      */
     public function store(Request $request): RedirectResponse
     {
@@ -56,6 +44,18 @@ public function store(Request $request): RedirectResponse
         return redirect()->route('admin.maintenances.index')->with('success', '维护信息已创建。');
     }
 
+    /**
+     * Show the form for creating a new resource.
+     *
+     * @return View
+     */
+    public function create(): View
+    {
+        $modules = (new Module)->all();
+
+        return view('admin.maintenances.create', compact('modules'));
+    }
+
     /**
      * Show the form for editing the specified resource.
      *
@@ -72,9 +72,9 @@ public function edit(Maintenance $maintenance): View
     /**
      * Update the specified resource in storage.
      *
-     * @param  \Illuminate\Http\Request  $request
+     * @param  Request  $request
      * @param  Maintenance  $maintenance
-     * @return \Illuminate\Http\Response
+     * @return RedirectResponse
      */
     public function update(Request $request, Maintenance $maintenance): RedirectResponse
     {
@@ -95,7 +95,7 @@ public function update(Request $request, Maintenance $maintenance): RedirectResp
      * Remove the specified resource from storage.
      *
      * @param  Maintenance  $maintenance
-     * @return \Illuminate\Http\Response
+     * @return RedirectResponse
      */
     public function destroy(Maintenance $maintenance): RedirectResponse
     {

app/Models/Maintenance.php

@@ -3,6 +3,7 @@
 namespace App\Models;
 
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
 class Maintenance extends Model
 {
@@ -36,7 +37,7 @@ public function scopeOrderByStartAt($query)
         return $query->orderBy('start_at', 'desc');
     }
 
-    public function module()
+    public function module(): BelongsTo
     {
         return $this->belongsTo(Module::class);
     }