From e9cdf6225fa73484c0c09b7aaec1e8acbda729cc Mon Sep 17 00:00:00 2001
From: Nicolas Patry <patry.nicolas@protonmail.com>
Date: Thu, 5 Oct 2023 13:35:26 +0200
Subject: [PATCH] Hotfixing idefics base64 parsing. (#1103)

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet
though.

Once merged, your PR is going to appear in the release notes with the
title you set, so make sure it's a great title that fully reflects the
extent of your awesome contribution.

Then, please replace this with a description of the change and which
issue is fixed (if applicable). Please also include relevant motivation
and context. List any dependencies (if any) that are required for this
change.

Once you're done, someone will review your PR shortly (see the section
"Who can review?" below to tag some potential reviewers). They may
suggest changes to make the code even better. If no one reviewed your PR
after a week has passed, don't hesitate to post a new comment
@-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the
other checks if that's the case).
- [ ] Did you read the [contributor
guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the
[forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes?
Here are the
[documentation
guidelines](https://github.com/huggingface/transformers/tree/main/docs),
and
[here are tips on formatting
docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have
passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the
right person to tag with @


@OlivierDehaene OR @Narsil

 -->
---
 .../models/custom_modeling/idefics_image_processing.py    | 7 ++++++-
 .../models/custom_modeling/idefics_processing.py          | 8 +++++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/server/text_generation_server/models/custom_modeling/idefics_image_processing.py b/server/text_generation_server/models/custom_modeling/idefics_image_processing.py
index 21aa3ff3..4760ae6f 100644
--- a/server/text_generation_server/models/custom_modeling/idefics_image_processing.py
+++ b/server/text_generation_server/models/custom_modeling/idefics_image_processing.py
@@ -201,8 +201,13 @@ class IdeficsImageProcessor(BaseImageProcessor):
                 response = requests.get(image_url_or_urls, stream=True, headers=headers, timeout=(1, 5))
                 response.raise_for_status()
                 content = response.content
-            else:
+            elif image.startswith("data:"):
+                # https://stackoverflow.com/questions/17090571/is-there-a-way-to-set-background-image-as-a-base64-encoded-image
+                # data:image/png;base64,xxx
+                image = image.split(",")[-1]
                 content = base64.b64decode(image)
+            else:
+                raise ValueError(f"Unrecognized image {image}")
 
             try:
                 image = Image.open(BytesIO(content))
diff --git a/server/text_generation_server/models/custom_modeling/idefics_processing.py b/server/text_generation_server/models/custom_modeling/idefics_processing.py
index 0fbcbeeb..98e43a27 100644
--- a/server/text_generation_server/models/custom_modeling/idefics_processing.py
+++ b/server/text_generation_server/models/custom_modeling/idefics_processing.py
@@ -112,6 +112,11 @@ def is_url(string):
     result = urlparse(string)
     return all([result.scheme, result.netloc])
 
+def is_image(string):
+    """Checks if the passed string contains a valid url and nothing else. e.g. if space is included it's immediately
+    invalidated the url"""
+    return is_url(string) or string.startswith("data:")
+
 
 class IdeficsProcessor(ProcessorMixin):
     r"""
@@ -314,7 +319,7 @@ class IdeficsProcessor(ProcessorMixin):
 
                 if isinstance(item, str):
                     item = item.strip(" ")
-                    if is_url(item):
+                    if is_image(item):
                         image = self.image_processor.fetch_images(item)
                         full_text += image_tokens(last_was_image)
                         image_objects.append(image)
@@ -339,6 +344,7 @@ class IdeficsProcessor(ProcessorMixin):
 
             image_objects = self.image_processor(image_objects, transform=transform)
 
+
             text_encoding = self.tokenizer(
                 text=full_text,
                 add_special_tokens=False,