huggingface/text-generation-inference
5
0
Fork 0
mirror of https://github.com/huggingface/text-generation-inference.git synced 2025-09-08 19:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

HuggingFaceM4/Idefics3-8B-Llama3 crash fix (#3267)

Browse Source 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
This commit is contained in:
Wang, Yi 2025-08-21 16:04:30 +08:00 committed by GitHub
parent c5e6f9a178
commit d618424d50
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
router/src/config.rs
View File

@ -265,6 +265,10 @@ impl Idefics3 {
pub fn get_max_longest_edge_for_image_resize(&self) -> usize {
1456
}
pub fn get_max_image_size(&self) -> usize {
4096
}
}
#[derive(Clone, Debug, Serialize, Deserialize)]

31
router/src/validation.rs
View File

@ -646,25 +646,20 @@ fn image_tokens(
const GLOBAL_IMG: &str = "<global-img>";
let max_longest_edge_for_image_resize = config.get_max_longest_edge_for_image_resize();
let max_image_size = config.get_max_image_size();
// resize image if it is larger than max_longest_edge_for_image_resize keeping aspect ratio
let (height, width) = if height > max_longest_edge_for_image_resize
|| width > max_longest_edge_for_image_resize
{
let aspect_ratio = height as f32 / width as f32;
if height > width {
(
max_longest_edge_for_image_resize,
(max_longest_edge_for_image_resize as f32 / aspect_ratio) as usize,
)
} else {
(
(max_longest_edge_for_image_resize as f32 * aspect_ratio) as usize,
max_longest_edge_for_image_resize,
)
}
} else {
(height, width)
let (height, width) = {
let h = height as f32;
let w = width as f32;
// First resize to max_longest_edge (always scale to this size)
let scale1 = max_longest_edge_for_image_resize as f32 / h.max(w);
let (h, w) = (h * scale1, w * scale1);
// Ensure we dont exceed max_size (only scale down)
let scale2 = (max_image_size as f32 / h.max(w)).min(1.0);
((h * scale2) as usize, (w * scale2) as usize)
};
let image_seq_len = config.get_number_of_features();