huggingface/text-generation-inference
5
0
Fork 0
mirror of https://github.com/huggingface/text-generation-inference.git synced 2025-09-11 20:34:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Nicolas Patry 2024-05-28 11:51:16 +02:00 committed by GitHub
parent 7b368b7644
commit b759cc337b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
router/src/server.rs
View File

@ -1667,47 +1667,8 @@ pub async fn run(
#[cfg(feature = "ngrok")] #[cfg(feature = "ngrok")]
{ {
panic!("ngrok feature is not functional with axum=0.7 and hyper=1, waiting on https://github.com/ngrok/ngrok-rust/pull/137/files to re-enable."); panic!("ngrok feature is not functional with axum=0.7 and hyper=1, waiting on https://github.com/ngrok/ngrok-rust/pull/137/files to re-enable.");
// use ngrok::config::TunnelBuilder;
// let _ = addr;
// let authtoken =
// ngrok_authtoken.expect("`ngrok-authtoken` must be set when using ngrok tunneling");
// let edge = ngrok_edge.expect("`ngrok-edge` must be set when using ngrok tunneling");
// let tunnel = ngrok::Session::builder()
// .authtoken(authtoken)
// .connect()
// .await
// .unwrap()
// .labeled_tunnel()
// .label("edge", edge);
// let listener = tunnel.listen().await.unwrap();
// let router = Router::new()
// .route("/health", get(health))
// .route("/metrics", get(metrics))
// .layer(Extension(health_ext))
// .layer(Extension(prom_handle))
// .into_make_service();
// // Run prom metrics and health locally too
// let tokio_listener = tokio::net::TcpListener::bind(&addr).await.unwrap();
// axum::serve(tokio_listener, router)
// .with_graceful_shutdown(shutdown_signal())
// .await?;
// axum::serve(listener, app)
// .with_graceful_shutdown(shutdown_signal())
// .await?;
// Run server // Run server
// axum::Server::builder(listener)
// .serve(app.into_make_service())
// //Wait until all requests are finished to shut down
// .with_graceful_shutdown(shutdown_signal())
// .await?;
} }
#[cfg(not(feature = "ngrok"))] #[cfg(not(feature = "ngrok"))]
{ {