From b0e66983be52823c9bb1e6f3ac839983c2c4ba58 Mon Sep 17 00:00:00 2001 From: Alex Weston Date: Fri, 7 Feb 2025 13:16:49 -0500 Subject: [PATCH] Record request parameters in OTel span for /v1/chat/completions endpoint --- router/src/server.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/router/src/server.rs b/router/src/server.rs index 9e57af27..df63c675 100644 --- a/router/src/server.rs +++ b/router/src/server.rs @@ -1217,7 +1217,7 @@ example = json ! ({"error": "Incomplete generation"})), #[instrument( skip_all, fields( -// parameters = ? req.parameters, +parameters, total_time, validation_time, queue_time, @@ -1243,7 +1243,7 @@ pub(crate) async fn chat_completions( } = chat.clone(); let (generate_request, using_tools): (GenerateRequest, bool) = chat.try_into_generate(&infer)?; - + span.record("parameters", format!("{:?}", generate_request.parameters)); let logprobs = logprobs.unwrap_or_default(); // extract model id from request if specified