From a2c935d5fb494d86457c5df439ed2969bb6d8443 Mon Sep 17 00:00:00 2001 From: drbh Date: Wed, 17 Apr 2024 14:11:16 +0000 Subject: [PATCH] fix: simplify changes --- router/src/server.rs | 4 ++-- router/src/validation.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/router/src/server.rs b/router/src/server.rs index 2f87eaeb..6710baf6 100644 --- a/router/src/server.rs +++ b/router/src/server.rs @@ -1009,9 +1009,9 @@ async fn chat_completions( let logprobs = logprobs.unwrap_or(false); let tool_prompt = tool_prompt.unwrap_or_default(); let stop = stop.unwrap_or_default(); - // rescale temperature starting from 0.0 to 1.0 + // chat temperature is zero-indexed instead of one-indexed; so we add 1.0 to the input or default to 1.0 let adjusted_temperature = temperature.map_or(1.0, |t| t + 1.0); - let do_sample = adjusted_temperature != 0.0; + let do_sample = adjusted_temperature != 1.0; let temperature = Some(adjusted_temperature); // extract tool grammar if present diff --git a/router/src/validation.rs b/router/src/validation.rs index 926625c2..2029c7e0 100644 --- a/router/src/validation.rs +++ b/router/src/validation.rs @@ -217,7 +217,7 @@ impl Validation { } let temperature = temperature.unwrap_or(1.0); - if temperature < 0.0 { + if temperature <= 0.0 { return Err(ValidationError::Temperature); }