From 6c65632dcbe3a14366fd52fda46b52ac9afcac29 Mon Sep 17 00:00:00 2001 From: fxmarty <9808326+fxmarty@users.noreply.github.com> Date: Sun, 19 May 2024 17:37:29 -0700 Subject: [PATCH] make CK FA default --- Dockerfile_amd | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Dockerfile_amd b/Dockerfile_amd index 6f8f874b..92dd0ea8 100644 --- a/Dockerfile_amd +++ b/Dockerfile_amd @@ -117,8 +117,9 @@ RUN cd pytorch && python tools/amd_build/build_amd.py && python setup.py install # Set as recommended: https://github.com/ROCm/triton/wiki/A-script-to-set-program-execution-environment-in-ROCm ENV HIP_FORCE_DEV_KERNARG=1 -# On MI300, performances for flash with Triton FA is very competitive (actually better than CK) -ENV ROCM_USE_FLASH_ATTN_V2_TRITON=1 +# On MI250 and MI300, performances for flash with Triton FA are slightly better than CK. +# However, Triton requires a tunning for each prompt length, which is prohibitive. +ENV ROCM_USE_FLASH_ATTN_V2_TRITON=0 FROM base AS kernel-builder