From 58a65f7914d5f1e6161996a4d0f9c74f0e256bab Mon Sep 17 00:00:00 2001 From: Alex Weston <43505988+aW3st@users.noreply.github.com> Date: Mon, 10 Mar 2025 07:26:57 -0400 Subject: [PATCH] Add request parameters to OTel span for `/v1/chat/completions` endpoint (#3000) Record request parameters in OTel span for /v1/chat/completions endpoint --- router/src/server.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/router/src/server.rs b/router/src/server.rs index 6e55d2bc..0b4da9ad 100644 --- a/router/src/server.rs +++ b/router/src/server.rs @@ -1217,7 +1217,7 @@ example = json ! ({"error": "Incomplete generation"})), #[instrument( skip_all, fields( -// parameters = ? req.parameters, +parameters, total_time, validation_time, queue_time, @@ -1243,7 +1243,7 @@ pub(crate) async fn chat_completions( } = chat.clone(); let (generate_request, using_tools): (GenerateRequest, bool) = chat.try_into_generate(&infer)?; - + span.record("parameters", format!("{:?}", generate_request.parameters)); let logprobs = logprobs.unwrap_or_default(); // extract model id from request if specified