fix instrumentation

This commit is contained in:
OlivierDehaene 2023-04-04 14:51:31 +02:00
parent 161e93a45f
commit 30148b776b
2 changed files with 7 additions and 6 deletions

View File

@ -87,7 +87,11 @@ impl Infer {
})?; })?;
// Validate request // Validate request
let valid_request = self.validation.validate(request).await?; let valid_request = self.validation.validate(request).await.map_err(|err| {
metrics::increment_counter!("tgi_request_failure", "err" => "validation");
tracing::error!("{err}");
err
})?;
// MPSC channel to communicate with the background batching task // MPSC channel to communicate with the background batching task
let (response_tx, response_rx) = flume::unbounded(); let (response_tx, response_rx) = flume::unbounded();

View File

@ -59,6 +59,7 @@ impl Validation {
} }
} }
#[instrument(skip_all)]
async fn validate_input( async fn validate_input(
&self, &self,
inputs: String, inputs: String,
@ -270,11 +271,7 @@ fn tokenizer_worker(tokenizer: Tokenizer, receiver: flume::Receiver<TokenizerReq
while let Ok(((inputs, truncate), response_tx, parent_span)) = receiver.recv() { while let Ok(((inputs, truncate), response_tx, parent_span)) = receiver.recv() {
parent_span.in_scope(|| { parent_span.in_scope(|| {
response_tx response_tx
.send(prepare_input(inputs, truncate, &tokenizer).map_err(|err| { .send(prepare_input(inputs, truncate, &tokenizer))
metrics::increment_counter!("tgi_request_failure", "err" => "validation");
tracing::error!("{err}");
err
}))
.unwrap_or(()) .unwrap_or(())
}) })
} }